From nobody Sat Feb 7 06:40:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571314892; cv=none; d=zoho.com; s=zohoarc; b=OnkMJRHcq2A73wCZ3QNyN3Tw6c69+hCs1HqpZNR2wXly0FgDlvN+fig6TFxq27fqyoFv2vx5lI6YdX+NIhbEpIsSkuIXIyYq6je16Zt8yvn8M8XVEG3RXSWs8x/unPbgoW9pq3LDga7VUVkRZJlj7bjYNLzYoTyYMuan4tYqxj8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571314892; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ifau+AAVF1kGbiaSk+Et5Yr/tMr+J0KiOlYQfoZj8l4=; b=X6VgAHsQnL+2yD9m7SnEMTF7e+JLSu+TLjo2kbMPyPMKHt9zbFFwflTslJFgBIiLhPfO39mkZ7bNpdxFQymYR5c1PhkPNd9ctt0Z9HMHG08T7WWkeTrUaQ+a3fOlB73/GeB1vrZfi6/3ErIL2IkbT0xPlIEA1YKJVphpe/7/OsQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571314892651227.37928273932516; Thu, 17 Oct 2019 05:21:32 -0700 (PDT) Received: from localhost ([::1]:45848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL4mQ-0006oi-AX for importer@patchew.org; Thu, 17 Oct 2019 08:21:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54297) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iL4kh-0005eI-Kv for qemu-devel@nongnu.org; Thu, 17 Oct 2019 08:19:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iL4ke-0006hi-35 for qemu-devel@nongnu.org; Thu, 17 Oct 2019 08:19:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56588) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iL4kd-0006gn-U7; Thu, 17 Oct 2019 08:19:32 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A1B2051EF6; Thu, 17 Oct 2019 12:19:27 +0000 (UTC) Received: from t460s.redhat.com (ovpn-117-42.ams2.redhat.com [10.36.117.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2393A5D9CA; Thu, 17 Oct 2019 12:19:22 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v1] s390x/mmu: Remove duplicate check for MMU_DATA_STORE Date: Thu, 17 Oct 2019 14:19:22 +0200 Message-Id: <20191017121922.18840-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 17 Oct 2019 12:19:27 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Janosch Frank , David Hildenbrand , Cornelia Huck , Richard Henderson , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" No need to double-check if we have a write. Found by Coverity (CID: 1381016). Fixes: 31b59419069e ("target/s390x: Return exception from mmu_translate_rea= l") Cc: Peter Maydell Signed-off-by: David Hildenbrand Reviewed-by: Richard Henderson --- target/s390x/mmu_helper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/s390x/mmu_helper.c b/target/s390x/mmu_helper.c index 90b81335f9..c9f3f34750 100644 --- a/target/s390x/mmu_helper.c +++ b/target/s390x/mmu_helper.c @@ -556,9 +556,7 @@ int mmu_translate_real(CPUS390XState *env, target_ulong= raddr, int rw, *flags |=3D PAGE_WRITE_INV; if (is_low_address(raddr) && rw =3D=3D MMU_DATA_STORE) { /* LAP sets bit 56 */ - *tec =3D (raddr & TARGET_PAGE_MASK) - | (rw =3D=3D MMU_DATA_STORE ? FS_WRITE : FS_READ) - | 0x80; + *tec =3D (raddr & TARGET_PAGE_MASK) | FS_WRITE | 0x80; return PGM_PROTECTION; } } --=20 2.21.0