From nobody Sun May 19 19:01:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571158776; cv=none; d=zoho.com; s=zohoarc; b=jwukahSYtpnuex345tE6bpSK+2UwuEAus0UdSttMhWdLkv5Wyn7RU56YhLEB+wkM+zBeiBmNmLyvYUrqordsrDazg6jIs/8xQm5TcrRxvPtYWtZ0TreUSwwGFyTpTOHGbSrTQingxrx2xvQT69zpfBwhq/zOJ8CRVFhH6fNdpKY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571158776; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=miOXaZOWlH0MtRigoKbP/HT+uvt5oPdUt+Dts8XW/Ss=; b=HreTRj84KQcdMDobouJy/65/FZ7mLHHWdWTDvPFU1cMMSEzwBYolH80M4VKqRhUUHa64TDpeMTcefVJtUVybv4UkQCnwPS53DyAaquW9oexZS0yhyTzAhiGg41Zc7k2DisQdqq8iFx673rhSqVdsPJTPTs6wuC7egdtnSsTBhVo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157115877645315.592187864486732; Tue, 15 Oct 2019 09:59:36 -0700 (PDT) Received: from localhost ([::1]:53240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKQAZ-0007Kv-BJ for importer@patchew.org; Tue, 15 Oct 2019 12:59:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43834) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKPyM-0006ZI-1P for qemu-devel@nongnu.org; Tue, 15 Oct 2019 12:46:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKPyJ-0006zb-N2 for qemu-devel@nongnu.org; Tue, 15 Oct 2019 12:46:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35166) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iKPyJ-0006yy-HP; Tue, 15 Oct 2019 12:46:55 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 66187C065113; Tue, 15 Oct 2019 16:46:54 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-35.brq.redhat.com [10.40.204.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9AC460464; Tue, 15 Oct 2019 16:46:45 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH] hw/mem/Kconfig: NVDIMM device requires CONFIG_MEM_DEVICE Date: Tue, 15 Oct 2019 18:46:42 +0200 Message-Id: <20191015164642.31069-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 15 Oct 2019 16:46:54 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Paolo Bonzini , Igor Mammedov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" When selecting only the NVDIMM device with "NVDIMM y", the device is not compiled/linked because it does not select MEM_DEVICE and hw/mem/Makefile.objs is not included: $ git grep mem/ hw/Makefile.objs hw/Makefile.objs:39:devices-dirs-$(CONFIG_MEM_DEVICE) +=3D mem/ Let NVDIMM config select MEM_DEVICE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- I'm not sure this is the best fix, maybe we should simply include mem/ regardless of CONFIG_MEM_DEVICE (all mem devices use it). --- hw/mem/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig index 620fd4cb59..5da724d7a2 100644 --- a/hw/mem/Kconfig +++ b/hw/mem/Kconfig @@ -7,5 +7,6 @@ config MEM_DEVICE =20 config NVDIMM bool + select MEM_DEVICE default y depends on PC --=20 2.21.0