From nobody Wed Nov 12 15:24:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571139209; cv=none; d=zoho.com; s=zohoarc; b=Gt5TCT5LZtpRLUeSD1XlTMUV2jIbKR/Y3Ab9JnAx5CGYDb2Bxrx/X+KEaol3Lq5nefNPh4UiXA1A6x2SaNxOUKZLD8pukI1gTYP0E6Jwg/txsp9bwD7i0/Pw1Y0AtcgWWo/wznpv7DE1MT+G1IqXiv8j+Z4tv3gFDCriVcvRrTc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571139209; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4sP/CdTwxKdjJLLi2lVX9ZyTWHlh4mDgYd5U/QhMDaw=; b=GfDZ8SBcBkBnu8lfzBUJDVTam0akvJVBQj86Vqr8pu6lPlngCX6eZknmlqjTptQbAbhk4yrIIYwmPjLj+Ol7NvFWlNc1zXeEWLkEf3hfPfaRolbRva/j6xQL1L8lDyUFBHYvBPeHVRT3w2XBlWnGlamIWRjJRsBVu+wTmcD9E9g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571139209736170.14054746756028; Tue, 15 Oct 2019 04:33:29 -0700 (PDT) Received: from localhost ([::1]:41604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKL4u-0008S4-5t for importer@patchew.org; Tue, 15 Oct 2019 07:33:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56579) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKKxF-0001VQ-KU for qemu-devel@nongnu.org; Tue, 15 Oct 2019 07:25:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKKxD-0004ie-J4 for qemu-devel@nongnu.org; Tue, 15 Oct 2019 07:25:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35064) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iKKxD-0004gA-DD for qemu-devel@nongnu.org; Tue, 15 Oct 2019 07:25:27 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8DC27C054C52; Tue, 15 Oct 2019 11:25:25 +0000 (UTC) Received: from dritchie.redhat.com (unknown [10.33.36.106]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CD6F1001DE4; Tue, 15 Oct 2019 11:25:13 +0000 (UTC) From: Sergio Lopez To: qemu-devel@nongnu.org Subject: [PATCH v9 11/15] hw/intc/apic: reject pic ints if isa_pic == NULL Date: Tue, 15 Oct 2019 13:23:42 +0200 Message-Id: <20191015112346.45554-12-slp@redhat.com> In-Reply-To: <20191015112346.45554-1-slp@redhat.com> References: <20191015112346.45554-1-slp@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 15 Oct 2019 11:25:25 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, Sergio Lopez , mst@redhat.com, lersek@redhat.com, kraxel@redhat.com, pbonzini@redhat.com, imammedo@redhat.com, sgarzare@redhat.com, philmd@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" In apic_accept_pic_intr(), reject PIC interruptions if a i8259 PIC has not been instantiated (isa_pic =3D=3D NULL). Suggested-by: Paolo Bonzini Signed-off-by: Sergio Lopez Reviewed-by: Michael S. Tsirkin --- hw/intc/apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/apic.c b/hw/intc/apic.c index bce89911dc..2a74f7b4bf 100644 --- a/hw/intc/apic.c +++ b/hw/intc/apic.c @@ -610,7 +610,7 @@ int apic_accept_pic_intr(DeviceState *dev) =20 if ((s->apicbase & MSR_IA32_APICBASE_ENABLE) =3D=3D 0 || (lvt0 & APIC_LVT_MASKED) =3D=3D 0) - return 1; + return isa_pic !=3D NULL; =20 return 0; } --=20 2.21.0