From nobody Mon May 6 15:59:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571129518; cv=none; d=zoho.com; s=zohoarc; b=kJ8vcHEbYFdA20m9pDY4zsn2XsQ3cT30eGimKp9PpipqCwF2JeT1O18E8o5KarIRpWqXwAruuG+wRbCHXwtdbFId9eG9lhNbXXwG+mDCnAzvh7jCRKyZ76otoME9md66QkhdLD6NpTm99njgE/95ZudNh3JfkT8ymi/1zJfPJH8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571129518; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rfN2wTLq0lon5Fn/7hAQ5WVOi7xnw11ZJQke/2nzTxE=; b=J++o24Q2VQgyQZW1MJdRj43Te5tjraRhFbg5B/5bujnErJZP7aueSHG5gFAClB6KELFT6cJdaGURXY0ArC1qhsGZsJWIp/52zSL/xcf9edx0S/ieOum4mkMBzJJEdfUJYMyxKgj7892rXTiNa8U+f5swGS0YgRDsr4jt3p2yADo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571129518908895.556369215958; Tue, 15 Oct 2019 01:51:58 -0700 (PDT) Received: from localhost ([::1]:37780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKIYd-0003lT-OR for importer@patchew.org; Tue, 15 Oct 2019 04:51:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60700) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKIWG-00014O-0Q for qemu-devel@nongnu.org; Tue, 15 Oct 2019 04:49:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKIWE-0002HC-RY for qemu-devel@nongnu.org; Tue, 15 Oct 2019 04:49:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50280) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iKIWE-0002GY-Lw for qemu-devel@nongnu.org; Tue, 15 Oct 2019 04:49:26 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E177618CB90B; Tue, 15 Oct 2019 08:49:25 +0000 (UTC) Received: from localhost (ovpn-116-252.ams2.redhat.com [10.36.116.252]) by smtp.corp.redhat.com (Postfix) with ESMTP id E92D71001B39; Tue, 15 Oct 2019 08:49:19 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PULL v2 1/2] trace: add --group=all to tracing.txt Date: Tue, 15 Oct 2019 09:49:13 +0100 Message-Id: <20191015084914.18045-2-stefanha@redhat.com> In-Reply-To: <20191015084914.18045-1-stefanha@redhat.com> References: <20191015084914.18045-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.63]); Tue, 15 Oct 2019 08:49:25 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" tracetool needs to know the group name ("all", "root", or a specific subdirectory). Also remove the stdin redirection because tracetool.py needs the path to the trace-events file. Update the documentation. Fixes: 2098c56a9bc5901e145fa5d4759f075808811685 ("trace: move setting of group name into Makefiles") Buglink: https://bugs.launchpad.net/bugs/1844814 Reported-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Stefan Hajnoczi Message-Id: <20191009135154.10970-1-stefanha@redhat.com> --- docs/devel/tracing.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/devel/tracing.txt b/docs/devel/tracing.txt index 8231bbf5d1..8c0376fefa 100644 --- a/docs/devel/tracing.txt +++ b/docs/devel/tracing.txt @@ -317,7 +317,8 @@ probes: --binary path/to/qemu-binary \ --target-type system \ --target-name x86_64 \ - qemu.stp + --group=3Dall \ + trace-events-all >qemu.stp =20 To facilitate simple usage of systemtap where there merely needs to be pri= ntf logging of certain probes, a helper script "qemu-trace-stap" is provided. --=20 2.21.0 From nobody Mon May 6 15:59:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1571129480; cv=none; d=zoho.com; s=zohoarc; b=Ndi5yr8LTSCF36lBXv4S7y/F+HX6t4h4BwFupV+M3vemY6r679ywjMoy5VJxVgJY3w+P0Ae189ixT3vtSxbkZ4FUKMWCBdWLcPxQ7Ia/1PhaHj33RnS7RGHITDvQWSlLuVHoqOMTYWyKMC9wrtxJMLsFhWkCSHNM0Zy1rhIpVXU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1571129480; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sexaRL1Mw/Ug2xR9/89JaZw80YJzphuSWyhLReh0f8w=; b=CxG1VQRSU4qKNhz7dnthi2BR4Oocr66hESk74+LM9x4ov0xmJDBrHIvi0YqR3eS5gQuzkEiKkjMoBsW4tx9U3mU8xthwOxF5pLXLkHqRKkCTfgFFYyBEsRYeNIpJrI6ExbZ94R5+j6PU/Wo8I2VfQualIuXCGqCAoMJit5x+JQc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1571129480722103.22980215786004; Tue, 15 Oct 2019 01:51:20 -0700 (PDT) Received: from localhost ([::1]:37762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKIY1-0002eh-8J for importer@patchew.org; Tue, 15 Oct 2019 04:51:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60727) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKIWO-0001Ff-ME for qemu-devel@nongnu.org; Tue, 15 Oct 2019 04:49:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKIWN-0002OY-Me for qemu-devel@nongnu.org; Tue, 15 Oct 2019 04:49:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36118) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iKIWN-0002Nr-Gp for qemu-devel@nongnu.org; Tue, 15 Oct 2019 04:49:35 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B09AB793C4; Tue, 15 Oct 2019 08:49:34 +0000 (UTC) Received: from localhost (ovpn-116-252.ams2.redhat.com [10.36.116.252]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E78C6013A; Tue, 15 Oct 2019 08:49:27 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PULL v2 2/2] trace: avoid "is" with a literal Python 3.8 warnings Date: Tue, 15 Oct 2019 09:49:14 +0100 Message-Id: <20191015084914.18045-3-stefanha@redhat.com> In-Reply-To: <20191015084914.18045-1-stefanha@redhat.com> References: <20191015084914.18045-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 15 Oct 2019 08:49:34 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Stefan Hajnoczi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The following statement produces a SyntaxWarning with Python 3.8: if len(format) is 0: scripts/tracetool/__init__.py:459: SyntaxWarning: "is" with a literal. Di= d you mean "=3D=3D"? Use the conventional len(x) =3D=3D 0 syntax instead. Reported-by: Daniel P. Berrang=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20191010122154.10553-1-stefanha@redhat.com> Signed-off-by: Stefan Hajnoczi --- scripts/tracetool/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index 04279fa62e..44c118bc2a 100644 --- a/scripts/tracetool/__init__.py +++ b/scripts/tracetool/__init__.py @@ -456,12 +456,12 @@ def generate(events, group, format, backends, import tracetool =20 format =3D str(format) - if len(format) is 0: + if len(format) =3D=3D 0: raise TracetoolError("format not set") if not tracetool.format.exists(format): raise TracetoolError("unknown format: %s" % format) =20 - if len(backends) is 0: + if len(backends) =3D=3D 0: raise TracetoolError("no backends specified") for backend in backends: if not tracetool.backend.exists(backend): --=20 2.21.0