From nobody Mon Feb 9 00:19:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1570814081; cv=none; d=zoho.com; s=zohoarc; b=UysR0IxOBfamgUuttqPwp7HBhBxmXznfK0DGG/m7NW1Cm+Av+OmBQnhpOlSJgiKSWTGQV8B6w8XNRdOyTSWA86RbzRW6H+VrlKQTwDAkiKUJxmNMOWJAkGSxrx05NaC3qGYHxpyCwMwON8I8EVwf229fGkls4LUFV4qHsdrW58w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570814081; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L+xJwBsZfMoRMbIHYBwqYP0a7Lsb/n/+rCtH/ui8AuI=; b=ffq5qeezw0KyqL9OgTqM1z7RG8splQTvlrLvlnRVSz8Z3cuKKpD9a8THCKQq+oV3JNbM1NN/a21Df67JxaXgAfKhHYafFzdueJ7YiwWStqbiTcM3qCiX8S845W+94jQG5GaZXlWupuVqGiyntSspUDHZQSTMGLXmDZlM18R44rw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570814081975985.6851224496427; Fri, 11 Oct 2019 10:14:41 -0700 (PDT) Received: from localhost ([::1]:54458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIyUy-0005B1-Fz for importer@patchew.org; Fri, 11 Oct 2019 13:14:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36308) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIxQu-0006CO-Ge for qemu-devel@nongnu.org; Fri, 11 Oct 2019 12:06:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIxQt-0004PA-1L for qemu-devel@nongnu.org; Fri, 11 Oct 2019 12:06:24 -0400 Received: from relay.sw.ru ([185.231.240.75]:48024) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIxQs-0004Bj-QL for qemu-devel@nongnu.org; Fri, 11 Oct 2019 12:06:22 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from ) id 1iIxQg-0003XG-Au; Fri, 11 Oct 2019 19:06:10 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [RFC v5 041/126] IPack: introduce ERRP_AUTO_PROPAGATE Date: Fri, 11 Oct 2019 19:04:27 +0300 Message-Id: <20191011160552.22907-42-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191011160552.22907-1-vsementsov@virtuozzo.com> References: <20191011160552.22907-1-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , vsementsov@virtuozzo.com, Alberto Garcia , armbru@redhat.com, Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp =3D=3D &fatal_err (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want to check error after errp-function call, we need to introduce local_err and than propagate it to errp. Instead, use ERRP_AUTO_PROPAGATE macro, benefits are: 1. No need of explicit error_propagate call 2. No need of explicit local_err variable: use errp directly 3. ERRP_AUTO_PROPAGATE leaves errp as is if it's not NULL or &error_fatel, this means that we don't break error_abort (we'll abort on error_set, not on error_propagate) This commit (together with its neighbors) was generated by for f in $(git grep -l errp \*.[ch]); do \ spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h --in-place --no-show-diff $f; \ done; then fix a bit of compilation problems: coccinelle for some reason leaves several f() { ... goto out; ... out: } patterns, with "out:" at function end. then ./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)" (auto-msg was a file with this commit message) Still, for backporting it may be more comfortable to use only the first command and then do one huge commit. Reported-by: Kevin Wolf Reported-by: Greg Kurz Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/ipack/ipack.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/ipack/ipack.c b/hw/ipack/ipack.c index 30e16696c0..a9bc7bd269 100644 --- a/hw/ipack/ipack.c +++ b/hw/ipack/ipack.c @@ -62,13 +62,12 @@ static void ipack_device_realize(DeviceState *dev, Erro= r **errp) =20 static void ipack_device_unrealize(DeviceState *dev, Error **errp) { + ERRP_AUTO_PROPAGATE(); IPackDevice *idev =3D IPACK_DEVICE(dev); IPackDeviceClass *k =3D IPACK_DEVICE_GET_CLASS(dev); - Error *err =3D NULL; =20 if (k->unrealize) { - k->unrealize(dev, &err); - error_propagate(errp, err); + k->unrealize(dev, errp); return; } =20 --=20 2.21.0