From nobody Tue May 7 12:08:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570784924; cv=none; d=zoho.com; s=zohoarc; b=iFVI1W+sMviYZ/E8JX4GR/iotVmBcV0xSthI6uHH89g1b4FYZybqDo3Ib81DMtM7o/QDM3A+we2uV7deQcRGpCE0ZbBrGZxf2803Me53BbYOrCvGFvmChXAO9Ral3xUxZ583DWQBsErmxUFy0DBalLSKMOAKbZ9ifwEVC89vu1w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570784924; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=i2cTxoQk6Bl+AJ7SSFPHaabtbHMYLfPWG8OISeNDrxI=; b=UuR6fWsl2Z3zBUQs2iWGJcPidilHFCEAtQcISevPhaOmJVCDmWrgP40vq7RW/aMvTm0vF3Swl0UD/CGYRMeJvv6AbjHoutJKs0ADtMI2/cG8rtPgUHbp8vBqRwCRrN8xphPz1KpdViyXnZArIFSzVzX8ZZhv9bMT1FMQTsJteVk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570784924587167.04919812179253; Fri, 11 Oct 2019 02:08:44 -0700 (PDT) Received: from localhost ([::1]:47586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIque-0007Nt-W5 for importer@patchew.org; Fri, 11 Oct 2019 05:08:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49390) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqtB-0005gV-Vg for qemu-devel@nongnu.org; Fri, 11 Oct 2019 05:07:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIqtA-000435-MQ for qemu-devel@nongnu.org; Fri, 11 Oct 2019 05:07:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42788) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIqt8-00041q-11; Fri, 11 Oct 2019 05:07:06 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0FE5A1017C11; Fri, 11 Oct 2019 09:07:05 +0000 (UTC) Received: from localhost (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4F665D6C8; Fri, 11 Oct 2019 09:07:04 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH] iotests/028: Fix for long $TEST_DIRs Date: Fri, 11 Oct 2019 11:07:02 +0200 Message-Id: <20191011090702.29721-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Fri, 11 Oct 2019 09:07:05 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Thomas Huth , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" For long test image paths, the order of the "Formatting" line and the "(qemu)" prompt after a drive_backup HMP command may be reversed. It is not well-defined anyway, so just silence everything and wait until we get a prompt. Reported-by: Thomas Huth Signed-off-by: Max Reitz --- tests/qemu-iotests/028 | 6 ++++-- tests/qemu-iotests/028.out | 1 - 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/028 b/tests/qemu-iotests/028 index 71301ec6e5..da3187719a 100755 --- a/tests/qemu-iotests/028 +++ b/tests/qemu-iotests/028 @@ -119,8 +119,10 @@ fi # Silence output since it contains the disk image path and QEMU's readline # character echoing makes it very hard to filter the output. Plus, there # is no telling how many times the command will repeat before succeeding. -_send_qemu_cmd $h "drive_backup disk ${TEST_IMG}.copy" "(qemu)" >/dev/null -_send_qemu_cmd $h "" "Formatting" | _filter_img_create +# Furthermore, the order of the "Formatting" line and the "(qemu)" prompt +# is undefined. +_send_qemu_cmd $h "drive_backup disk ${TEST_IMG}.copy" "Formatting" >/dev/= null +_send_qemu_cmd $h "" "(qemu)" >/dev/null qemu_cmd_repeat=3D20 _send_qemu_cmd $h "info block-jobs" "No active jobs" = >/dev/null _send_qemu_cmd $h "info block-jobs" "No active jobs" _send_qemu_cmd $h 'quit' "" diff --git a/tests/qemu-iotests/028.out b/tests/qemu-iotests/028.out index 7d54aeb003..37aed84436 100644 --- a/tests/qemu-iotests/028.out +++ b/tests/qemu-iotests/028.out @@ -468,7 +468,6 @@ No errors were found on the image. =20 block-backup =20 -Formatting 'TEST_DIR/t.IMGFMT.copy', fmt=3DIMGFMT size=3D4294968832 backin= g_file=3DTEST_DIR/t.IMGFMT.base backing_fmt=3DIMGFMT (qemu) info block-jobs No active jobs =3D=3D=3D IO: pattern 195 --=20 2.21.0