From nobody Sat May 4 06:10:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570784030; cv=none; d=zoho.com; s=zohoarc; b=X8mD7/HBLPL/N4doDnadcMPa+yCCz8l6MlWhq7+2Ivrl3ESkgWgJp/q8Fr97WBWLeRNXVwBXXEjOg3pFpaTEvf/z3rJNLiMourmWfTRXgOI4ONiWi6ngOR634SXxezf2QgikQy9Ioi5u6cNVFBkv1PHgy1vYbt3mPFDR7u6X3yY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570784030; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=92mGj1o4hz7dFjPkEgkP2rXDLBoS/ITNn/0a9XPG5QY=; b=XeHTCPzotc0k24vVdPi2C9F1vjMDWZyC32msZFxVdPVbj4GcazSr3mbXJ47UBvSgany5FbhOfMMNfAuXODcTSw4wIgZFtrh9xmIcqD3AtpV+tnVWfIptCTpH1YbFzfixSUfuk2Pm6o+7sCT55m41f2qj1ISzgMBntivtcvgR6IA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570784030549601.7627547955676; Fri, 11 Oct 2019 01:53:50 -0700 (PDT) Received: from localhost ([::1]:47384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqgH-0007sm-Fo for importer@patchew.org; Fri, 11 Oct 2019 04:53:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46790) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqdl-0004MW-3R for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIqdk-000655-1X for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:12 -0400 Received: from mga01.intel.com ([192.55.52.88]:57819) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIqdj-00064J-QV for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:11 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2019 01:51:11 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 11 Oct 2019 01:51:10 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,283,1566889200"; d="scan'208";a="224271724" From: Wei Yang To: quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 1/4] migration/multifd: fix a typo in comment of multifd_recv_unfill_packet() Date: Fri, 11 Oct 2019 16:50:47 +0800 Message-Id: <20191011085050.17622-2-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191011085050.17622-1-richardw.yang@linux.intel.com> References: <20191011085050.17622-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Wei Yang Reviewed-by: Juan Quintela --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 22423f08cd..cf30171f44 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -838,7 +838,7 @@ static int multifd_recv_unfill_packet(MultiFDRecvParams= *p, Error **errp) =20 packet->pages_alloc =3D be32_to_cpu(packet->pages_alloc); /* - * If we recevied a packet that is 100 times bigger than expected + * If we received a packet that is 100 times bigger than expected * just stop migration. It is a magic number. */ if (packet->pages_alloc > pages_max * 100) { --=20 2.17.1 From nobody Sat May 4 06:10:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570784391; cv=none; d=zoho.com; s=zohoarc; b=CCD3UR1oGQFAttDv8mVxRwjgE72Ci8xJJTNUe1H3gD74WmJ3U2tTiCXgntZVN88s7KT888S6XwGBK5caE4VZRR/BHO1HHVYxw7go6He61LxQuznjMBiUjRV6M1xtG0h69aO8sasQII3tJDtpjm0hPWQN+MDgrYY0RjZwHaA8t4w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570784391; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=jPDURaCA7mGXN3HoMugiOJFo+ts5IBBj9AGCYuU+v/4=; b=n6HFNgpgjrRaTlBvFqy0LsL3GKn9bXyzbupAsXF9Lc7/Q3llNvii0Mn1XM3Ey//WHDx1ETjKCWDNaC6aeczcVZEk0LdmbWoqfVtfHOvH8BarHxLchbU8IdPeDY5smbhS2mQFEz/FWXMebB3+vg4kLuVYT5g2BFlDEAJbLKnJ0RE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157078439144175.26290406161411; Fri, 11 Oct 2019 01:59:51 -0700 (PDT) Received: from localhost ([::1]:47464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqm6-0007Ca-Di for importer@patchew.org; Fri, 11 Oct 2019 04:59:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46806) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqdm-0004Pn-W6 for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIqdl-00066F-U5 for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:14 -0400 Received: from mga01.intel.com ([192.55.52.88]:57822) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIqdl-00065Q-MC for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:13 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2019 01:51:12 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 11 Oct 2019 01:51:11 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,283,1566889200"; d="scan'208";a="224271741" From: Wei Yang To: quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 2/4] migration/multifd: use pages->allocated instead of the static max Date: Fri, 11 Oct 2019 16:50:48 +0800 Message-Id: <20191011085050.17622-3-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191011085050.17622-1-richardw.yang@linux.intel.com> References: <20191011085050.17622-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" multifd_send_fill_packet() prepares meta data for following pages to transfer. It would be more proper to fill pages->allocated instead of static max value, especially we want to support flexible packet size. Signed-off-by: Wei Yang Reviewed-by: Juan Quintela --- migration/ram.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index cf30171f44..6a3bef0434 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -791,13 +791,12 @@ static void multifd_pages_clear(MultiFDPages_t *pages) static void multifd_send_fill_packet(MultiFDSendParams *p) { MultiFDPacket_t *packet =3D p->packet; - uint32_t page_max =3D MULTIFD_PACKET_SIZE / qemu_target_page_size(); int i; =20 packet->magic =3D cpu_to_be32(MULTIFD_MAGIC); packet->version =3D cpu_to_be32(MULTIFD_VERSION); packet->flags =3D cpu_to_be32(p->flags); - packet->pages_alloc =3D cpu_to_be32(page_max); + packet->pages_alloc =3D cpu_to_be32(p->pages->allocated); packet->pages_used =3D cpu_to_be32(p->pages->used); packet->next_packet_size =3D cpu_to_be32(p->next_packet_size); packet->packet_num =3D cpu_to_be64(p->packet_num); --=20 2.17.1 From nobody Sat May 4 06:10:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570783972; cv=none; d=zoho.com; s=zohoarc; b=T1COctrf3nzLh0N6KyWmRCvOJrOjVe2eq5Ibk4OcBOYT++kUf2lePRZGjVWGwRicrTDGY3ZHSckge+VmXk7lhy3IibJHoBu7WR17dfN1OIG0LsasZB9a6oMZtVZBAWcv8JPIH+TJO3QbptZLaADfWKpDD4c7wp96FgNfrH/DAhU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570783972; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=7alQoq8e7pSTeC2jev2otex7NNn/SvGXSRxmVin3B1k=; b=Is/Ch56cb/064UlVg6hrscgyBf/WmZLgvSsS5/3UdRjzorB9HllLurWcu60YYi+corseBmypKt1RqzVaTV3FEDbQm13MLwFgSCM093B5C70oDDaQjlzuAKO2SZYqp4IFHs+qqXQ0CfvClNtFFZl4NKUwcwS+zI0uQoffz1I+QiY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570783972005165.536563598636; Fri, 11 Oct 2019 01:52:52 -0700 (PDT) Received: from localhost ([::1]:47366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqfK-0006DQ-M4 for importer@patchew.org; Fri, 11 Oct 2019 04:52:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46819) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqdo-0004RP-2z for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIqdm-00066f-W8 for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:15 -0400 Received: from mga01.intel.com ([192.55.52.88]:57822) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIqdm-00065Q-OQ for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:14 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2019 01:51:14 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 11 Oct 2019 01:51:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,283,1566889200"; d="scan'208";a="224271747" From: Wei Yang To: quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 3/4] migration/multifd: initialize packet->magic/version once at setup stage Date: Fri, 11 Oct 2019 16:50:49 +0800 Message-Id: <20191011085050.17622-4-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191011085050.17622-1-richardw.yang@linux.intel.com> References: <20191011085050.17622-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" MultiFDPacket_t's magic and version field never changes during migration, so move these two fields in setup stage. Signed-off-by: Wei Yang Reviewed-by: Juan Quintela --- migration/ram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 6a3bef0434..71d845b851 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -793,8 +793,6 @@ static void multifd_send_fill_packet(MultiFDSendParams = *p) MultiFDPacket_t *packet =3D p->packet; int i; =20 - packet->magic =3D cpu_to_be32(MULTIFD_MAGIC); - packet->version =3D cpu_to_be32(MULTIFD_VERSION); packet->flags =3D cpu_to_be32(p->flags); packet->pages_alloc =3D cpu_to_be32(p->pages->allocated); packet->pages_used =3D cpu_to_be32(p->pages->used); @@ -1240,6 +1238,8 @@ int multifd_save_setup(void) p->packet_len =3D sizeof(MultiFDPacket_t) + sizeof(ram_addr_t) * page_count; p->packet =3D g_malloc0(p->packet_len); + p->packet->magic =3D cpu_to_be32(MULTIFD_MAGIC); + p->packet->version =3D cpu_to_be32(MULTIFD_VERSION); p->name =3D g_strdup_printf("multifdsend_%d", i); socket_send_channel_create(multifd_new_send_channel_async, p); } --=20 2.17.1 From nobody Sat May 4 06:10:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570784189; cv=none; d=zoho.com; s=zohoarc; b=VmQevg/Y4kHsN942mwoc8c0UFRgMgDuXwOgS0SjVEzuFfjeZPOZ7aNDXIz5rEuS6S8cVHFF4qI0UMzg5v/vn/eOl2zw7KMyLiyIz89NOasC24rMwxxGgb+FUnm7QzaFPdtbIqcjAO/aUnbzn7h5BMy5GM5wflCE4kNKFq7HZAK8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570784189; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=ywVXDaHEaAdAsbi0OrdEui6OTK5x0Q4L2IBNicDoIXw=; b=ZBxIa0enBqgGZgL7y/jjEb10mywxK1Dx7GArLyxkXfbDtKGhtsxMuW/xRqLMruLZkLb5EPCKusQn/5wv4G61Tma5dOS0NQjGcSC8lQvOrzbOTab8Pb51ZQdU5+YWWhNkI4NreyO7YCFemwxexpyrNSECxB8bp8kZgGpygPjCQdk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570784189083672.5621746815879; Fri, 11 Oct 2019 01:56:29 -0700 (PDT) Received: from localhost ([::1]:47406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqip-00023F-Es for importer@patchew.org; Fri, 11 Oct 2019 04:56:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46833) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIqdq-0004U9-Oa for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIqdo-00067E-Or for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:18 -0400 Received: from mga01.intel.com ([192.55.52.88]:57822) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIqdo-00065Q-Gp for qemu-devel@nongnu.org; Fri, 11 Oct 2019 04:51:16 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2019 01:51:16 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 11 Oct 2019 01:51:15 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,283,1566889200"; d="scan'208";a="224271754" From: Wei Yang To: quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 4/4] migration/multifd: pages->used would be cleared when attach to multifd_send_state Date: Fri, 11 Oct 2019 16:50:50 +0800 Message-Id: <20191011085050.17622-5-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191011085050.17622-1-richardw.yang@linux.intel.com> References: <20191011085050.17622-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.88 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When we found an available channel in multifd_send_pages(), its pages->used is cleared and then attached to multifd_send_state. It is not necessary to do this twice. Signed-off-by: Wei Yang Reviewed-by: Juan Quintela --- migration/ram.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 71d845b851..051de77d5a 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1129,7 +1129,6 @@ static void *multifd_send_thread(void *opaque) p->flags =3D 0; p->num_packets++; p->num_pages +=3D used; - p->pages->used =3D 0; qemu_mutex_unlock(&p->mutex); =20 trace_multifd_send(p->id, packet_num, used, flags, --=20 2.17.1