From nobody Mon May 6 00:47:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1570777462; cv=none; d=zoho.com; s=zohoarc; b=hBAm//4J3hQ+ny4IjcH6uGZy8U5o5Vxq6RQnuSWovizqOTO3gornh+O/zXnboN4DNG2VyIgYyy4wCHmzRitXSux1RwH+wwlI0a3d7Y0EFcFKv6kwwrs3iM4qzJv3+Ybc2NnxBROrx8VL/pJP7V8eLyY/M4t9+Ho7JHbitfvWM+4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570777462; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vZI+SS/PperxHZKe5fbBmi5IVqJYrhx/+h1XAg9An3E=; b=mDP/jsnVnlQiyHHLrd1vTQiLNxqJUHkA4Jp2K+IBBP+VdAln1y/UYDpOCLI7fXa1HsQ4RFPu2xLPagD68ZotJ262nA8oAhrMlebrXueKoEFVdnRymAU3dS3SoKED3F96avcRE+Z3QzrHGIp9cYAP0XBQALXkqqLDy/Bslztm1tw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570777461615651.3640153471945; Fri, 11 Oct 2019 00:04:21 -0700 (PDT) Received: from localhost ([::1]:46370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIoyJ-0008E7-Vd for importer@patchew.org; Fri, 11 Oct 2019 03:04:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58057) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIow6-0007CE-9T for qemu-devel@nongnu.org; Fri, 11 Oct 2019 03:02:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIow4-0007lR-Qe for qemu-devel@nongnu.org; Fri, 11 Oct 2019 03:02:01 -0400 Received: from charlie.dont.surf ([128.199.63.193]:46528) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIow4-0007hd-KT for qemu-devel@nongnu.org; Fri, 11 Oct 2019 03:02:00 -0400 Received: from apples.localdomain (unknown [194.62.217.57]) by charlie.dont.surf (Postfix) with ESMTPSA id DD0C6BF73F; Fri, 11 Oct 2019 07:01:57 +0000 (UTC) From: Klaus Jensen To: qemu-devel@nongnu.org Subject: [PATCH 1/1] pci: pass along the return value of dma_memory_rw Date: Fri, 11 Oct 2019 09:01:41 +0200 Message-Id: <20191011070141.188713-2-its@irrelevant.dk> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191011070141.188713-1-its@irrelevant.dk> References: <20191011070141.188713-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 128.199.63.193 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Some might actually care about the return value of dma_memory_rw. So let us pass it along instead of ignoring it. Signed-off-by: Klaus Jensen Reviewed-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/pci/pci.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index f3f0ffd5fb78..4e95bb847857 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -779,8 +779,7 @@ static inline AddressSpace *pci_get_address_space(PCIDe= vice *dev) static inline int pci_dma_rw(PCIDevice *dev, dma_addr_t addr, void *buf, dma_addr_t len, DMADirection dir) { - dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir); - return 0; + return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, dir); } =20 static inline int pci_dma_read(PCIDevice *dev, dma_addr_t addr, --=20 2.23.0