From nobody Fri Dec 19 04:26:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570710001; cv=none; d=zoho.com; s=zohoarc; b=Dfba/Ar8m1znsgKL0zFxAjQ9E8nFx2dsABEpBYvrrKu7/eeQfSfkm4KKbwoGrGzhdmYvOw+nUboZ/LIypFItFUjLSVt1xBkuljgAMt5U4iv8ThFVulB1hLdH/1IUQF3VZHsRHYFBb0zJNc8HgULn6B+9ksjCMZqpLVKi/pTuHvk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570710001; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=E+bACUCH67U1Z8Gie9MUlJFIjmYKPq5Z2mQOmL2Hln8=; b=jxE7UFgnpVyi203XXOOIjGetzhKE6WR3znIQs248954qxkhi0XLIqE05mGxS4Z0+/S2stnDL7YOvxOjLzROV9x17AVOozUnkHVtOiDuD8+XaUIjSfShoxDXKax3+Nyigg6MRT6LUzBKIuJ2dDQ04uvfQ5UrmKmy05JqL0svYiyo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157071000115393.71809715821507; Thu, 10 Oct 2019 05:20:01 -0700 (PDT) Received: from localhost ([::1]:37058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIXQA-00055R-RQ for importer@patchew.org; Thu, 10 Oct 2019 08:19:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52410) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIWru-0007Sz-RP for qemu-devel@nongnu.org; Thu, 10 Oct 2019 07:44:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIWrs-00006k-PS for qemu-devel@nongnu.org; Thu, 10 Oct 2019 07:44:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56056) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIWro-0008UM-LV; Thu, 10 Oct 2019 07:44:24 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2909B87638; Thu, 10 Oct 2019 11:44:22 +0000 (UTC) Received: from localhost (unknown [10.36.118.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C26FE5C553; Thu, 10 Oct 2019 11:44:21 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Subject: [PULL 36/36] iotests/162: Fix for newer Linux 5.3+ Date: Thu, 10 Oct 2019 13:43:00 +0200 Message-Id: <20191010114300.7746-37-mreitz@redhat.com> In-Reply-To: <20191010114300.7746-1-mreitz@redhat.com> References: <20191010114300.7746-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 10 Oct 2019 11:44:22 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Linux 5.3 has made 0.0.0.0/8 a working IPv4 subnet. As such, "42" is now a valid host, and the connection to it will (hopefully) time out over a long period rather than quickly return with EINVAL. So let us use a negative integer for testing that NBD will not crash when it receives integer hosts. This way, the connection will again fail quickly and reliably. Signed-off-by: Max Reitz Message-id: 20191002174052.5773-1-mreitz@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- tests/qemu-iotests/162 | 2 +- tests/qemu-iotests/162.out | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/162 b/tests/qemu-iotests/162 index 2d719afbed..c0053ed975 100755 --- a/tests/qemu-iotests/162 +++ b/tests/qemu-iotests/162 @@ -46,7 +46,7 @@ echo '=3D=3D=3D NBD =3D=3D=3D' # NBD expects all of its arguments to be strings =20 # So this should not crash -$QEMU_IMG info 'json:{"driver": "nbd", "host": 42}' +$QEMU_IMG info 'json:{"driver": "nbd", "host": -1}' =20 # And this should not treat @port as if it had not been specified # (We need to set up a server here, because the error message for "Connect= ion diff --git a/tests/qemu-iotests/162.out b/tests/qemu-iotests/162.out index 3c5be2c569..5a00d36d17 100644 --- a/tests/qemu-iotests/162.out +++ b/tests/qemu-iotests/162.out @@ -1,7 +1,7 @@ QA output created by 162 =20 =3D=3D=3D NBD =3D=3D=3D -qemu-img: Could not open 'json:{"driver": "nbd", "host": 42}': Failed to c= onnect socket: Invalid argument +qemu-img: Could not open 'json:{"driver": "nbd", "host": -1}': address res= olution failed for -1:10809: Name or service not known image: nbd://localhost:PORT image: nbd+unix://?socket=3D42 =20 --=20 2.21.0