From nobody Tue Apr 15 21:45:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570709087; cv=none; d=zoho.com; s=zohoarc; b=KgL1MRlxOHb36CXQ3C7bSF/TBAGVfKqKCYsfBtksYYl+KVXhCkdb6EYgoBQl8GfteBd4+dp3LKXTmEcFReu01x6wU1jKafkmcPrA70Zjjtiwp80hvqqgXRwGi0RYvQStZCYFXdwoGqjUbp4+IFLf40L4s7/KR8X99RxGXFFyj7E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570709087; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oQ37pUlwvi4u2aE/sMe40YAUauMsrhh3sMP3aU8vCDQ=; b=bGKO+vkLCjn5h16OcTP7FAXZllKJMDLs5ctlhnF83Ls6sO8VRz1q1XCNLKklvff2NWop1j3AXtRaKqxNuNLRrxpxjQx1baFs0mFv3e7TK7ulWvuxKzajXMzf4e4e63+sPRL+ynSTPlgMByk2OhOS1qiVJ5NKgBJYLYImAn9Z07M= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570709087727337.3833279061005; Thu, 10 Oct 2019 05:04:47 -0700 (PDT) Received: from localhost ([::1]:36878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIXBU-0003lw-3e for importer@patchew.org; Thu, 10 Oct 2019 08:04:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51793) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIWr0-0006aP-I9 for qemu-devel@nongnu.org; Thu, 10 Oct 2019 07:43:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIWqx-0008BI-Pe for qemu-devel@nongnu.org; Thu, 10 Oct 2019 07:43:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55910) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIWqt-0008AB-Kt; Thu, 10 Oct 2019 07:43:27 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DDEAB883C2; Thu, 10 Oct 2019 11:43:26 +0000 (UTC) Received: from localhost (unknown [10.36.118.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 838375C231; Thu, 10 Oct 2019 11:43:26 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Subject: [PULL 11/36] block/backup: fix block-comment style Date: Thu, 10 Oct 2019 13:42:35 +0200 Message-Id: <20191010114300.7746-12-mreitz@redhat.com> In-Reply-To: <20191010114300.7746-1-mreitz@redhat.com> References: <20191010114300.7746-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 10 Oct 2019 11:43:26 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Vladimir Sementsov-Ogievskiy We need to fix comment style around block-copy functions before further moving them to separate file to satisfy checkpatch. But do more: fix all comments style. Also, seems like doubled first asterisk is not forbidden, but drop it too for consistency. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-id: 20190920142056.12778-7-vsementsov@virtuozzo.com Signed-off-by: Max Reitz --- block/backup.c | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/block/backup.c b/block/backup.c index 5dda1673ca..f5125984db 100644 --- a/block/backup.c +++ b/block/backup.c @@ -223,8 +223,10 @@ fail: return NULL; } =20 -/* Copy range to target with a bounce buffer and return the bytes copied. = If - * error occurred, return a negative error number */ +/* + * Copy range to target with a bounce buffer and return the bytes copied. = If + * error occurred, return a negative error number + */ static int coroutine_fn block_copy_with_bounce_buffer(BlockCopyState *s, int64_t start, int64_t end, @@ -269,8 +271,10 @@ fail: =20 } =20 -/* Copy range to target and return the bytes copied. If error occurred, re= turn a - * negative error number. */ +/* + * Copy range to target and return the bytes copied. If error occurred, re= turn a + * negative error number. + */ static int coroutine_fn block_copy_with_offload(BlockCopyState *s, int64_t start, int64_t end, @@ -341,7 +345,7 @@ static int block_copy_is_cluster_allocated(BlockCopySta= te *s, int64_t offset, } } =20 -/** +/* * Reset bits in copy_bitmap starting at offset if they represent unalloca= ted * data in the image. May reset subsequent contiguous bits. * @return 0 when the cluster at @offset was unallocated, @@ -592,8 +596,10 @@ static bool coroutine_fn yield_and_check(BackupBlockJo= b *job) return true; } =20 - /* We need to yield even for delay_ns =3D 0 so that bdrv_drain_all() c= an - * return. Without a yield, the VM would not reboot. */ + /* + * We need to yield even for delay_ns =3D 0 so that bdrv_drain_all() c= an + * return. Without a yield, the VM would not reboot. + */ delay_ns =3D block_job_ratelimit_get_delay(&job->common, job->bytes_re= ad); job->bytes_read =3D 0; job_sleep_ns(&job->common.job, delay_ns); @@ -692,11 +698,15 @@ static int coroutine_fn backup_run(Job *job, Error **= errp) } =20 if (s->sync_mode =3D=3D MIRROR_SYNC_MODE_NONE) { - /* All bits are set in copy_bitmap to allow any cluster to be copi= ed. - * This does not actually require them to be copied. */ + /* + * All bits are set in copy_bitmap to allow any cluster to be copi= ed. + * This does not actually require them to be copied. + */ while (!job_is_cancelled(job)) { - /* Yield until the job is cancelled. We just let our before_w= rite - * notify callback service CoW requests. */ + /* + * Yield until the job is cancelled. We just let our before_w= rite + * notify callback service CoW requests. + */ job_yield(job); } } else { --=20 2.21.0