From nobody Tue Feb 10 04:53:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1570556331; cv=none; d=zoho.com; s=zohoarc; b=FxzP1zXmDmQ3ndvJ0T0uOjB0YsM01McFXGkkJ7EBdLIkHjIGOMu8mTEUyoQM9HifXeUU2knDBiv/8YkWcN9XBeAqmlwt2bp2B06N4CMsjsCA5BFp4gEBaPmx7fB859/NVx0Z3sJLbqLXG1z2YAMZ81tY3By46g7VEv8UEvTf95Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570556331; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PYOd0vFS/gYS2A8DyTJAHBtn1FfEmdBSCZ1qScpfiwA=; b=GmlhmWEPVY+1aw4Fbg2uc3WL4bfQSpKWsAgpdIzeQLiGUq/dL5uuGoHh+solC5QK5188OFpJlBzOvL/ZQhecLa0uRuEsHpoO6BDUth1cdY7UJnNs7+pjWdcuntIpkjv7Ji8YTFe2e5FzI8uH+d4EXFDq/P3iAtM/ftJpJqLzYSE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570556331915389.674691111666; Tue, 8 Oct 2019 10:38:51 -0700 (PDT) Received: from localhost ([::1]:59310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHtRi-0000Ek-0u for importer@patchew.org; Tue, 08 Oct 2019 13:38:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49065) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHt7e-0006oP-IW for qemu-devel@nongnu.org; Tue, 08 Oct 2019 13:18:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHt7d-0002Oi-1s for qemu-devel@nongnu.org; Tue, 08 Oct 2019 13:18:06 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:36850) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iHt7c-0002N1-OF for qemu-devel@nongnu.org; Tue, 08 Oct 2019 13:18:04 -0400 Received: by mail-wr1-x443.google.com with SMTP id y19so20349777wrd.3 for ; Tue, 08 Oct 2019 10:18:03 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id z9sm19135541wrl.35.2019.10.08.10.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 10:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PYOd0vFS/gYS2A8DyTJAHBtn1FfEmdBSCZ1qScpfiwA=; b=Sw+8Rwp+JVvkoGA81kds513BxAOtOGzaAYuqHSmvsuztgpfgmpNCOn0rsBjvQel+Ha QfDWKdx6SgqNzO2TRtPGXIdSAp3RmtGda+Q9zK5Nny6b6YzE2ELsQ2WZyVEh92yz6Qso whK8ZlzCIhKJX9I+mrynZ9/0eoMcm3zFcNq4hYmxXTbYCa5GMSVZlbj8hl7ZeLtQC+Nl WybL2bsTPMCrYVDoz8buGXfd1qgo3Aw8nJTDha5T7hJVlquEC/JyOpwGBOB1Kq4mMDZf q9Bhc7Ad9v85DCyZqjtokVwZZF2EQqcv0D91GLjkzcsT9BlGZb7gblDTSkVcxpznQKrj QVTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PYOd0vFS/gYS2A8DyTJAHBtn1FfEmdBSCZ1qScpfiwA=; b=BcYzr5XhxkYzTAlv/be9ozcUN1XcxzwzPXfCPiOT71pRSoMK/N5Hi5/SJfA7pnnnC/ 3BESZSc6VsoS4C4peIo3EI5UWu1rYUyZlaR9Yjr8hwDEdg4vRNAgxSYYdySis2aRtL4+ ByhQXy1vjDWv/DfvGwGNAyXksKmKwVFLpJBT51crp2+4MLwpF0fOcmicoOq5VXEsNyTa mK1Omn8cOCfwz8vPW7gjSN0Nz8yeL1XjvWHepmMsICykEH0gO/n/kJf/GGCsNtsRpkRN zvgirO6vac6zmEw1bXyNW+zE9QvttPxw4mhWfOOJyl4yCrxUivKnSGgFMJaXF8VVeKpQ RimQ== X-Gm-Message-State: APjAAAWnJEoKjKJzbfeJ0Itz1AjobWn7wYcri+WSK+/3tBrNhU43kIRb oeG4kerYe+Hq6qZPqbq9cIdLFg== X-Google-Smtp-Source: APXvYqwW/OSAYdKmjJ9sWUoSRGtcCnrSipKaUhWEPl66SaEj0TS/25mfQVgMDb9+TqB41naucRKldQ== X-Received: by 2002:a5d:4a84:: with SMTP id o4mr3844941wrq.165.1570555082655; Tue, 08 Oct 2019 10:18:02 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 15/21] hw/timer/exynos4210_rtc.c: Switch 1Hz ptimer to transaction-based API Date: Tue, 8 Oct 2019 18:17:34 +0100 Message-Id: <20191008171740.9679-16-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191008171740.9679-1-peter.maydell@linaro.org> References: <20191008171740.9679-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Switch the exynos41210_rtc 1Hz ptimer over to the transaction-based API. (We will switch the other ptimer used by this device in a separate commit.) Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- hw/timer/exynos4210_rtc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/timer/exynos4210_rtc.c b/hw/timer/exynos4210_rtc.c index d5d7c91fb15..b7ae99e9aa7 100644 --- a/hw/timer/exynos4210_rtc.c +++ b/hw/timer/exynos4210_rtc.c @@ -401,6 +401,7 @@ static void exynos4210_rtc_write(void *opaque, hwaddr o= ffset, } break; case RTCCON: + ptimer_transaction_begin(s->ptimer_1Hz); if (value & RTC_ENABLE) { exynos4210_rtc_update_freq(s, value); } @@ -430,6 +431,7 @@ static void exynos4210_rtc_write(void *opaque, hwaddr o= ffset, ptimer_stop(s->ptimer); } } + ptimer_transaction_commit(s->ptimer_1Hz); s->reg_rtccon =3D value; break; case TICCNT: @@ -539,7 +541,9 @@ static void exynos4210_rtc_reset(DeviceState *d) =20 exynos4210_rtc_update_freq(s, s->reg_rtccon); ptimer_stop(s->ptimer); + ptimer_transaction_begin(s->ptimer_1Hz); ptimer_stop(s->ptimer_1Hz); + ptimer_transaction_commit(s->ptimer_1Hz); } =20 static const MemoryRegionOps exynos4210_rtc_ops =3D { @@ -562,9 +566,11 @@ static void exynos4210_rtc_init(Object *obj) ptimer_set_freq(s->ptimer, RTC_BASE_FREQ); exynos4210_rtc_update_freq(s, 0); =20 - bh =3D qemu_bh_new(exynos4210_rtc_1Hz_tick, s); - s->ptimer_1Hz =3D ptimer_init_with_bh(bh, PTIMER_POLICY_DEFAULT); + s->ptimer_1Hz =3D ptimer_init(exynos4210_rtc_1Hz_tick, + s, PTIMER_POLICY_DEFAULT); + ptimer_transaction_begin(s->ptimer_1Hz); ptimer_set_freq(s->ptimer_1Hz, RTC_BASE_FREQ); + ptimer_transaction_commit(s->ptimer_1Hz); =20 sysbus_init_irq(dev, &s->alm_irq); sysbus_init_irq(dev, &s->tick_irq); --=20 2.20.1