On 09/10/19 21:26, Michael S. Tsirkin wrote:
> On Tue, Oct 08, 2019 at 03:55:26PM +0200, Sergio Lopez wrote:
>> Microvm is a machine type inspired by Firecracker and constructed
>> after the its machine model.
>>
>> It's a minimalist machine type without PCI nor ACPI support, designed
>> for short-lived guests. Microvm also establishes a baseline for
>> benchmarking and optimizing both QEMU and guest operating systems,
>> since it is optimized for both boot time and footprint.
>
> Looks good overall. I think coding style needs to
> be fixed but that's a patch on top.
>
> series:
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Paolo I assume you will be merging this?
Yes, but if Sergio could send me a pull request it would be nice too.
Paolo
>
>
>> ---
>>
>> Changelog
>> v7:
>> - Fix code style issues on already present code touched by this patch
>> series (Michael S. Tsirkin, Philippe Mathieu-Daudé)
>> - Add new files to MAINTAINERS (Michael S. Tsirkin, Philippe
>> Mathieu-Daudé)
>> - Allow starting a microvm machine without a kernel image, fixing
>> "qom-test" (Michael S. Tsirkin)
>> - Change "bios-microvm.bin" mode to 0644 (Stefano Garzarella)
>> - Remove unneeded "hw/i386/pc.h" include from x86.c (Stefano
>> Garzarella)
>>
>> v6:
>> - Some style fixes (Philippe Mathieu-Daudé)
>> - Fix a documentation bug stating that LAPIC was in userspace (Paolo
>> Bonzini)
>> - Update Xen HVM code after X86MachineState introduction (Philippe
>> Mathieu-Daudé)
>> - Rename header guard from QEMU_VIRTIO_MMIO_H to HW_VIRTIO_MMIO_H
>> (Philippe Mathieu-Daudé)
>>
>> v5:
>> - Drop unneeded "[PATCH v4 2/8] hw/i386: Factorize e820 related
>> functions" (Philippe Mathieu-Daudé)
>> - Drop unneeded "[PATCH v4 1/8] hw/i386: Factorize PVH related
>> functions" (Stefano Garzarella)
>> - Split X86MachineState introduction into smaller patches (Philippe
>> Mathieu-Daudé)
>> - Change option-roms to x-option-roms and kernel-cmdline to
>> auto-kernel-cmdline (Paolo Bonzini)
>> - Make i8259 PIT and i8254 PIC optional (Paolo Bonzini)
>> - Some fixes to the documentation (Paolo Bonzini)
>> - Switch documentation format from txt to rst (Peter Maydell)
>> - Move NMI interface to X86_MACHINE (Philippe Mathieu-Daudé, Paolo
>> Bonzini)
>>
>> v4:
>> - This is a complete rewrite of the whole patchset, with a focus on
>> reusing as much existing code as possible to ease the maintenance burden
>> and making the machine type as compatible as possible by default. As
>> a result, the number of lines dedicated specifically to microvm is
>> 383 (code lines measured by "cloc") and, with the default
>> configuration, it's now able to boot both PVH ELF images and
>> bzImages with either SeaBIOS or qboot.
>>
>> v3:
>> - Add initrd support (thanks Stefano).
>>
>> v2:
>> - Drop "[PATCH 1/4] hw/i386: Factorize CPU routine".
>> - Simplify machine definition (thanks Eduardo).
>> - Remove use of unneeded NUMA-related callbacks (thanks Eduardo).
>> - Add a patch to factorize PVH-related functions.
>> - Replace use of Linux's Zero Page with PVH (thanks Maran and Paolo).
>>
>> ---
>>
>> Sergio Lopez (12):
>> hw/virtio: Factorize virtio-mmio headers
>> hw/i386/pc: rename functions shared with non-PC machines
>> hw/i386/pc: fix code style issues on functions that will be moved out
>> hw/i386/pc: move shared x86 functions to x86.c and export them
>> hw/i386: split PCMachineState deriving X86MachineState from it
>> hw/i386: make x86.c independent from PCMachineState
>> fw_cfg: add "modify" functions for all types
>> hw/intc/apic: reject pic ints if isa_pic == NULL
>> roms: add microvm-bios (qboot) as binary and git submodule
>> docs/microvm.rst: document the new microvm machine type
>> hw/i386: Introduce the microvm machine type
>> MAINTAINERS: add microvm related files
>>
>> docs/microvm.rst | 98 ++++
>> default-configs/i386-softmmu.mak | 1 +
>> include/hw/i386/microvm.h | 83 ++++
>> include/hw/i386/pc.h | 28 +-
>> include/hw/i386/x86.h | 96 ++++
>> include/hw/nvram/fw_cfg.h | 42 ++
>> include/hw/virtio/virtio-mmio.h | 73 +++
>> hw/acpi/cpu_hotplug.c | 10 +-
>> hw/i386/acpi-build.c | 29 +-
>> hw/i386/amd_iommu.c | 3 +-
>> hw/i386/intel_iommu.c | 3 +-
>> hw/i386/microvm.c | 572 ++++++++++++++++++++++
>> hw/i386/pc.c | 781 +++---------------------------
>> hw/i386/pc_piix.c | 46 +-
>> hw/i386/pc_q35.c | 38 +-
>> hw/i386/pc_sysfw.c | 60 +--
>> hw/i386/x86.c | 795 +++++++++++++++++++++++++++++++
>> hw/i386/xen/xen-hvm.c | 28 +-
>> hw/intc/apic.c | 2 +-
>> hw/intc/ioapic.c | 2 +-
>> hw/nvram/fw_cfg.c | 29 ++
>> hw/virtio/virtio-mmio.c | 48 +-
>> .gitmodules | 3 +
>> MAINTAINERS | 10 +
>> hw/i386/Kconfig | 4 +
>> hw/i386/Makefile.objs | 2 +
>> pc-bios/bios-microvm.bin | Bin 0 -> 65536 bytes
>> roms/Makefile | 6 +
>> roms/qboot | 1 +
>> 29 files changed, 1982 insertions(+), 911 deletions(-)
>> create mode 100644 docs/microvm.rst
>> create mode 100644 include/hw/i386/microvm.h
>> create mode 100644 include/hw/i386/x86.h
>> create mode 100644 include/hw/virtio/virtio-mmio.h
>> create mode 100644 hw/i386/microvm.c
>> create mode 100644 hw/i386/x86.c
>> create mode 100644 pc-bios/bios-microvm.bin
>> create mode 160000 roms/qboot
>>
>> --
>> 2.21.0