From nobody Mon Feb 9 04:29:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570534807; cv=none; d=zoho.com; s=zohoarc; b=cJ5KrqiTETGdlN/qrumvWKYUDwmyFhOTQrVjy7WwiA/odCSfRvDPqP2kHWb9kM/jKuvuGmClbm1GqVyzhILUD3BsqLZ/Bq11R5pEdn/M3JmzjNaM3PTUPpFMZq5WnwQjiC1v4gUBkLOGr2zVu2IO+tcT4kdv2FxL+5bLkd3F7wQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570534807; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=wer8+8e+PONgI9/2CSpyI2AA7g5fi1IPy09s6r5k+Tw=; b=Tbn5hrrotObJG+KbzP/ORWlxrYjj01w6sfVEwIj8Dlz9HjIJf9go4I3k6HwvHVJ0Gp8s2yyBCdOAWHjlUaE+xe+36FUAeCFiOmbvlQZzTBCqVTWCzrx0RZ+2ny9RQE/kPnuxVhMSbNgjRy5EdQmCE9O4R+zLLYZe7Zop2WozGm4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570534807422408.9063470859005; Tue, 8 Oct 2019 04:40:07 -0700 (PDT) Received: from localhost ([::1]:54024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHnqY-0008ES-CD for importer@patchew.org; Tue, 08 Oct 2019 07:40:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51645) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHnkD-0001uX-98 for qemu-devel@nongnu.org; Tue, 08 Oct 2019 07:33:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHnkC-0001VQ-8V for qemu-devel@nongnu.org; Tue, 08 Oct 2019 07:33:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58842) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHnkC-0001V4-30; Tue, 08 Oct 2019 07:33:32 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 38F873066EAC; Tue, 8 Oct 2019 11:33:31 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 955BB60BE0; Tue, 8 Oct 2019 11:33:29 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH 3/3] hppa: drop usage of memory_region_allocate_system_memory() for ROM Date: Tue, 8 Oct 2019 07:33:18 -0400 Message-Id: <20191008113318.7012-4-imammedo@redhat.com> In-Reply-To: <20191008113318.7012-1-imammedo@redhat.com> References: <20191008113318.7012-1-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 08 Oct 2019 11:33:31 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: deller@gmx.de, mark.cave-ayland@ilande.co.uk, hpoussin@reactos.org, qemu-ppc@nongnu.org, rth@twiddle.net, atar4qemu@gmail.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" machine_hppa_init() violates memory_region_allocate_system_memory() contract by calling it multiple times which could break with -mem-path. Replace the second usage (for 'rom') with memory_region_init_ram() instead. Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- hw/hppa/machine.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 7e23675429..953d454f48 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -161,9 +161,8 @@ static void machine_hppa_init(MachineState *machine) g_free(firmware_filename); =20 rom_region =3D g_new(MemoryRegion, 1); - memory_region_allocate_system_memory(rom_region, OBJECT(machine), - "firmware", - (FIRMWARE_END - FIRMWARE_START)); + memory_region_init_ram(rom_region, NULL, "firmware", + (FIRMWARE_END - FIRMWARE_START), &error_fatal); memory_region_add_subregion(addr_space, FIRMWARE_START, rom_region); =20 /* Load kernel */ --=20 2.18.1