From nobody Wed Nov 12 11:53:14 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570320436; cv=none; d=zoho.com; s=zohoarc; b=XRKrq8IHqW/UuvOT24Z0MTlgvReP5m+nJ3FReysWn1caSI45jWwgoedUGZrM2RjEXZbYIWeDAc57oq7OGhwAwfIucCxSwQG3/GnrV5SWCXAMTrvWw2JKQ+a4YGeLMy6HWvqawRyd+9WTYtKzvZV9K3gTDBdW5uRNN1XqQC24Qp8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570320436; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=WpWayQtGWj3wvtInVExNfV2owSxC2pGbUDRceUHAS50=; b=fRmPub7ibMoD0vRm48JW9RkIxNGsK5Zd1aXOViZrvV47LIT9cFG7dX2Fj6TtpIcgeWkSQTbGfhzkHwcKsCD283DXQWiaWWd9bO80q1T/Oy69bSGAZv7HxZJ2uMXH1qEUmkeFoOrd4eSpac3Jh7/3l2u3kuZXaM4X0q9RsBCtsMI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157032043640647.680585549599414; Sat, 5 Oct 2019 17:07:16 -0700 (PDT) Received: from localhost ([::1]:59452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGu4x-0001St-Cx for importer@patchew.org; Sat, 05 Oct 2019 20:07:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57795) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGu1B-0006Hc-C1 for qemu-devel@nongnu.org; Sat, 05 Oct 2019 20:03:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGu1A-0001km-CV for qemu-devel@nongnu.org; Sat, 05 Oct 2019 20:03:21 -0400 Received: from mga09.intel.com ([134.134.136.24]:11793) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGu1A-0001kY-5G for qemu-devel@nongnu.org; Sat, 05 Oct 2019 20:03:20 -0400 Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2019 17:03:19 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga008.fm.intel.com with ESMTP; 05 Oct 2019 17:03:18 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,261,1566889200"; d="scan'208";a="191929243" From: Wei Yang To: quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 2/3] migration/postcopy: postpone setting PostcopyState to END Date: Sun, 6 Oct 2019 08:02:48 +0800 Message-Id: <20191006000249.29926-3-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191006000249.29926-1-richardw.yang@linux.intel.com> References: <20191006000249.29926-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.24 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" There are two places to call function postcopy_ram_incoming_cleanup() postcopy_ram_listen_thread on migration success loadvm_postcopy_handle_listen one setup failure On success, the vm will never accept another migration. On failure, PostcopyState is transited from LISTENING to END and would be checked in qemu_loadvm_state_main(). If PostcopyState is RUNNING, migration would be paused and retried. Currently PostcopyState is set to END in function postcopy_ram_incoming_cleanup(). With above analysis, we can take this step out and postpone this till the end of listen thread to indicate the listen thread is done. This is a preparation patch for later cleanup. Signed-off-by: Wei Yang Reviewed-by: Dr. David Alan Gilbert --- migration/postcopy-ram.c | 2 -- migration/savevm.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index a394c7c3a6..5da6de8c8b 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -577,8 +577,6 @@ int postcopy_ram_incoming_cleanup(MigrationIncomingStat= e *mis) } } =20 - postcopy_state_set(POSTCOPY_INCOMING_END, NULL); - if (mis->postcopy_tmp_page) { munmap(mis->postcopy_tmp_page, mis->largest_page_size); mis->postcopy_tmp_page =3D NULL; diff --git a/migration/savevm.c b/migration/savevm.c index eaa4cf58ef..dcad8897a3 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1837,6 +1837,8 @@ static void *postcopy_ram_listen_thread(void *opaque) =20 rcu_unregister_thread(); mis->have_listen_thread =3D false; + postcopy_state_set(POSTCOPY_INCOMING_END, NULL); + return NULL; } =20 --=20 2.17.1