From nobody Wed Nov 12 11:54:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570313585; cv=none; d=zoho.com; s=zohoarc; b=KCNK5F7U60lUU4iO965TetLo4+3PyPmyymughN1qWWpPO3ZqgYw4uC8VfIEzhZTRgdpjoNoXWiLHLiEL6Xkjn+blgnFu9ABSsOvbEoT7k3bckeL53bORDEYFGcpLVk27gEdajg1V0i0uvsv9Fc6MGOIldpjOfVdyGDE1U3w+nKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570313585; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=VoSjSAVVIzLWycuAEoG7TooDZ4f8N2rH7x8/OwYiuYI=; b=AvnIjrx3Tff6p7Fg8qFI8EjF5DwWw0XN0crVk7mJiXWIhTS2XtnHa+YCGl7KE/Hsn+kv1kxHm3L8Iy30zz5Gbom/Z87SOyJNxWeUORuD5rHsDXFld+Wtmr363wFSWN/KcwTGV7Jdg3AV9RAIa1ckx8NAj4c2SPPdBTs2p+n7rdA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570313585228912.6520480529017; Sat, 5 Oct 2019 15:13:05 -0700 (PDT) Received: from localhost ([::1]:59124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGsIO-0000Mw-G5 for importer@patchew.org; Sat, 05 Oct 2019 18:13:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48536) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGsBg-0001z6-1E for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGsBe-0007AX-VO for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:03 -0400 Received: from mga03.intel.com ([134.134.136.65]:4371) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGsBe-0007AF-OI for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:02 -0400 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2019 15:06:01 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga003.jf.intel.com with ESMTP; 05 Oct 2019 15:06:00 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,261,1566889200"; d="scan'208";a="195906813" From: Wei Yang To: quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 1/4] migration/ram: only possible bit set in invalid_flags is RAM_SAVE_FLAG_COMPRESS_PAGE Date: Sun, 6 Oct 2019 06:05:14 +0800 Message-Id: <20191005220517.24029-2-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191005220517.24029-1-richardw.yang@linux.intel.com> References: <20191005220517.24029-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The only possible bit set in invalid_flags is RAM_SAVE_FLAG_COMPRESS_PAGE at the beginning of function ram_load_precopy(), which means it is not necessary to do another check for RAM_SAVE_FLAG_COMPRESS_PAGE bit. Signed-off-by: Wei Yang --- migration/ram.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 31051935c8..769d3f6454 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -4263,10 +4263,7 @@ static int ram_load_precopy(QEMUFile *f) addr &=3D TARGET_PAGE_MASK; =20 if (flags & invalid_flags) { - if (flags & invalid_flags & RAM_SAVE_FLAG_COMPRESS_PAGE) { - error_report("Received an unexpected compressed page"); - } - + error_report("Received an unexpected compressed page"); ret =3D -EINVAL; break; } --=20 2.17.1