From nobody Wed Nov 12 10:10:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570313585; cv=none; d=zoho.com; s=zohoarc; b=KCNK5F7U60lUU4iO965TetLo4+3PyPmyymughN1qWWpPO3ZqgYw4uC8VfIEzhZTRgdpjoNoXWiLHLiEL6Xkjn+blgnFu9ABSsOvbEoT7k3bckeL53bORDEYFGcpLVk27gEdajg1V0i0uvsv9Fc6MGOIldpjOfVdyGDE1U3w+nKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570313585; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=VoSjSAVVIzLWycuAEoG7TooDZ4f8N2rH7x8/OwYiuYI=; b=AvnIjrx3Tff6p7Fg8qFI8EjF5DwWw0XN0crVk7mJiXWIhTS2XtnHa+YCGl7KE/Hsn+kv1kxHm3L8Iy30zz5Gbom/Z87SOyJNxWeUORuD5rHsDXFld+Wtmr363wFSWN/KcwTGV7Jdg3AV9RAIa1ckx8NAj4c2SPPdBTs2p+n7rdA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570313585228912.6520480529017; Sat, 5 Oct 2019 15:13:05 -0700 (PDT) Received: from localhost ([::1]:59124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGsIO-0000Mw-G5 for importer@patchew.org; Sat, 05 Oct 2019 18:13:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48536) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGsBg-0001z6-1E for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGsBe-0007AX-VO for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:03 -0400 Received: from mga03.intel.com ([134.134.136.65]:4371) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGsBe-0007AF-OI for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:02 -0400 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2019 15:06:01 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga003.jf.intel.com with ESMTP; 05 Oct 2019 15:06:00 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,261,1566889200"; d="scan'208";a="195906813" From: Wei Yang To: quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 1/4] migration/ram: only possible bit set in invalid_flags is RAM_SAVE_FLAG_COMPRESS_PAGE Date: Sun, 6 Oct 2019 06:05:14 +0800 Message-Id: <20191005220517.24029-2-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191005220517.24029-1-richardw.yang@linux.intel.com> References: <20191005220517.24029-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The only possible bit set in invalid_flags is RAM_SAVE_FLAG_COMPRESS_PAGE at the beginning of function ram_load_precopy(), which means it is not necessary to do another check for RAM_SAVE_FLAG_COMPRESS_PAGE bit. Signed-off-by: Wei Yang --- migration/ram.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 31051935c8..769d3f6454 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -4263,10 +4263,7 @@ static int ram_load_precopy(QEMUFile *f) addr &=3D TARGET_PAGE_MASK; =20 if (flags & invalid_flags) { - if (flags & invalid_flags & RAM_SAVE_FLAG_COMPRESS_PAGE) { - error_report("Received an unexpected compressed page"); - } - + error_report("Received an unexpected compressed page"); ret =3D -EINVAL; break; } --=20 2.17.1 From nobody Wed Nov 12 10:10:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570313822; cv=none; d=zoho.com; s=zohoarc; b=Hno568X84ALWa0t37EpAlDZaLBwTiDsDkMkp7W0jExlde2BryHYP2jg9wC4myRhQa5HosU2/UZbC4Ah3coca26MotQFOJ4EyU3WdCdtgIkty+cUFDq3VxZ0L3t5VruVxILARixbVmVOAqNynkQyNwXVGoZEoY/lB6b6sAu8ob4A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570313822; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=seqJQxfljNytNHmPSczU+hjj0YGEy6ocxLIRLfnaHU0=; b=aAKFglKsrbJcCFVLOhF8S4xPUP62ii4/Hoyw+L8x/q4X8SmoyS5+hi0NVwUdWnLXPgBzf0lq8LRdx51jZID3l9ZITB+rs1lt67BI8k1FY5NBr+5wctpInPYTpcf32nffoWzJQ+eddbahTn1HBWQsYxFRYF8fnnx+bMwTMn/yaQU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570313822477271.80804255007865; Sat, 5 Oct 2019 15:17:02 -0700 (PDT) Received: from localhost ([::1]:59156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGsME-0004MB-Gi for importer@patchew.org; Sat, 05 Oct 2019 18:16:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48541) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGsBg-0001zh-Cp for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGsBf-0007Al-F2 for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:04 -0400 Received: from mga03.intel.com ([134.134.136.65]:4371) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGsBf-0007AF-7F for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:03 -0400 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2019 15:06:02 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga003.jf.intel.com with ESMTP; 05 Oct 2019 15:06:02 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,261,1566889200"; d="scan'208";a="195906820" From: Wei Yang To: quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 2/4] migration/postcopy: fix typo in mark_postcopy_blocktime_begin's comment Date: Sun, 6 Oct 2019 06:05:15 +0800 Message-Id: <20191005220517.24029-3-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191005220517.24029-1-richardw.yang@linux.intel.com> References: <20191005220517.24029-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Wei Yang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- migration/postcopy-ram.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index d2bdd21ae3..a394c7c3a6 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -768,9 +768,11 @@ static void mark_postcopy_blocktime_begin(uintptr_t ad= dr, uint32_t ptid, atomic_xchg(&dc->page_fault_vcpu_time[cpu], low_time_offset); atomic_xchg(&dc->vcpu_addr[cpu], addr); =20 - /* check it here, not at the begining of the function, - * due to, check could accur early than bitmap_set in - * qemu_ufd_copy_ioctl */ + /* + * check it here, not at the beginning of the function, + * due to, check could occur early than bitmap_set in + * qemu_ufd_copy_ioctl + */ already_received =3D ramblock_recv_bitmap_test(rb, (void *)addr); if (already_received) { atomic_xchg(&dc->vcpu_addr[cpu], 0); --=20 2.17.1 From nobody Wed Nov 12 10:10:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570314086; cv=none; d=zoho.com; s=zohoarc; b=UQlV1GrmGAe+s2l2cgCb4e1zV4ISHcq6GNDOJpu+hc7m9D8qGDXAki4NqOcEaD9c8xR77sKn+LliI8s8xNomz5YK2nyz/vAUWi0Uzy4bZZEP2FNh8xngB54mloo9+B4zNBjSXtv5PTlys1WdySRpVE2VHIKT8V8ST6bpZLWuOGQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570314086; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=GyamkkFiWQGwgNS4YFfpyjLA6bmFBOB15XYpZjqdRKo=; b=QoMaf3rj3YiD20MSeUWtXei2a282Mcw/U5ab5aOD0fM3Ll/mMycWAsEtx9KkrKSyiA0tJl5SSCYkFvU7vyIYNO6eoQhwC5fQAgS62XZkm4AqPdWXmVmn6IT9i7NGJN8OgMDJSVjLwacLSApukmA3mS5GVqu3ZBlHZhZKwS/6HMA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570314086261957.2271866969508; Sat, 5 Oct 2019 15:21:26 -0700 (PDT) Received: from localhost ([::1]:59182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGsQW-0008FE-VD for importer@patchew.org; Sat, 05 Oct 2019 18:21:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48556) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGsBi-00022J-Dq for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGsBh-0007BP-GV for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:06 -0400 Received: from mga03.intel.com ([134.134.136.65]:4371) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGsBh-0007AF-9T for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:05 -0400 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2019 15:06:05 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga003.jf.intel.com with ESMTP; 05 Oct 2019 15:06:03 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,261,1566889200"; d="scan'208";a="195906828" From: Wei Yang To: quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 3/4] migration: pass in_postcopy instead of check state again Date: Sun, 6 Oct 2019 06:05:16 +0800 Message-Id: <20191005220517.24029-4-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191005220517.24029-1-richardw.yang@linux.intel.com> References: <20191005220517.24029-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Not necessary to do the check again. Signed-off-by: Wei Yang Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index c8eaa85867..56031305e3 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -3148,8 +3148,7 @@ static MigIterateState migration_iteration_run(Migrat= ionState *s) return MIG_ITERATE_SKIP; } /* Just another iteration step */ - qemu_savevm_state_iterate(s->to_dst_file, - s->state =3D=3D MIGRATION_STATUS_POSTCOPY_ACTIVE); + qemu_savevm_state_iterate(s->to_dst_file, in_postcopy); } else { trace_migration_thread_low_pending(pending_size); migration_completion(s); --=20 2.17.1 From nobody Wed Nov 12 10:10:53 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1570314184; cv=none; d=zoho.com; s=zohoarc; b=BWBQ94nSXFK34noCM/t2aTUCM+48t/LLqVLNVsyvjYOLXp6gPdX8nID/1/TDGrTKkvMQgnpnqhfUoOvY2LwhuRejMKWRkPfZ3EAoeuZKvL20wQ2aIBkRLOsx7vry2fq1Zk+S+BVftZxHGteL4c0jL33MTFvQX86yCrs42+CpdT8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570314184; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=qvD9dceHP7BwgicuSZmXgSvl+MgsRFwbFhMI6bBTxaA=; b=i+31P6934z+2E7i3Pj33vqGwhgIADINPlfNOb4cePu/GOaAqufqBKl3IzVp0eG3hDd8YavsIhO6AYLpv+zA1rfYRy/BzAceRHB6rr3Sldlxgi0dWIpAxMir+ERaUVOKzpPURlzmGwuMIqt6L44TqP9NFUNDOdHIBDlqeSe4XoG0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15703141846975.216152712289045; Sat, 5 Oct 2019 15:23:04 -0700 (PDT) Received: from localhost ([::1]:59190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGsS7-0001PY-4Z for importer@patchew.org; Sat, 05 Oct 2019 18:23:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48568) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGsBk-00024s-Jf for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGsBj-0007Bt-Jp for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:08 -0400 Received: from mga03.intel.com ([134.134.136.65]:4371) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGsBj-0007AF-Ce for qemu-devel@nongnu.org; Sat, 05 Oct 2019 18:06:07 -0400 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2019 15:06:07 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga003.jf.intel.com with ESMTP; 05 Oct 2019 15:06:05 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,261,1566889200"; d="scan'208";a="195906835" From: Wei Yang To: quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 4/4] migration: report SaveStateEntry id and name on failure Date: Sun, 6 Oct 2019 06:05:17 +0800 Message-Id: <20191005220517.24029-5-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191005220517.24029-1-richardw.yang@linux.intel.com> References: <20191005220517.24029-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This provides helpful information on which entry failed. Signed-off-by: Wei Yang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- migration/savevm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index 9f0122583d..feb757de79 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1215,6 +1215,8 @@ int qemu_savevm_state_iterate(QEMUFile *f, bool postc= opy) save_section_footer(f, se); =20 if (ret < 0) { + error_report("failed to save SaveStateEntry with id(name): %d(= %s)", + se->section_id, se->idstr); qemu_file_set_error(f, ret); } if (ret <=3D 0) { --=20 2.17.1