From nobody Wed Nov 12 10:09:30 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1570287859; cv=none; d=zoho.com; s=zohoarc; b=gDkbSoSzZufXjAF+9UfmmEmxIb4X4prq4AtYHJG6ePMtKmrcHuju/GRoL/P2N0UPjqrp4VhLUloEZ59RTVivKbDrCEwgMyh+uZJa4O4cKcjLkR0JlKI2SW3HZW6Pn8nmG3UmXI+fN0utxQqAt8YhV+KCv0+xIE3x18PUYdrhpXE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570287859; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=9xIPwHoZQTBX/1rMkGn54r/An4esCo8ilJZSXHXy5A0=; b=ljOQvLFpHQamvV+W7InvldUCTuHmjtjobcQ6Zylnj4z1OQMhDpSNqk/B4P6Pef8Cz4FBOZPVwaJxZxuS5QhSTKLQYNY19TjTNq0Qb7h6CB/iws+nMwT1aD1V5KKab9A/ZKuSYJcWN9rddEGJ/pFSZkLS/w5YRGV+4G6dVQXUYd8= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570287859445350.44870650494227; Sat, 5 Oct 2019 08:04:19 -0700 (PDT) Received: from localhost ([::1]:57231 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGlbL-0003DI-QS for importer@patchew.org; Sat, 05 Oct 2019 11:04:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39733) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGlaZ-0002ek-5h for qemu-devel@nongnu.org; Sat, 05 Oct 2019 11:03:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGlaY-000391-3o for qemu-devel@nongnu.org; Sat, 05 Oct 2019 11:03:19 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:52842) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iGlaX-00038k-Sd; Sat, 05 Oct 2019 11:03:18 -0400 Received: by mail-wm1-x341.google.com with SMTP id r19so8462058wmh.2; Sat, 05 Oct 2019 08:03:16 -0700 (PDT) Received: from localhost.localdomain (46.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.46]) by smtp.gmail.com with ESMTPSA id 79sm14190268wmb.7.2019.10.05.08.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Oct 2019 08:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9xIPwHoZQTBX/1rMkGn54r/An4esCo8ilJZSXHXy5A0=; b=fBDk0Ma8hTiGyGbx1RWIt64e75s+884OVPL2ObCPDkCDuKBji0D4civ3FohpWfC7E6 f1bfpTmeTJFRfLQANGaO/0evGpjdXZV50UgIEs6yVEZ8Az9d0cVY+vh9H4ENgpLwCvd0 5QOqt/LQOJIvX9WzvOSs3gx+H27KmGPPQFsNpXo14pDd0XUv91i4Yn8fHqCyhdXLTcZX Ozb9rc2EqM49ACXCzjQy1SNzalYI3Gi8NPysMCHu8ekhoi1ZAN2LTEwymysF5y3u0xPd ZWCQ/icIGQHvhWP4xlJSr7k3R1xKTt/z5VoVS9aXZYGL71dCOQUp+6L2LF45e4PR0FcU VRgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=9xIPwHoZQTBX/1rMkGn54r/An4esCo8ilJZSXHXy5A0=; b=DMxOKzgFR6Tm0HbETBtz+2CV+utpsHWImn4Qr1XWncZfdjtpumbypJuFbLKawFxr+d 1mB2w75w1lwuLDunCCQBmptMsUKOocWE0LlmX/dUpw7rbEdanVyyrcBl0zzIrUZRb1pY 5ifUK2yW71Yd9mJQMYM3KagIxudObhjOgNiKHXyMP574znxxWslVCCbPZUw1b0oZIn8c z5+lZx7wmwFwMnl5mcENjxTaxL6ASxbPQlZ7K0EmEuWjgLPmrzXObQKd/RKx0tmjSxMe 3aPsuOWJBCwAu4UIF8dwLgF2zReJHv6S77wrX1bCO8niUY0vKE3iQxlkTqaDeWwmfgZa hCYA== X-Gm-Message-State: APjAAAXULCCC0Wi/tZVteOD8csLG6oWU95YYHGYbJqfTC7rV9Imgml/+ heMdmaWMkw+Aqd9eSjU9WpuI7o04dek= X-Google-Smtp-Source: APXvYqyecaDJtufDTKp8+GoulfvrGCIUXE/C1SutNMkkPZiLVWzkEFImnvdw9NRsKfiHlbUOk1OCWQ== X-Received: by 2002:a1c:1c7:: with SMTP id 190mr13524469wmb.23.1570287795336; Sat, 05 Oct 2019 08:03:15 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH] hw/dma/etraxfs_dma: Simplify using MemoryRegionOps::impl access_size Date: Sat, 5 Oct 2019 17:03:11 +0200 Message-Id: <20191005150311.16373-1-f4bug@amsat.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, "Edgar E. Iglesias" , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) This device implementation is clearly restricted to 32-bit accesses. Set the MemoryRegionOps::impl min/max access_size fields to simplify the code, and remove the hw_error() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/dma/etraxfs_dma.c | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/hw/dma/etraxfs_dma.c b/hw/dma/etraxfs_dma.c index 47e1c6df12..dcb2286bd9 100644 --- a/hw/dma/etraxfs_dma.c +++ b/hw/dma/etraxfs_dma.c @@ -23,7 +23,6 @@ */ =20 #include "qemu/osdep.h" -#include "hw/hw.h" #include "hw/irq.h" #include "qemu/main-loop.h" #include "sysemu/runstate.h" @@ -577,12 +576,6 @@ static inline int channel_in_run(struct fs_dma_ctrl *c= trl, int c) return 0; } =20 -static uint32_t dma_rinvalid (void *opaque, hwaddr addr) -{ - hw_error("Unsupported short raccess. reg=3D" TARGET_FMT_plx "\n", = addr); - return 0; -} - static uint64_t dma_read(void *opaque, hwaddr addr, unsigned int size) { @@ -590,10 +583,6 @@ dma_read(void *opaque, hwaddr addr, unsigned int size) int c; uint32_t r =3D 0; =20 - if (size !=3D 4) { - dma_rinvalid(opaque, addr); - } - /* Make addr relative to this channel and bounded to nr regs. */ c =3D fs_channel(addr); addr &=3D 0xff; @@ -615,12 +604,6 @@ dma_read(void *opaque, hwaddr addr, unsigned int size) return r; } =20 -static void -dma_winvalid (void *opaque, hwaddr addr, uint32_t value) -{ - hw_error("Unsupported short waccess. reg=3D" TARGET_FMT_plx "\n", = addr); -} - static void dma_update_state(struct fs_dma_ctrl *ctrl, int c) { @@ -638,10 +621,6 @@ dma_write(void *opaque, hwaddr addr, uint32_t value =3D val64; int c; =20 - if (size !=3D 4) { - dma_winvalid(opaque, addr, value); - } - /* Make addr relative to this channel and bounded to nr regs. */ c =3D fs_channel(addr); addr &=3D 0xff; @@ -701,6 +680,10 @@ static const MemoryRegionOps dma_ops =3D { .read =3D dma_read, .write =3D dma_write, .endianness =3D DEVICE_NATIVE_ENDIAN, + .impl =3D { + .min_access_size =3D 4, + .max_access_size =3D 4, + }, .valid =3D { .min_access_size =3D 1, .max_access_size =3D 4 --=20 2.20.1