From nobody Wed Nov 12 11:58:09 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1570205545; cv=none; d=zoho.com; s=zohoarc; b=aupX+OhCRRc5F+gwK9v4LbcCWfLx/rrjLc9pBFq5esYFtT7xpx/n11fw1chZPV5HizqDZtZc+XexIImZNYqSg2eVYHtKka3Z5cbHT9qgMS+2HtEqzSVRENInar502yFnhe1dB8IfCPgoUnOqiJ3fEGtiltyMN5m6mWxhdNQ/f1E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570205545; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=QIeaf2KKxKy3+uiwxAPUjJoc6ZRrwX01qOPMG1NRRJk=; b=bGvGPp6Br+7rAwoGlMC0kTBwOmPwQn5/oEua/wPt7c8VmOFgXy2NCrzSmQD6Kq4/6IHZ8m7qW4EWrkpvWS4Bdb8NNgh9eQ4OdYLqlP8T8GskWBuOwSESzJCY+h6zPfa3C529MTOwbFA5j6Wx49lZcIvd5ljz/5Lh2LdtLb12CRg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570205545563218.6241506615903; Fri, 4 Oct 2019 09:12:25 -0700 (PDT) Received: from localhost ([::1]:50134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGQBq-0001Lt-AG for importer@patchew.org; Fri, 04 Oct 2019 12:12:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42328) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGPuf-0006N3-60 for qemu-devel@nongnu.org; Fri, 04 Oct 2019 11:54:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGPud-0000f7-TQ for qemu-devel@nongnu.org; Fri, 04 Oct 2019 11:54:37 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:50966 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGPuU-0000XK-GF; Fri, 04 Oct 2019 11:54:26 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id D6CA060ED9B3CA423F9F; Fri, 4 Oct 2019 23:54:22 +0800 (CST) Received: from S00345302A-PC.china.huawei.com (10.202.227.237) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Fri, 4 Oct 2019 23:54:13 +0800 From: Shameer Kolothum To: , , , Subject: [PATCH 5/5] hw/arm/virt: Add nvdimm hotplug support Date: Fri, 4 Oct 2019 16:53:02 +0100 Message-ID: <20191004155302.4632-6-shameerali.kolothum.thodi@huawei.com> X-Mailer: git-send-email 2.12.0.windows.1 In-Reply-To: <20191004155302.4632-1-shameerali.kolothum.thodi@huawei.com> References: <20191004155302.4632-1-shameerali.kolothum.thodi@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.202.227.237] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, lersek@redhat.com, linuxarm@huawei.com, xuwei5@hisilicon.com, shannon.zhaosl@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This adds support for nvdimm hotplug events through GED and enables nvdimm for the arm/virt. Now Guests with DT boot can have nvdimm cold plug and with ACPI both cold/hot plug. Hot removal functionality is not yet supported. Signed-off-by: Shameer Kolothum Reviewed-by: Igor Mammedov --- docs/specs/acpi_hw_reduced_hotplug.rst | 1 + hw/acpi/generic_event_device.c | 13 +++++++++++++ hw/arm/virt.c | 20 +++++++++++++++----- include/hw/acpi/generic_event_device.h | 1 + 4 files changed, 30 insertions(+), 5 deletions(-) diff --git a/docs/specs/acpi_hw_reduced_hotplug.rst b/docs/specs/acpi_hw_re= duced_hotplug.rst index 911a98255b..e3abe975bf 100644 --- a/docs/specs/acpi_hw_reduced_hotplug.rst +++ b/docs/specs/acpi_hw_reduced_hotplug.rst @@ -63,6 +63,7 @@ GED IO interface (4 byte access) bits: 0: Memory hotplug event 1: System power down event + 2: NVDIMM hotplug event 2-31: Reserved =20 **write_access:** diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c index 9cee90cc70..ad1b684304 100644 --- a/hw/acpi/generic_event_device.c +++ b/hw/acpi/generic_event_device.c @@ -16,6 +16,7 @@ #include "hw/acpi/generic_event_device.h" #include "hw/irq.h" #include "hw/mem/pc-dimm.h" +#include "hw/mem/nvdimm.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "qemu/error-report.h" @@ -23,6 +24,7 @@ static const uint32_t ged_supported_events[] =3D { ACPI_GED_MEM_HOTPLUG_EVT, ACPI_GED_PWR_DOWN_EVT, + ACPI_GED_NVDIMM_HOTPLUG_EVT, }; =20 /* @@ -110,6 +112,11 @@ void build_ged_aml(Aml *table, const char *name, Hotpl= ugHandler *hotplug_dev, aml_notify(aml_name(ACPI_POWER_BUTTON_DEVICE), aml_int(0x80))); break; + case ACPI_GED_NVDIMM_HOTPLUG_EVT: + aml_append(if_ctx, + aml_notify(aml_name("\\_SB.NVDR"), + aml_int(0x80))); + break; default: /* * Please make sure all the events in ged_supported_events= [] @@ -175,7 +182,11 @@ static void acpi_ged_device_plug_cb(HotplugHandler *ho= tplug_dev, AcpiGedState *s =3D ACPI_GED(hotplug_dev); =20 if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM)) { + if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) { + nvdimm_acpi_plug_cb(hotplug_dev, dev); + } else { acpi_memory_plug_cb(hotplug_dev, &s->memhp_state, dev, errp); + } } else { error_setg(errp, "virt: device plug request for unsupported device" " type: %s", object_get_typename(OBJECT(dev))); @@ -192,6 +203,8 @@ static void acpi_ged_send_event(AcpiDeviceIf *adev, Acp= iEventStatusBits ev) sel =3D ACPI_GED_MEM_HOTPLUG_EVT; } else if (ev & ACPI_POWER_DOWN_STATUS) { sel =3D ACPI_GED_PWR_DOWN_EVT; + } else if (ev & ACPI_NVDIMM_HOTPLUG_STATUS) { + sel =3D ACPI_GED_NVDIMM_HOTPLUG_EVT; } else { /* Unknown event. Return without generating interrupt. */ warn_report("GED: Unsupported event %d. No irq injected", ev); diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 30bc8a7803..acdcba9638 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -543,6 +543,10 @@ static inline DeviceState *create_acpi_ged(VirtMachine= State *vms, qemu_irq *pic) event |=3D ACPI_GED_MEM_HOTPLUG_EVT; } =20 + if (ms->nvdimms_state->is_enabled) { + event |=3D ACPI_GED_NVDIMM_HOTPLUG_EVT; + } + dev =3D qdev_create(NULL, TYPE_ACPI_GED); qdev_prop_set_uint32(dev, "ged-event", event); =20 @@ -1938,9 +1942,12 @@ static void virt_memory_pre_plug(HotplugHandler *hot= plug_dev, DeviceState *dev, } =20 if (!vms->acpi_dev) { - error_setg(errp, - "memory hotplug is not enabled: missing acpi-ged device= "); - return; + /* Allow nvdimm DT or cold plug */ + if (!(is_nvdimm && !dev->hotplugged)) { + error_setg(errp, + "memory hotplug is not enabled: missing acpi-ged de= vice"); + return; + } } =20 pc_dimm_pre_plug(PC_DIMM(dev), MACHINE(hotplug_dev), NULL, errp); @@ -1964,8 +1971,10 @@ static void virt_memory_plug(HotplugHandler *hotplug= _dev, nvdimm_plug(ms->nvdimms_state); } =20 - hhc =3D HOTPLUG_HANDLER_GET_CLASS(vms->acpi_dev); - hhc->plug(HOTPLUG_HANDLER(vms->acpi_dev), dev, &error_abort); + if (vms->acpi_dev) { + hhc =3D HOTPLUG_HANDLER_GET_CLASS(vms->acpi_dev); + hhc->plug(HOTPLUG_HANDLER(vms->acpi_dev), dev, &error_abort); + } out: error_propagate(errp, local_err); } @@ -2073,6 +2082,7 @@ static void virt_machine_class_init(ObjectClass *oc, = void *data) hc->plug =3D virt_machine_device_plug_cb; hc->unplug_request =3D virt_machine_device_unplug_request_cb; mc->numa_mem_supported =3D true; + mc->nvdimm_supported =3D true; mc->auto_enable_numa_with_memhp =3D true; } =20 diff --git a/include/hw/acpi/generic_event_device.h b/include/hw/acpi/gener= ic_event_device.h index d157eac088..9eb86ca4fd 100644 --- a/include/hw/acpi/generic_event_device.h +++ b/include/hw/acpi/generic_event_device.h @@ -82,6 +82,7 @@ */ #define ACPI_GED_MEM_HOTPLUG_EVT 0x1 #define ACPI_GED_PWR_DOWN_EVT 0x2 +#define ACPI_GED_NVDIMM_HOTPLUG_EVT 0x4 =20 typedef struct GEDState { MemoryRegion io; --=20 2.17.1