From nobody Wed Nov 12 11:55:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1570184786; cv=none; d=zoho.com; s=zohoarc; b=Gh815LnLKDB0YEWh8NBf5C2+RaYqCxhig9ruhW0kncbyKsewmiWGD+DfyRG3EO6M4Ktz03W8uQEY1zmE4dGlwC+toj5WGqGrp+aZCiE1YhvBigs+Pj2uiRvFl3palsiXolk+Rme0fJOIGp1yO4v8hUIDs1Pb8t8Um/ISNCYfcHg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570184786; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=NP0nCdcwXr+6hwjtC1SkIeF/+RezPa95dX98Q871JeE=; b=ipH3mv2etrPrMHc9+EfhrsRqjE+HZqbmD3ilgkYs+XaojbP4w+T0opybIvqo/5vsRhbNVQoAXCpbbyq6tiKD0SemDbFTQj+2wvzku7ZGPA3ihk4+aWznlPGwe8w8ljoQzqP8uVJ5UwwVpCzYukDaosB+mBZmC4TRkuF1x+UIRnI= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570184786509209.1181385426686; Fri, 4 Oct 2019 03:26:26 -0700 (PDT) Received: from localhost ([::1]:45118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGKn2-0005sV-8l for importer@patchew.org; Fri, 04 Oct 2019 06:26:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53497) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGK3T-0006FK-UW for qemu-devel@nongnu.org; Fri, 04 Oct 2019 05:39:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGK3S-0006KM-NL for qemu-devel@nongnu.org; Fri, 04 Oct 2019 05:39:19 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:36063) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGK3S-00061v-Bb; Fri, 04 Oct 2019 05:39:18 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 46l4YR51cnz9sSV; Fri, 4 Oct 2019 19:38:03 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1570181883; bh=DQmngEMiivkphtE6NW57+oUk3GSNufbe24fbel5QQ2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ojNEZDsZR54iI2NbwFk67bOz65LCHRs0Zm+8qnCFBOVX3WCnFiMM/P+HayCv1z76T 0ZF0T6lHQB2vsR1cloCufOw7/s1Q/3f+48MLjQmu6eyWN4q1f5fMN3N+vxXxHLSPNC 6Jbhw0y5wmuCeIrrYvIma68ssbyykC4lWMSPE2DI= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 46/53] spapr: Remove unhelpful tracepoints from spapr_irq_free_xics() Date: Fri, 4 Oct 2019 19:37:40 +1000 Message-Id: <20191004093747.31350-47-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191004093747.31350-1-david@gibson.dropbear.id.au> References: <20191004093747.31350-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, aik@ozlabs.ru, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" These traces contain some useless information (the always-0 source#) and have no equivalents for XIVE mode. For now just remove them, and we can put back something more sensible if and when we need it. Signed-off-by: David Gibson Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/ppc/spapr_irq.c | 4 ---- hw/ppc/trace-events | 4 ---- 2 files changed, 8 deletions(-) diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c index ec2229d2d1..9919910a86 100644 --- a/hw/ppc/spapr_irq.c +++ b/hw/ppc/spapr_irq.c @@ -140,11 +140,7 @@ static void spapr_irq_free_xics(SpaprMachineState *spa= pr, int irq, int num) int i; =20 if (ics_valid_irq(ics, irq)) { - trace_spapr_irq_free(0, irq, num); for (i =3D srcno; i < srcno + num; ++i) { - if (ics_irq_free(ics, i)) { - trace_spapr_irq_free_warn(0, i); - } memset(&ics->irqs[i], 0, sizeof(ICSIRQState)); } } diff --git a/hw/ppc/trace-events b/hw/ppc/trace-events index 96dad767a1..9ea620f23c 100644 --- a/hw/ppc/trace-events +++ b/hw/ppc/trace-events @@ -13,10 +13,6 @@ spapr_pci_msi_retry(unsigned config_addr, unsigned req_n= um, unsigned max_irqs) " spapr_cas_failed(unsigned long n) "DT diff buffer is too small: %ld bytes" spapr_cas_continue(unsigned long n) "Copy changes to the guest: %ld bytes" =20 -# spapr_irq.c -spapr_irq_free(int src, int irq, int num) "Source#%d, first irq %d, %d irq= s" -spapr_irq_free_warn(int src, int irq) "Source#%d, irq %d is already free" - # spapr_hcall.c spapr_cas_pvr(uint32_t cur_pvr, bool explicit_match, uint32_t new_pvr) "cu= rrent=3D0x%x, explicit_match=3D%u, new=3D0x%x" spapr_h_resize_hpt_prepare(uint64_t flags, uint64_t shift) "flags=3D0x%"PR= Ix64", shift=3D%"PRIu64 --=20 2.21.0