[PATCH v4 0/3] KVM/ARM: Fix >256 vcpus

Eric Auger posted 3 patches 4 years, 5 months ago
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu failed
Test asan passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191003154640.22451-1-eric.auger@redhat.com
Maintainers: Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Cornelia Huck <cohuck@redhat.com>
hw/intc/arm_gic_kvm.c                         |   7 +-
include/standard-headers/asm-x86/bootparam.h  |   2 +
include/standard-headers/asm-x86/kvm_para.h   |   1 +
include/standard-headers/linux/ethtool.h      |  24 +++
include/standard-headers/linux/pci_regs.h     |  19 +-
include/standard-headers/linux/virtio_fs.h    |  19 ++
include/standard-headers/linux/virtio_ids.h   |   2 +
include/standard-headers/linux/virtio_iommu.h | 165 ++++++++++++++++++
include/standard-headers/linux/virtio_pmem.h  |   6 +-
linux-headers/asm-arm/kvm.h                   |  16 +-
linux-headers/asm-arm/unistd-common.h         |   2 +
linux-headers/asm-arm64/kvm.h                 |  21 ++-
linux-headers/asm-generic/mman-common.h       |  18 +-
linux-headers/asm-generic/mman.h              |  10 +-
linux-headers/asm-generic/unistd.h            |  10 +-
linux-headers/asm-mips/mman.h                 |   3 +
linux-headers/asm-mips/unistd_n32.h           |   1 +
linux-headers/asm-mips/unistd_n64.h           |   1 +
linux-headers/asm-mips/unistd_o32.h           |   1 +
linux-headers/asm-powerpc/mman.h              |   6 +-
linux-headers/asm-powerpc/unistd_32.h         |   2 +
linux-headers/asm-powerpc/unistd_64.h         |   2 +
linux-headers/asm-s390/kvm.h                  |   6 +
linux-headers/asm-s390/unistd_32.h            |   2 +
linux-headers/asm-s390/unistd_64.h            |   2 +
linux-headers/asm-x86/kvm.h                   |  28 ++-
linux-headers/asm-x86/unistd.h                |   2 +-
linux-headers/asm-x86/unistd_32.h             |   2 +
linux-headers/asm-x86/unistd_64.h             |   2 +
linux-headers/asm-x86/unistd_x32.h            |   2 +
linux-headers/linux/kvm.h                     |  12 +-
linux-headers/linux/psp-sev.h                 |   5 +-
linux-headers/linux/vfio.h                    |  71 +++++---
target/arm/cpu.c                              |  10 +-
target/arm/kvm.c                              |  22 ++-
target/arm/kvm_arm.h                          |   1 +
36 files changed, 434 insertions(+), 71 deletions(-)
create mode 100644 include/standard-headers/linux/virtio_fs.h
create mode 100644 include/standard-headers/linux/virtio_iommu.h
[PATCH v4 0/3] KVM/ARM: Fix >256 vcpus
Posted by Eric Auger 4 years, 5 months ago
Since 4.18, KVM/ARM exposes a KVM_MAX_VCPUS equal to 512. However it was
reported [1] that a VM with more than 256 vcpus cannot be launched. 5.4
fixes the situation with 2 patches:
- one upgrade of the KVM_IRQ_LINE API [2] supporting a vcpu id encoded
  on 12 bits,
- the reduction of KVM IO devices consumed by each GICv3 redistributor [3]

This series uses the new KVM_IRQ_LINE API and also checks the associated
capability (KVM_CAP_ARM_IRQ_LINE_LAYOUT_2) in machvirt.

Without the series, as soon as the -smp arguments exceeds 256, QEMU exits
with "kvm_set_irq: Invalid argument".

Best Regards

Eric

This series can be found at:
https://github.com/eauger/qemu/tree/v4.1.0-256fix-patch-v4

History:

v3 -> v4:
- headers update against v5.4-rc1
- moved to patch as the kernel dependencies are resolved in 5.4
- Added Richard and Drew's R-b

v2 -> v3:
- simplifications in kvm_arm_gic_set_irq
- Implement KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 check in kvm_arch_init

v1 -> v2:
- New layout set for kvm_arm_gic_set_irq and
  arm_cpu_kvm_set_irq through kvm_arm_set_irq
- Introduced kvm_arm_irq_line_layout_mismatch()

Eric Auger (3):
  linux headers: update against v5.4-rc1
  intc/arm_gic: Support IRQ injection for more than 256 vpus
  ARM: KVM: Check KVM_CAP_ARM_IRQ_LINE_LAYOUT_2 for smp_cpus > 256

 hw/intc/arm_gic_kvm.c                         |   7 +-
 include/standard-headers/asm-x86/bootparam.h  |   2 +
 include/standard-headers/asm-x86/kvm_para.h   |   1 +
 include/standard-headers/linux/ethtool.h      |  24 +++
 include/standard-headers/linux/pci_regs.h     |  19 +-
 include/standard-headers/linux/virtio_fs.h    |  19 ++
 include/standard-headers/linux/virtio_ids.h   |   2 +
 include/standard-headers/linux/virtio_iommu.h | 165 ++++++++++++++++++
 include/standard-headers/linux/virtio_pmem.h  |   6 +-
 linux-headers/asm-arm/kvm.h                   |  16 +-
 linux-headers/asm-arm/unistd-common.h         |   2 +
 linux-headers/asm-arm64/kvm.h                 |  21 ++-
 linux-headers/asm-generic/mman-common.h       |  18 +-
 linux-headers/asm-generic/mman.h              |  10 +-
 linux-headers/asm-generic/unistd.h            |  10 +-
 linux-headers/asm-mips/mman.h                 |   3 +
 linux-headers/asm-mips/unistd_n32.h           |   1 +
 linux-headers/asm-mips/unistd_n64.h           |   1 +
 linux-headers/asm-mips/unistd_o32.h           |   1 +
 linux-headers/asm-powerpc/mman.h              |   6 +-
 linux-headers/asm-powerpc/unistd_32.h         |   2 +
 linux-headers/asm-powerpc/unistd_64.h         |   2 +
 linux-headers/asm-s390/kvm.h                  |   6 +
 linux-headers/asm-s390/unistd_32.h            |   2 +
 linux-headers/asm-s390/unistd_64.h            |   2 +
 linux-headers/asm-x86/kvm.h                   |  28 ++-
 linux-headers/asm-x86/unistd.h                |   2 +-
 linux-headers/asm-x86/unistd_32.h             |   2 +
 linux-headers/asm-x86/unistd_64.h             |   2 +
 linux-headers/asm-x86/unistd_x32.h            |   2 +
 linux-headers/linux/kvm.h                     |  12 +-
 linux-headers/linux/psp-sev.h                 |   5 +-
 linux-headers/linux/vfio.h                    |  71 +++++---
 target/arm/cpu.c                              |  10 +-
 target/arm/kvm.c                              |  22 ++-
 target/arm/kvm_arm.h                          |   1 +
 36 files changed, 434 insertions(+), 71 deletions(-)
 create mode 100644 include/standard-headers/linux/virtio_fs.h
 create mode 100644 include/standard-headers/linux/virtio_iommu.h

-- 
2.20.1


Re: [PATCH v4 0/3] KVM/ARM: Fix >256 vcpus
Posted by Marc Zyngier 4 years, 5 months ago
On Thu, 03 Oct 2019 16:46:37 +0100,
Eric Auger <eric.auger@redhat.com> wrote:
> 
> Since 4.18, KVM/ARM exposes a KVM_MAX_VCPUS equal to 512. However it was
> reported [1] that a VM with more than 256 vcpus cannot be launched. 5.4
> fixes the situation with 2 patches:
> - one upgrade of the KVM_IRQ_LINE API [2] supporting a vcpu id encoded
>   on 12 bits,
> - the reduction of KVM IO devices consumed by each GICv3 redistributor [3]
> 
> This series uses the new KVM_IRQ_LINE API and also checks the associated
> capability (KVM_CAP_ARM_IRQ_LINE_LAYOUT_2) in machvirt.
> 
> Without the series, as soon as the -smp arguments exceeds 256, QEMU exits
> with "kvm_set_irq: Invalid argument".

FWIW, and for the whole series:

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Jazz is not dead, it just smells funny.

Re: [PATCH v4 0/3] KVM/ARM: Fix >256 vcpus
Posted by Peter Maydell 4 years, 5 months ago
On Thu, 3 Oct 2019 at 16:46, Eric Auger <eric.auger@redhat.com> wrote:
>
> Since 4.18, KVM/ARM exposes a KVM_MAX_VCPUS equal to 512. However it was
> reported [1] that a VM with more than 256 vcpus cannot be launched. 5.4
> fixes the situation with 2 patches:
> - one upgrade of the KVM_IRQ_LINE API [2] supporting a vcpu id encoded
>   on 12 bits,
> - the reduction of KVM IO devices consumed by each GICv3 redistributor [3]
>
> This series uses the new KVM_IRQ_LINE API and also checks the associated
> capability (KVM_CAP_ARM_IRQ_LINE_LAYOUT_2) in machvirt.
>
> Without the series, as soon as the -smp arguments exceeds 256, QEMU exits
> with "kvm_set_irq: Invalid argument".


Applied to target-arm.next, thanks.

-- PMM