From nobody Wed Dec 17 05:38:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1570033338; cv=none; d=zoho.com; s=zohoarc; b=bTP+op2fWDC940TjFflRShGhCWByA96bjZ5gtCmtYfzJqxuC3xw6gINKxfL/TRIX7/iwtUi1q8xHW2EW42/rmAXGMai+aPZgI/k7d3BAwgp0jBdrB7gCQe8n5PDA8AfIPwfStChpjK07Mfn5X0qte8DaAxfqqAYXJLPLCfVXJzo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1570033338; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=iHboBbxyRfDijZRSo1QBZVrB1EdMoJ+EZ7ajsRMDx70=; b=OpSD2kH3TDxH3MMDMz2NHx3NMQFBA0fcK4Xdj5rzGxaNL8wpcfqzPYqD8QFUtOpJmQY618/8d3uJ9GH4JG9JhUynVAGS8KKxpFP2Oo8EwzGdGUKSgs6JcI3u0OgJ9nh1e6nXNyrtJFRIDql3w19vupcROnSmHZm42FcMZs1PWKo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1570033338133163.34295532019064; Wed, 2 Oct 2019 09:22:18 -0700 (PDT) Received: from localhost ([::1]:57490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFhOK-0000RS-5Z for importer@patchew.org; Wed, 02 Oct 2019 12:22:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58875) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFhLN-0005se-0i for qemu-devel@nongnu.org; Wed, 02 Oct 2019 12:19:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFhLJ-000231-Ot for qemu-devel@nongnu.org; Wed, 02 Oct 2019 12:19:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53336) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFhLC-0001tH-HU; Wed, 02 Oct 2019 12:19:03 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 16F2B308A9E0; Wed, 2 Oct 2019 16:19:01 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-117-198.ams2.redhat.com [10.36.117.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC76B5D713; Wed, 2 Oct 2019 16:18:59 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PULL v2 2/4] iotests: Test internal snapshots with -blockdev Date: Wed, 2 Oct 2019 18:18:49 +0200 Message-Id: <20191002161851.1016-3-kwolf@redhat.com> In-Reply-To: <20191002161851.1016-1-kwolf@redhat.com> References: <20191002161851.1016-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 02 Oct 2019 16:19:01 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Signed-off-by: Kevin Wolf Reviewed-by: Peter Krempa Tested-by: Peter Krempa --- tests/qemu-iotests/267 | 168 ++++++++++++++++++++++++++++ tests/qemu-iotests/267.out | 182 +++++++++++++++++++++++++++++++ tests/qemu-iotests/common.filter | 11 +- tests/qemu-iotests/group | 1 + 4 files changed, 358 insertions(+), 4 deletions(-) create mode 100755 tests/qemu-iotests/267 create mode 100644 tests/qemu-iotests/267.out diff --git a/tests/qemu-iotests/267 b/tests/qemu-iotests/267 new file mode 100755 index 0000000000..d37a67c012 --- /dev/null +++ b/tests/qemu-iotests/267 @@ -0,0 +1,168 @@ +#!/usr/bin/env bash +# +# Test which nodes are involved in internal snapshots +# +# Copyright (C) 2019 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# + +# creator +owner=3Dkwolf@redhat.com + +seq=3D`basename $0` +echo "QA output created by $seq" + +status=3D1 # failure is the default! + +_cleanup() +{ + _cleanup_test_img + rm -f "$TEST_DIR/nbd" +} +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +_supported_fmt qcow2 +_supported_proto file +_supported_os Linux + +# Internal snapshots are (currently) impossible with refcount_bits=3D1 +_unsupported_imgopts 'refcount_bits=3D1[^0-9]' + +do_run_qemu() +{ + echo Testing: "$@" + ( + if ! test -t 0; then + while read cmd; do + echo $cmd + done + fi + echo quit + ) | $QEMU -nographic -monitor stdio -nodefaults "$@" + echo +} + +run_qemu() +{ + do_run_qemu "$@" 2>&1 | _filter_testdir | _filter_qemu | _filter_hmp | + _filter_generated_node_ids | _filter_imgfmt | _filter_vmstate_size +} + +size=3D128M + +run_test() +{ + _make_test_img $size + printf "savevm snap0\ninfo snapshots\nloadvm snap0\n" | run_qemu "$@" = | _filter_date +} + + +echo +echo "=3D=3D=3D No block devices at all =3D=3D=3D" +echo + +run_test + +echo +echo "=3D=3D=3D -drive if=3Dnone =3D=3D=3D" +echo + +run_test -drive driver=3Dfile,file=3D"$TEST_IMG",if=3Dnone +run_test -drive driver=3D$IMGFMT,file=3D"$TEST_IMG",if=3Dnone +run_test -drive driver=3D$IMGFMT,file=3D"$TEST_IMG",if=3Dnone -device virt= io-blk,drive=3Dnone0 + +echo +echo "=3D=3D=3D -drive if=3Dvirtio =3D=3D=3D" +echo + +run_test -drive driver=3Dfile,file=3D"$TEST_IMG",if=3Dvirtio +run_test -drive driver=3D$IMGFMT,file=3D"$TEST_IMG",if=3Dvirtio + +echo +echo "=3D=3D=3D Simple -blockdev =3D=3D=3D" +echo + +run_test -blockdev driver=3Dfile,filename=3D"$TEST_IMG",node-name=3Dfile +run_test -blockdev driver=3Dfile,filename=3D"$TEST_IMG",node-name=3Dfile \ + -blockdev driver=3D$IMGFMT,file=3Dfile,node-name=3Dfmt +run_test -blockdev driver=3Dfile,filename=3D"$TEST_IMG",node-name=3Dfile \ + -blockdev driver=3Draw,file=3Dfile,node-name=3Draw \ + -blockdev driver=3D$IMGFMT,file=3Draw,node-name=3Dfmt + +echo +echo "=3D=3D=3D -blockdev with a filter on top =3D=3D=3D" +echo + +run_test -blockdev driver=3Dfile,filename=3D"$TEST_IMG",node-name=3Dfile \ + -blockdev driver=3D$IMGFMT,file=3Dfile,node-name=3Dfmt \ + -blockdev driver=3Dcopy-on-read,file=3Dfmt,node-name=3Dfilter + +echo +echo "=3D=3D=3D -blockdev with a backing file =3D=3D=3D" +echo + +TEST_IMG=3D"$TEST_IMG.base" _make_test_img $size + +IMGOPTS=3D"backing_file=3D$TEST_IMG.base" \ +run_test -blockdev driver=3Dfile,filename=3D"$TEST_IMG.base",node-name=3Db= acking-file \ + -blockdev driver=3Dfile,filename=3D"$TEST_IMG",node-name=3Dfile \ + -blockdev driver=3D$IMGFMT,file=3Dfile,backing=3Dbacking-file,nod= e-name=3Dfmt + +IMGOPTS=3D"backing_file=3D$TEST_IMG.base" \ +run_test -blockdev driver=3Dfile,filename=3D"$TEST_IMG.base",node-name=3Db= acking-file \ + -blockdev driver=3D$IMGFMT,file=3Dbacking-file,node-name=3Dbackin= g-fmt \ + -blockdev driver=3Dfile,filename=3D"$TEST_IMG",node-name=3Dfile \ + -blockdev driver=3D$IMGFMT,file=3Dfile,backing=3Dbacking-fmt,node= -name=3Dfmt + +# A snapshot should be present on the overlay, but not the backing file +echo Internal snapshots on overlay: +$QEMU_IMG snapshot -l "$TEST_IMG" | _filter_date | _filter_vmstate_size + +echo Internal snapshots on backing file: +$QEMU_IMG snapshot -l "$TEST_IMG.base" | _filter_date | _filter_vmstate_si= ze + +echo +echo "=3D=3D=3D -blockdev with NBD server on the backing file =3D=3D=3D" +echo + +IMGOPTS=3D"backing_file=3D$TEST_IMG.base" _make_test_img $size +cat <