From nobody Mon Feb 9 22:37:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1569986060; cv=none; d=zoho.com; s=zohoarc; b=XGPY596LiIlXmak8ZQzMJedV95douMyHYeuJAGIWaPUODNz2bzT8dC6UN9QQz7cQf3+ANQllK/M2Pu9JeMR050RWdvKz5nP8Sum+ntWqRznHVZVio/61N+lAv+MWYl/jJHYu4SyuuIvvErS/LOw9mzdPMdv05LIyTkIJgZ6lEmY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569986060; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=NP0nCdcwXr+6hwjtC1SkIeF/+RezPa95dX98Q871JeE=; b=PByuqBVcQ0XVXHXKlebwyAJCdwTfvzEAb51uzLvqJy1MqA11hHXlPpMre8JNreWUpvAlnpZuyFZAwWJgPhVVg089GpZQ/JA8il0K9Me4Deb47YCv0WLjNyxPr1P28dE+gxpZfSJvTM9Bd+uMCKWhtxPM5nXBPdf84ErTMI3Y1pY= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156998606076295.67170305852596; Tue, 1 Oct 2019 20:14:20 -0700 (PDT) Received: from localhost ([::1]:50966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFV5n-0005m0-8C for importer@patchew.org; Tue, 01 Oct 2019 23:14:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59875) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFUko-0001fY-PG for qemu-devel@nongnu.org; Tue, 01 Oct 2019 22:52:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFUkl-0002ux-93 for qemu-devel@nongnu.org; Tue, 01 Oct 2019 22:52:38 -0400 Received: from ozlabs.org ([203.11.71.1]:59505) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFUkk-0002pE-HN; Tue, 01 Oct 2019 22:52:34 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 46jgf76vRfz9sRH; Wed, 2 Oct 2019 12:52:15 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1569984735; bh=DQmngEMiivkphtE6NW57+oUk3GSNufbe24fbel5QQ2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hY4sO15wgm9UmiXo6hbGZsTEG381n4/4Mz/VDt4uHgV+n+3DWGcS/MyypjvTN1/hI TgZLSrh+Vr3pLd56jP61Y4kY8iSb+PDJSeccf876k4IiL/vIwz/md6DUlrF3VQlRZv yxDrW5amWpjoy/w2wkuqaypLijKrFpxdM5WHVjw8= From: David Gibson To: qemu-ppc@nongnu.org, clg@kaod.org, qemu-devel@nongnu.org Subject: [PATCH v3 14/34] spapr: Remove unhelpful tracepoints from spapr_irq_free_xics() Date: Wed, 2 Oct 2019 12:51:48 +1000 Message-Id: <20191002025208.3487-15-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191002025208.3487-1-david@gibson.dropbear.id.au> References: <20191002025208.3487-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 203.11.71.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Riku Voipio , Laurent Vivier , groug@kaod.org, Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , philmd@redhat.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" These traces contain some useless information (the always-0 source#) and have no equivalents for XIVE mode. For now just remove them, and we can put back something more sensible if and when we need it. Signed-off-by: David Gibson Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/ppc/spapr_irq.c | 4 ---- hw/ppc/trace-events | 4 ---- 2 files changed, 8 deletions(-) diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c index ec2229d2d1..9919910a86 100644 --- a/hw/ppc/spapr_irq.c +++ b/hw/ppc/spapr_irq.c @@ -140,11 +140,7 @@ static void spapr_irq_free_xics(SpaprMachineState *spa= pr, int irq, int num) int i; =20 if (ics_valid_irq(ics, irq)) { - trace_spapr_irq_free(0, irq, num); for (i =3D srcno; i < srcno + num; ++i) { - if (ics_irq_free(ics, i)) { - trace_spapr_irq_free_warn(0, i); - } memset(&ics->irqs[i], 0, sizeof(ICSIRQState)); } } diff --git a/hw/ppc/trace-events b/hw/ppc/trace-events index 96dad767a1..9ea620f23c 100644 --- a/hw/ppc/trace-events +++ b/hw/ppc/trace-events @@ -13,10 +13,6 @@ spapr_pci_msi_retry(unsigned config_addr, unsigned req_n= um, unsigned max_irqs) " spapr_cas_failed(unsigned long n) "DT diff buffer is too small: %ld bytes" spapr_cas_continue(unsigned long n) "Copy changes to the guest: %ld bytes" =20 -# spapr_irq.c -spapr_irq_free(int src, int irq, int num) "Source#%d, first irq %d, %d irq= s" -spapr_irq_free_warn(int src, int irq) "Source#%d, irq %d is already free" - # spapr_hcall.c spapr_cas_pvr(uint32_t cur_pvr, bool explicit_match, uint32_t new_pvr) "cu= rrent=3D0x%x, explicit_match=3D%u, new=3D0x%x" spapr_h_resize_hpt_prepare(uint64_t flags, uint64_t shift) "flags=3D0x%"PR= Ix64", shift=3D%"PRIu64 --=20 2.21.0