From nobody Mon Feb 9 07:55:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1569957603; cv=none; d=zoho.com; s=zohoarc; b=PAhEs5JGm2A8vcIuJ51jXGDUJhnOI5AhMm+qsktn/J8Kc0On1kkJXkUF/lQwDey8Mj0ajPSMZ+uYOGROefNxwn6q+0WOgtzIdwCfuCYi+pDvasbl0L4BeChktzxLiC9AzXBcVEdPs27pH6ZR2qysJZBES/w0gYPjwyaX3ILrbPE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569957603; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=eURNYjsBVpdXdsgFGaE0AMHwD/KSGhSlMFauBMlCdoo=; b=Qi0N7PRBRIpdoL56rq+SwDzP3++YobpVt+MZfsQKBVu3hlCiljhYWdJyyOHNsvj31TU0FQo6HhcPTNmlz1fb9n+1wWt+bDqZoQ2h1yKyR+HqOpQNvzPsy3p6Ue4Yj00k2KhLd+8cgIxiWCqk8BoSL5B0mT+9Ce1UIRAkCfyVqvQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1569957603792680.0701151611588; Tue, 1 Oct 2019 12:20:03 -0700 (PDT) Received: from localhost ([::1]:46928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFNge-0006V2-4d for importer@patchew.org; Tue, 01 Oct 2019 15:19:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46680) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFNcJ-0004N9-D8 for qemu-devel@nongnu.org; Tue, 01 Oct 2019 15:15:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFNcH-0003IX-98 for qemu-devel@nongnu.org; Tue, 01 Oct 2019 15:15:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59494) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFNcH-0003Hn-3Q for qemu-devel@nongnu.org; Tue, 01 Oct 2019 15:15:21 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EF3883090FC6; Tue, 1 Oct 2019 19:15:19 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.118.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D2A31001B11; Tue, 1 Oct 2019 19:15:16 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 09E2311385FA; Tue, 1 Oct 2019 21:15:15 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 3/7] qapi: Eliminate accidental global frontend state Date: Tue, 1 Oct 2019 21:15:10 +0200 Message-Id: <20191001191514.11208-4-armbru@redhat.com> In-Reply-To: <20191001191514.11208-1-armbru@redhat.com> References: <20191001191514.11208-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 01 Oct 2019 19:15:20 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The frontend can't be run more than once due to its global state. A future commit will want to do that. The only global frontend state remaining is accidental: QAPISchemaParser.__init__()'s parameter previously_included=3D[]. Python evaluates the default once, at definition time. Any modifications to it are visible in subsequent calls. Well-known Python trap. Change the default to None and replace it by the real default in the function body. Use the opportunity to convert previously_included to a set. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi/common.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 5abab44302..9d5c05f6a1 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@ -391,8 +391,9 @@ class QAPIDoc(object): =20 class QAPISchemaParser(object): =20 - def __init__(self, fname, previously_included=3D[], incl_info=3DNone): - previously_included.append(os.path.abspath(fname)) + def __init__(self, fname, previously_included=3DNone, incl_info=3DNone= ): + previously_included =3D previously_included or set() + previously_included.add(os.path.abspath(fname)) =20 try: if sys.version_info[0] >=3D 3: --=20 2.21.0