From nobody Mon Feb 9 12:09:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1569945631; cv=none; d=zoho.com; s=zohoarc; b=ChjrZxzDeQhDzqfPmIdzexCVoH05F0KynND4He/qalHaOiqIyghkNVQZ98lqfd7LLJfkeagnUs1V/RTng29EERSM0fhsqcLKDVc13//zzaMPlFcFAMl6NvbQU7ExyvYV5zLM6csWiWdNzr33a9/mLFMRndtvvpaHBEM3mNmi2mo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569945631; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=2f4hQhSLnIjbo2KGSeXghk4NVGigQ4HZe266C/l1Yr8=; b=du33+as+jMg07QYTUT7XAjEf10OV2Tuns8u/s04Vb7c1j0m/nWribnwMLRn35V2TCFh80SywKqvRXnLhiK/o6UJebF+20v9/q5ZpnN+bQxfkvkNM8tyRYiDLD+DcW00PdIbRdrrS8/Yc7qrunhhl2roR1xHIrcM4WxLCE/XdZxw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1569945631439211.58618975436025; Tue, 1 Oct 2019 09:00:31 -0700 (PDT) Received: from localhost ([::1]:44010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFKZh-0006r6-9O for importer@patchew.org; Tue, 01 Oct 2019 12:00:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49923) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFKT1-00083F-Tm for qemu-devel@nongnu.org; Tue, 01 Oct 2019 11:53:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFKT0-0006Y6-N6 for qemu-devel@nongnu.org; Tue, 01 Oct 2019 11:53:35 -0400 Received: from relay.sw.ru ([185.231.240.75]:38378) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFKT0-0006WV-C9; Tue, 01 Oct 2019 11:53:34 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from ) id 1iFKSy-0004xb-G8; Tue, 01 Oct 2019 18:53:32 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH v4 12/31] ASPEED BMCs: Fix error_append_hint/error_prepend usage Date: Tue, 1 Oct 2019 18:53:00 +0300 Message-Id: <20191001155319.8066-13-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191001155319.8066-1-vsementsov@virtuozzo.com> References: <20191001155319.8066-1-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Vladimir Sementsov-Ogievskiy , Andrew Jeffery , Greg Kurz , qemu-arm@nongnu.org, Joel Stanley , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp =3D=3D &fatal_err (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. This commit (together with its neighbors) was generated by git grep -l 'error_\(append_hint\|prepend\)(errp' | while read f; do \ spatch --sp-file scripts/coccinelle/fix-error-add-info.cocci \ --in-place $f; done and then ./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)" (auto-msg was a file with this commit message) and then by hand, for not maintained changed files: git commit -m ": $(< auto-msg)" Still, for backporting it may be more comfortable to use only the first command and then do one huge commit. Reported-by: Greg Kurz Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/watchdog/wdt_aspeed.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c index 9b93213417..a70d6dee63 100644 --- a/hw/watchdog/wdt_aspeed.c +++ b/hw/watchdog/wdt_aspeed.c @@ -243,6 +243,7 @@ static void aspeed_wdt_timer_expired(void *dev) =20 static void aspeed_wdt_realize(DeviceState *dev, Error **errp) { + ERRP_AUTO_PROPAGATE(); SysBusDevice *sbd =3D SYS_BUS_DEVICE(dev); AspeedWDTState *s =3D ASPEED_WDT(dev); Error *err =3D NULL; --=20 2.21.0