From nobody Wed Nov 12 10:08:41 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.intel.com ARC-Seal: i=1; a=rsa-sha256; t=1569924480; cv=none; d=zoho.com; s=zohoarc; b=bRV25C9ku3ICT9X8rqeBpHfZ55CKSv2C5BE5nSVlBMlmBc2NEZjGx+s5BUB90uzQN28IU3Za0prbtYxn4luCF0Qn9w5Ghfq6AQiMGfncQCTZppFUtFmL/ps8kvU4SZeoKQjQ4htjwvRsHLPKMjfQNGyTNjK7hyrJSxf0Actvcls= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569924480; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Twa+0zhdsL/XTfmoPfAhhRmTC3QJhywjZlnMEp3XbI4=; b=TvPeimCmbkb3gDt/err2IYdPQRQ8j6k+TGDnmsVWHbwfz36D3gwx68gw3r3nf1eV4ycURlPcHAQm6towPscHgPY8K2jtNoX2eqUVsTWsTEK0NZLEqNM8LQl7o28Q8xat4mUEg1kPm9fWcVXdlEmYKPKe+27tXVJrmUJ5bsdbAV8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1569924480237499.61828777808216; Tue, 1 Oct 2019 03:08:00 -0700 (PDT) Received: from localhost ([::1]:39968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFF4Z-0004r6-37 for importer@patchew.org; Tue, 01 Oct 2019 06:07:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41531) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFEzr-0001OA-1p for qemu-devel@nongnu.org; Tue, 01 Oct 2019 06:03:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFEzp-00061z-3x for qemu-devel@nongnu.org; Tue, 01 Oct 2019 06:03:06 -0400 Received: from mga12.intel.com ([192.55.52.136]:10068) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iFEzo-00060e-Rx for qemu-devel@nongnu.org; Tue, 01 Oct 2019 06:03:05 -0400 Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2019 03:03:02 -0700 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga006.jf.intel.com with ESMTP; 01 Oct 2019 03:03:01 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,570,1559545200"; d="scan'208";a="195599673" From: Wei Yang To: quintela@redhat.com, dgilbert@redhat.com Subject: [PATCH 2/3] migration/postcopy: not necessary to do postcopy_ram_incoming_cleanup when state is ADVISE Date: Tue, 1 Oct 2019 18:01:21 +0800 Message-Id: <20191001100122.17730-3-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191001100122.17730-1-richardw.yang@linux.intel.com> References: <20191001100122.17730-1-richardw.yang@linux.intel.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.136 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Wei Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" postcopy_ram_incoming_cleanup() does cleanup for postcopy_ram_incoming_setup(), while the setup happens only after migration enters LISTEN state. This means there is nothing to cleanup when migration is still ADVISE state. Signed-off-by: Wei Yang --- migration/migration.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 5f7e4d15e9..34d5e66f06 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -461,7 +461,6 @@ static void process_incoming_migration_co(void *opaque) * but managed to complete within the precopy period, we can u= se * the normal exit. */ - postcopy_ram_incoming_cleanup(mis); } else if (ret >=3D 0) { /* * Postcopy was started, cleanup should happen at the end of t= he --=20 2.17.1