From nobody Wed Nov 12 10:10:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1569565247; cv=none; d=zoho.com; s=zohoarc; b=fZ8z20bHil8TSDEr9L8wHpZYrVmfDI9C8Dj1B53LzDyrku4LqgVIkqlHus8dkhlxchSu9A7V3lsyPyILAIz3xCv0TkjCmWaOFGIT92maMOluypvKCc/rHeaKbV9YwYWREb7uz4yOlXKpnjXtEgOYe63wl8PQBBBL8hIYKj/D0Iw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569565247; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=DLr7MxM0ezJrjZmyDb+NNu7Hjr76pihjqm4zUmk5l74=; b=ntp7jGyUh5cehayRNtFYQFj7PgkawToKg3sEcZNsGgCZqr6dkttwxJjQ401iqp6J5p33THGJKz+FrqiNoFn0IaPSqqHPm8dqvTiMu5tCGWIWVPA85oWJrFUCcLUxaQM95skp84cEm0D9I3FXapr5xg3X4Ymy/B4ZYPrLG96wCQY= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1569565247677663.9024853541407; Thu, 26 Sep 2019 23:20:47 -0700 (PDT) Received: from localhost ([::1]:46574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDjBj-0000Zy-4Z for importer@patchew.org; Fri, 27 Sep 2019 01:53:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47366) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDj9O-0006kZ-EI for qemu-devel@nongnu.org; Fri, 27 Sep 2019 01:50:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDj9N-0004x8-92 for qemu-devel@nongnu.org; Fri, 27 Sep 2019 01:50:42 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:49017) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDj9M-0004tk-Dq; Fri, 27 Sep 2019 01:50:41 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 46fgrC3Y76z9sNf; Fri, 27 Sep 2019 15:50:35 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1569563435; bh=fWFs/+F2xIiWNCCLaeFDmoBxXkejZr/tBxUs5P1Vqqs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oo5ZJjskSvzjsn0mrk9mHFkzTt2SmdL0U60psx8mciuIqg+h/4w7+KNNLtgbDJR9L FhUiVX871PvSAjqGndlnu0+HnkB8lyIVeHizFG9CganmlJSouqlKbcuMM0YGW6E0Kd YIrqi4xAWMd6gsQd07cOXL1++NWKKSYV2qRMWofY= From: David Gibson To: qemu-devel@nongnu.org, clg@kaod.org, qemu-ppc@nongnu.org Subject: [PATCH v2 01/33] xics: Minor fixes for XICSFabric interface Date: Fri, 27 Sep 2019 15:49:56 +1000 Message-Id: <20190927055028.11493-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190927055028.11493-1-david@gibson.dropbear.id.au> References: <20190927055028.11493-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Riku Voipio , groug@kaod.org, Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , philmd@redhat.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Interface instances should never be directly dereferenced. So, the common practice is to make them incomplete types to make sure no-one does that. XICSFrabric, however, had a dummy type which is less safe. We were also using OBJECT_CHECK() where we should have been using INTERFACE_CHECK(). Signed-off-by: David Gibson Reviewed-by: Greg Kurz --- include/hw/ppc/xics.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h index 64a2c8862a..faa33ae943 100644 --- a/include/hw/ppc/xics.h +++ b/include/hw/ppc/xics.h @@ -147,13 +147,9 @@ struct ICSIRQState { uint8_t flags; }; =20 -struct XICSFabric { - Object parent; -}; - #define TYPE_XICS_FABRIC "xics-fabric" #define XICS_FABRIC(obj) \ - OBJECT_CHECK(XICSFabric, (obj), TYPE_XICS_FABRIC) + INTERFACE_CHECK(XICSFabric, (obj), TYPE_XICS_FABRIC) #define XICS_FABRIC_CLASS(klass) \ OBJECT_CLASS_CHECK(XICSFabricClass, (klass), TYPE_XICS_FABRIC) #define XICS_FABRIC_GET_CLASS(obj) \ --=20 2.21.0