From nobody Wed Nov 12 10:19:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1569565267; cv=none; d=zoho.com; s=zohoarc; b=LsSDK6R1M3sM1jjuwZ04CGcvwC/SPUKP4NH7gOiqkCVlRKRmhWlkrtLeoAOX/tBMJE9tDg38hOhjKG6s76C3sG27GlLzV1JEqHaUBjb6i/DFphfPnbTLw9yT8pYLA2O46V4kI/L9M5yLf9rIrBO62mqoPH4XzCJoUxxfBWmopQA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569565267; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=NP0nCdcwXr+6hwjtC1SkIeF/+RezPa95dX98Q871JeE=; b=KLiQ6NqtA6yQ07zaEmMSdLflT++lVwCtJZLd65CEa6rNilCaHPxXLwmMA8YvlEFZmAfilX5QvpIXt5M0CaKSFcDz1ZzZIvOCXkZ2DSbXakSxxqk9JNa+Wg3F3qnwS/t+KmfOH2MCONYIWQ/nqnfnLqZJhEIM8o/c20aWbkpzq6c= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156956526790818.821985306607644; Thu, 26 Sep 2019 23:21:07 -0700 (PDT) Received: from localhost ([::1]:46610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDjFe-0004uF-Ff for importer@patchew.org; Fri, 27 Sep 2019 01:57:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47612) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDj9V-0006qh-Q3 for qemu-devel@nongnu.org; Fri, 27 Sep 2019 01:50:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDj9S-000539-RY for qemu-devel@nongnu.org; Fri, 27 Sep 2019 01:50:49 -0400 Received: from ozlabs.org ([203.11.71.1]:40913) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDj9S-00050b-D3; Fri, 27 Sep 2019 01:50:46 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 46fgrD6Tzrz9sQw; Fri, 27 Sep 2019 15:50:36 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1569563436; bh=DQmngEMiivkphtE6NW57+oUk3GSNufbe24fbel5QQ2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MAHscsVrWsENst15DP+2RNW88Mni30ri+G4nPe6Z92Jx8lrlaaTgoDsjd+QRXhmMm xQIatFc7HMesg+wv5n0TTN/vFdbHmlP7Vs7Wppmx0AEg3AIxuDAY8K5WlBqr4HzAxM mXTENASXSUZwO83PnCs9JpoBcBl5gghKLO4kM+gQ= From: David Gibson To: qemu-devel@nongnu.org, clg@kaod.org, qemu-ppc@nongnu.org Subject: [PATCH v2 14/33] spapr: Remove unhelpful tracepoints from spapr_irq_free_xics() Date: Fri, 27 Sep 2019 15:50:09 +1000 Message-Id: <20190927055028.11493-15-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190927055028.11493-1-david@gibson.dropbear.id.au> References: <20190927055028.11493-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 203.11.71.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Riku Voipio , groug@kaod.org, Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , philmd@redhat.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" These traces contain some useless information (the always-0 source#) and have no equivalents for XIVE mode. For now just remove them, and we can put back something more sensible if and when we need it. Signed-off-by: David Gibson Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/ppc/spapr_irq.c | 4 ---- hw/ppc/trace-events | 4 ---- 2 files changed, 8 deletions(-) diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c index ec2229d2d1..9919910a86 100644 --- a/hw/ppc/spapr_irq.c +++ b/hw/ppc/spapr_irq.c @@ -140,11 +140,7 @@ static void spapr_irq_free_xics(SpaprMachineState *spa= pr, int irq, int num) int i; =20 if (ics_valid_irq(ics, irq)) { - trace_spapr_irq_free(0, irq, num); for (i =3D srcno; i < srcno + num; ++i) { - if (ics_irq_free(ics, i)) { - trace_spapr_irq_free_warn(0, i); - } memset(&ics->irqs[i], 0, sizeof(ICSIRQState)); } } diff --git a/hw/ppc/trace-events b/hw/ppc/trace-events index 96dad767a1..9ea620f23c 100644 --- a/hw/ppc/trace-events +++ b/hw/ppc/trace-events @@ -13,10 +13,6 @@ spapr_pci_msi_retry(unsigned config_addr, unsigned req_n= um, unsigned max_irqs) " spapr_cas_failed(unsigned long n) "DT diff buffer is too small: %ld bytes" spapr_cas_continue(unsigned long n) "Copy changes to the guest: %ld bytes" =20 -# spapr_irq.c -spapr_irq_free(int src, int irq, int num) "Source#%d, first irq %d, %d irq= s" -spapr_irq_free_warn(int src, int irq) "Source#%d, irq %d is already free" - # spapr_hcall.c spapr_cas_pvr(uint32_t cur_pvr, bool explicit_match, uint32_t new_pvr) "cu= rrent=3D0x%x, explicit_match=3D%u, new=3D0x%x" spapr_h_resize_hpt_prepare(uint64_t flags, uint64_t shift) "flags=3D0x%"PR= Ix64", shift=3D%"PRIu64 --=20 2.21.0