From nobody Wed Apr 2 03:57:36 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1569519535; cv=none; d=zoho.com; s=zohoarc; b=Tr+DEnr2yXeeJDRCDFbThJUkKlsrYN0yH1IiemIAkMoGbqO46b5QfDXrD/OxEBJzizRsw+mGpd/yBv9bPpnwbx0FzcLl01KDguAL5WIm25TeWNrO24rBfVA6680BkPM525aOeM/uTMyNvhyoTyAaj9hlipzLEypsjudeC+euc1M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569519535; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=a931Z/K+dPRWtr6SANaGNktnywcwvFCOBlZIozS8msg=; b=nPhUqTatjgmWzDaMfp1UVlznWEaZGbcr5htpMIaOznobCaP6HYm94HquOZaVEDDiynOQbl+T8NrgrirCTMCNPD+VPZEddS8Ma3HGrCbSJkKCfMRDcx3BYqMHuxhjl/bw9Ov8LQFT+VGWBA9BiuVNhoVPiLoE0q7ZLeTk6ucVMpM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 156951953568842.49550122828373; Thu, 26 Sep 2019 10:38:55 -0700 (PDT) Received: from localhost ([::1]:41760 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDXiz-0006Nw-K1 for importer@patchew.org; Thu, 26 Sep 2019 13:38:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58759) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDXg7-0004GX-SD for qemu-devel@nongnu.org; Thu, 26 Sep 2019 13:35:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDXg6-0002mV-86 for qemu-devel@nongnu.org; Thu, 26 Sep 2019 13:35:43 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iDXg6-0002jG-1C; Thu, 26 Sep 2019 13:35:42 -0400 Received: by mail-wr1-f66.google.com with SMTP id l3so3704914wru.7; Thu, 26 Sep 2019 10:35:41 -0700 (PDT) Received: from x1w.redhat.com (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id b186sm9918980wmd.16.2019.09.26.10.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2019 10:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a931Z/K+dPRWtr6SANaGNktnywcwvFCOBlZIozS8msg=; b=g9VHCzIws7nmj6xArq9oUSTb1ZFb+ahO/PKqn96e+QRLH8jY1Wjm8isgqIFM9FPenA F0hdbjGJxaq4pfLdUPIbLxClAzwUVpIhKzUWFRjmNwsIuLkghx2gvwZign8Xn3Wc0GgA y0mFKGk3QAp1UMQgvf+AfwcIOGbPfKXMFG++9NCokskzotWwRXHsAriJt0gjpSo74JKq 2zMBIzw79NuirWhAoQ7bGYXpZcD35uvyrUUXi9IVfVnwP8wsbQroCYS59wBip0E+wofK LRZlWCWz5S4bTEHi8e8rbwH6sdJn+upMXEFdMxwDjpqU1zdiaxep59/AODuBAdyhYfLz hECw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=a931Z/K+dPRWtr6SANaGNktnywcwvFCOBlZIozS8msg=; b=I9RWhPFfiWpNmTHoeTw2/b0/F+g9h1YJUhxtgbZfs3kmNiut4jxgqROOgu9N9D0wMd Q5isHZBmTGm1eVmImOY2QmJ6AXasmBiMkzZMhQ7ynhyjC1jdwhrNcT2a1wDhwPcPu6Ve NAi/XAI8IZxRCadSoOe3QNmSAm3TYQc+FriSsWKP4Tl6z57J5FcUl5kNJ6KsSAL+ttJC bbed6v2MDWD3UsGssVsJ6oeX2Jnv2EB3U3WnM0A0UKM7xbFUv3DdiSfExI2piOR8b5+f 28rLUY5pEgvmJxGmzzT0wwedIvuwV8tPApOIFoHlt6isGETZ8U7TC6eoD1BKCmbDUbUs fdLg== X-Gm-Message-State: APjAAAWyU4pRa8f+n8m4DSXpnH5rLZJjY8K5XtNb4a0q05jDFyvJLJnQ OLMtjSvtVXaMjibsPWkSLlYxlFze8iI= X-Google-Smtp-Source: APXvYqzsvQYH2fg0d40Ykkaf9nxe4iXOzMU8dl1PTZSycPv5dp8ouAIrjdPQj1zj8pChZLrUDyP0Rg== X-Received: by 2002:a5d:4f0d:: with SMTP id c13mr4010196wru.317.1569519279988; Thu, 26 Sep 2019 10:34:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 03/19] hw/arm/bcm2835_peripherals: Name various address spaces Date: Thu, 26 Sep 2019 19:34:11 +0200 Message-Id: <20190926173428.10713-4-f4bug@amsat.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190926173428.10713-1-f4bug@amsat.org> References: <20190926173428.10713-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.66 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Zolt=C3=A1n=20Baldaszti?= , Laurent Bonnans , Esteban Bosse , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Andrew Baumann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-arm@nongnu.org, Clement Deschamps , Cleber Rosa , Paolo Bonzini , Cheng Xiang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pekka Enberg , Guenter Roeck , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Various address spaces from the BCM2835 are reported as 'anonymous' in memory tree: (qemu) info mtree address-space: anonymous 0000000000000000-000000000000008f (prio 0, i/o): bcm2835-mbox 0000000000000010-000000000000001f (prio 0, i/o): bcm2835-fb 0000000000000080-000000000000008f (prio 0, i/o): bcm2835-property address-space: anonymous 0000000000000000-00000000ffffffff (prio 0, i/o): bcm2835-gpu 0000000000000000-000000003fffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 0000000040000000-000000007fffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 000000007e000000-000000007effffff (prio 1, i/o): alias bcm2835-periph= erals @bcm2835-peripherals 0000000000000000-0000000000ffffff 0000000080000000-00000000bfffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 00000000c0000000-00000000ffffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff [...] Since the address_space_init() function takes a 'name' argument, set it to correctly describe each address space: (qemu) info mtree address-space: bcm2835-mbox-memory 0000000000000000-000000000000008f (prio 0, i/o): bcm2835-mbox 0000000000000010-000000000000001f (prio 0, i/o): bcm2835-fb 0000000000000080-000000000000008f (prio 0, i/o): bcm2835-property address-space: bcm2835-fb-memory 0000000000000000-00000000ffffffff (prio 0, i/o): bcm2835-gpu 0000000000000000-000000003fffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 0000000040000000-000000007fffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 000000007e000000-000000007effffff (prio 1, i/o): alias bcm2835-periph= erals @bcm2835-peripherals 0000000000000000-0000000000ffffff 0000000080000000-00000000bfffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 00000000c0000000-00000000ffffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff address-space: bcm2835-property-memory 0000000000000000-00000000ffffffff (prio 0, i/o): bcm2835-gpu 0000000000000000-000000003fffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 0000000040000000-000000007fffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 000000007e000000-000000007effffff (prio 1, i/o): alias bcm2835-periph= erals @bcm2835-peripherals 0000000000000000-0000000000ffffff 0000000080000000-00000000bfffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 00000000c0000000-00000000ffffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff address-space: bcm2835-dma-memory 0000000000000000-00000000ffffffff (prio 0, i/o): bcm2835-gpu 0000000000000000-000000003fffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 0000000040000000-000000007fffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 000000007e000000-000000007effffff (prio 1, i/o): alias bcm2835-periph= erals @bcm2835-peripherals 0000000000000000-0000000000ffffff 0000000080000000-00000000bfffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff 00000000c0000000-00000000ffffffff (prio 0, i/o): alias bcm2835-gpu-ra= m-alias[*] @ram 0000000000000000-000000003fffffff Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Alistair Francis Reviewed-by: Cleber Rosa --- hw/display/bcm2835_fb.c | 2 +- hw/dma/bcm2835_dma.c | 2 +- hw/misc/bcm2835_mbox.c | 2 +- hw/misc/bcm2835_property.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c index 8f856878cd..85aaa54330 100644 --- a/hw/display/bcm2835_fb.c +++ b/hw/display/bcm2835_fb.c @@ -425,7 +425,7 @@ static void bcm2835_fb_realize(DeviceState *dev, Error = **errp) s->initial_config.base =3D s->vcram_base + BCM2835_FB_OFFSET; =20 s->dma_mr =3D MEMORY_REGION(obj); - address_space_init(&s->dma_as, s->dma_mr, NULL); + address_space_init(&s->dma_as, s->dma_mr, TYPE_BCM2835_FB "-memory"); =20 bcm2835_fb_reset(dev); =20 diff --git a/hw/dma/bcm2835_dma.c b/hw/dma/bcm2835_dma.c index 6acc2b644e..1e458d7fba 100644 --- a/hw/dma/bcm2835_dma.c +++ b/hw/dma/bcm2835_dma.c @@ -383,7 +383,7 @@ static void bcm2835_dma_realize(DeviceState *dev, Error= **errp) } =20 s->dma_mr =3D MEMORY_REGION(obj); - address_space_init(&s->dma_as, s->dma_mr, NULL); + address_space_init(&s->dma_as, s->dma_mr, TYPE_BCM2835_DMA "-memory"); =20 bcm2835_dma_reset(dev); } diff --git a/hw/misc/bcm2835_mbox.c b/hw/misc/bcm2835_mbox.c index 7690b9afaf..77285624c9 100644 --- a/hw/misc/bcm2835_mbox.c +++ b/hw/misc/bcm2835_mbox.c @@ -311,7 +311,7 @@ static void bcm2835_mbox_realize(DeviceState *dev, Erro= r **errp) } =20 s->mbox_mr =3D MEMORY_REGION(obj); - address_space_init(&s->mbox_as, s->mbox_mr, NULL); + address_space_init(&s->mbox_as, s->mbox_mr, TYPE_BCM2835_MBOX "-memory= "); bcm2835_mbox_reset(dev); } =20 diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c index 0a1a3eb5d9..43a5465c5d 100644 --- a/hw/misc/bcm2835_property.c +++ b/hw/misc/bcm2835_property.c @@ -407,7 +407,7 @@ static void bcm2835_property_realize(DeviceState *dev, = Error **errp) } =20 s->dma_mr =3D MEMORY_REGION(obj); - address_space_init(&s->dma_as, s->dma_mr, NULL); + address_space_init(&s->dma_as, s->dma_mr, TYPE_BCM2835_PROPERTY "-memo= ry"); =20 /* TODO: connect to MAC address of USB NIC device, once we emulate it = */ qemu_macaddr_default_if_unset(&s->macaddr); --=20 2.20.1