From nobody Tue Feb 10 02:43:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1569394246; cv=none; d=zoho.com; s=zohoarc; b=JuV8e+bwrJj37bJw1wYfMz2jaeT4fjnjiTePnNGQ2cV+jhW1ao/CJ7Fd+lJ5rMLAFHc1VFhJbf3GE81k0fCetf7lPvCcuSjRwLinFTkUkVQyqL7RiMgXhy8GIwOOBBuQGjxzKTcR/C4WYD8t21p/j/VGf66OAr3JtgaDKED3eEY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569394246; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=bybMP8E5hcTGMLu2JewXwjBOGYK7BiZzcxg8dmKIh9Q=; b=oiPWgguEXTMyD6fgqQHSSJpDSYluqVU7kauIBS3Oz0S0K0T3U/+XPam6zQGlUe3yghciRDQ+lT0crbt0USqssTQE3cCvPXMaBjO/UvsyCXePMcJ+FbuBgEbAJbF8yi/K8gpsWAO7P1AkHPJ44Rz5my++4/jjjhLHogFuiuRw6SE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1569394245881906.6071918916341; Tue, 24 Sep 2019 23:50:45 -0700 (PDT) Received: from localhost ([::1]:45994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD18G-0002Fh-OO for importer@patchew.org; Wed, 25 Sep 2019 02:50:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38528) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iD13g-0008H0-PH for qemu-devel@nongnu.org; Wed, 25 Sep 2019 02:45:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iD13f-0003Rg-El for qemu-devel@nongnu.org; Wed, 25 Sep 2019 02:45:52 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:60149 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iD13e-0003Ox-W0; Wed, 25 Sep 2019 02:45:51 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 46dT8m58Lsz9sPc; Wed, 25 Sep 2019 16:45:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1569393944; bh=YoZ6nDBhhOntdGlFmN4sT1V55L3hT1F130IYLZSQyK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OmTOq1hGfCdnWA/LtKZHz9ejWuZ5UxQQRETwGrOHEdS7RHmc53aA4dGNEPTD9bUsC Me0ErMku2l/SOrBwdXpXjCizhWphn8w/envuDL81ANGnyyRYGMm86jhvcwGuobifO6 VKlzdnar4qi7LVJzRJLy8M7FunLzVRG7E/KMuS3o= From: David Gibson To: qemu-ppc@nongnu.org, clg@kaod.org, qemu-devel@nongnu.org Subject: [PATCH 01/20] xics: Use incomplete type for XICSFabric Date: Wed, 25 Sep 2019 16:45:15 +1000 Message-Id: <20190925064534.19155-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190925064534.19155-1-david@gibson.dropbear.id.au> References: <20190925064534.19155-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , Riku Voipio , groug@kaod.org, Laurent Vivier , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , philmd@redhat.com, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Interface instances should never be directly dereferenced. So, the common practice is to make them incomplete types to make sure no-one does that. XICSFrabric, however, had a dummy type which is less safe. Signed-off-by: David Gibson Reviewed-by: Greg Kurz --- include/hw/ppc/xics.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h index 64a2c8862a..1ae34ce9cd 100644 --- a/include/hw/ppc/xics.h +++ b/include/hw/ppc/xics.h @@ -147,9 +147,7 @@ struct ICSIRQState { uint8_t flags; }; =20 -struct XICSFabric { - Object parent; -}; +typedef struct XICSFabric XICSFabric; =20 #define TYPE_XICS_FABRIC "xics-fabric" #define XICS_FABRIC(obj) \ --=20 2.21.0