From nobody Sun Feb 8 21:28:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1569357997; cv=none; d=zoho.com; s=zohoarc; b=CBf+LjCddzi8VQra85xn+xln5UEJJ6HjP0XaqahhWf0PmCMNNa/Bd10xpLiQonD4EItErUEkp5qQM3ybFVRYyHXm53/iXla8ALrPU5jw17TNv7ReFq57XMSMuThqhXmW6XM1NjwvYo9rql7Uzj0l1v9bfKCtQLIUT6dZjv9S02w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569357997; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=WFNEvsmAxYMmZ1KBkmyfzHxiHAYffN7ap8he+rHOJi0=; b=en5NqvaTWMPGirhksVhXg1QjtiKgcwllM+AjWbk3j3mRLjS5mKTJqypOyyS/lqjhsYNtlYW0/8fJj6JYvcKJ0wy2/GNtEQRY41IyW11kpN5Bt505v9y9brZzfh/z0lgctyPlH1wvI9OFgxzd9SOQ9j46m+e+KLjhy15Yn/nbPj0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1569357997045862.327652182387; Tue, 24 Sep 2019 13:46:37 -0700 (PDT) Received: from localhost ([::1]:50956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCrhj-0006Hq-JR for importer@patchew.org; Tue, 24 Sep 2019 16:46:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44097) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCr8P-0000vJ-Rl for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCr8O-00032a-DA for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:05 -0400 Received: from relay.sw.ru ([185.231.240.75]:38184) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCr8N-0002vB-Ug for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:04 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from ) id 1iCr8C-0001Mk-HJ; Tue, 24 Sep 2019 23:09:52 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH v3 25/25] PVRDMA: Fix error_append_hint usage Date: Tue, 24 Sep 2019 23:09:02 +0300 Message-Id: <20190924200902.4703-26-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190924200902.4703-1-vsementsov@virtuozzo.com> References: <20190924200902.4703-1-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vsementsov@virtuozzo.com, Greg Kurz , Yuval Shaia Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro. Otherwise hint will not be appended in case of errp =3D=3D &fatal_err (program will exit before error_append_hint() call). Fix such cases. This commit (together with its neighbors) was generated by git grep -l 'error_append_hint(errp' | while read f; do \ spatch --sp-file scripts/coccinelle/fix-error_append_hint-usage.cocci \ --in-place $f; done and then ./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)" (auto-msg was a file with this commit message) Still, for backporting it may be more comfortable to use only the first command and then do one huge commit. Reported-by: Greg Kurz Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/rdma/vmw/pvrdma_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 3e36e13013..3cc02311bf 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++ b/hw/rdma/vmw/pvrdma_main.c @@ -592,6 +592,7 @@ static void pvrdma_shutdown_notifier(Notifier *n, void = *opaque) =20 static void pvrdma_realize(PCIDevice *pdev, Error **errp) { + ERRP_FUNCTION_BEGIN(); int rc =3D 0; PVRDMADev *dev =3D PVRDMA_DEV(pdev); Object *memdev_root; --=20 2.21.0