From nobody Mon Feb 9 01:20:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1569356491; cv=none; d=zoho.com; s=zohoarc; b=hafIfNb5b8wAW8oPmT+u5gtKaqYXMX+cyvmhS6xAwern6OVhul4KfwnUCwroOgoejFH1UDe+fzgqgLTRZDLq+w/q90LPcSHNFJw5b1hXhIv26Uwlo9W5UIYrqC6r7w2pPhYfp5rTgp8+YxTjN+duTeldkPh4+hGxT+DBsl1hMcI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569356491; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=7EhhnxVuqjb7QOcn9lzw14gxX6XfMrFBVUUIKAtV6o4=; b=MHYivuvENtTeMZdppsOsAKzr7crI4cQGD8CkHKW2Pckr6eGgGFVdydtzNDxCYla/Y1barhVe5nrHxNVF5TvXiQ+MavJ+JcVDLs1Qxwvu6as81wU3bItFRC+uweTzgT0E8SHayfLY9Yg+OHQnTxBKztIAkhBLf6lG6PJV6tUedJk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1569356491795957.5388537100204; Tue, 24 Sep 2019 13:21:31 -0700 (PDT) Received: from localhost ([::1]:50682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCrJS-0004li-7k for importer@patchew.org; Tue, 24 Sep 2019 16:21:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44057) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCr8O-0000tc-RP for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCr8M-00031G-SA for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:04 -0400 Received: from relay.sw.ru ([185.231.240.75]:38146) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCr8M-0002u8-Ef for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:02 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from ) id 1iCr8B-0001Mk-2H; Tue, 24 Sep 2019 23:09:51 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH v3 19/25] chardev: Fix error_append_hint usage Date: Tue, 24 Sep 2019 23:08:56 +0300 Message-Id: <20190924200902.4703-20-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190924200902.4703-1-vsementsov@virtuozzo.com> References: <20190924200902.4703-1-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , vsementsov@virtuozzo.com, Greg Kurz , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro. Otherwise hint will not be appended in case of errp =3D=3D &fatal_err (program will exit before error_append_hint() call). Fix such cases. This commit (together with its neighbors) was generated by git grep -l 'error_append_hint(errp' | while read f; do \ spatch --sp-file scripts/coccinelle/fix-error_append_hint-usage.cocci \ --in-place $f; done and then ./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)" (auto-msg was a file with this commit message) Still, for backporting it may be more comfortable to use only the first command and then do one huge commit. Reported-by: Greg Kurz Signed-off-by: Vladimir Sementsov-Ogievskiy --- chardev/spice.c | 1 + 1 file changed, 1 insertion(+) diff --git a/chardev/spice.c b/chardev/spice.c index 241e2b7770..1421c85464 100644 --- a/chardev/spice.c +++ b/chardev/spice.c @@ -267,6 +267,7 @@ static void qemu_chr_open_spice_vmc(Chardev *chr, bool *be_opened, Error **errp) { + ERRP_FUNCTION_BEGIN(); ChardevSpiceChannel *spicevmc =3D backend->u.spicevmc.data; const char *type =3D spicevmc->type; const char **psubtype =3D spice_server_char_device_recognized_subtypes= (); --=20 2.21.0