From nobody Mon Feb 9 01:20:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1569357514; cv=none; d=zoho.com; s=zohoarc; b=Ql/K6APcggwX6x23DsJ7M3lHCtSc2SMVT0rhTyuBoxNhqYcBRe2t8kqaw8Zk28QUAnD5bv2s3x1ZNsBiHhGaZ5c5+MJ6NBn5GRe9s05NCoiSLy6aAV9qw0+uvBqtAQ/pzyfscKd196otcVmnaibHpsb/2jGGPrcCRHjCU250F/A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569357514; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=4Fd5IHzJaUowSVkNqmZObjFZjj6J8n4Qi1biqH3JjBU=; b=lHZ1oLtmO2nOZd+bhnq48g+6g+cJB642CmGvD+JZAdxmjDXI1wDJQaSy+GbEA/NXoNFxUFXAsVNKLKrw0tSH6PFQ83utQsJVyuAH0ZpcvENaQ++r9OKRul4+AYtCTskRUkG0I21rTQy6IuPRSX5H0yasq6z6guTrKTtHdUb6+qs= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15693575146929.769545617052472; Tue, 24 Sep 2019 13:38:34 -0700 (PDT) Received: from localhost ([::1]:50856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCrZv-000759-1Q for importer@patchew.org; Tue, 24 Sep 2019 16:38:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44028) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCr8O-0000sd-2X for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCr8M-00030c-1o for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:03 -0400 Received: from relay.sw.ru ([185.231.240.75]:38112) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCr8L-0002t7-KO for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:01 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from ) id 1iCr89-0001Mk-PQ; Tue, 24 Sep 2019 23:09:49 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH v3 15/25] VFIO: Fix error_append_hint usage Date: Tue, 24 Sep 2019 23:08:52 +0300 Message-Id: <20190924200902.4703-16-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190924200902.4703-1-vsementsov@virtuozzo.com> References: <20190924200902.4703-1-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Williamson , vsementsov@virtuozzo.com, Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro. Otherwise hint will not be appended in case of errp =3D=3D &fatal_err (program will exit before error_append_hint() call). Fix such cases. This commit (together with its neighbors) was generated by git grep -l 'error_append_hint(errp' | while read f; do \ spatch --sp-file scripts/coccinelle/fix-error_append_hint-usage.cocci \ --in-place $f; done and then ./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)" (auto-msg was a file with this commit message) Still, for backporting it may be more comfortable to use only the first command and then do one huge commit. Reported-by: Greg Kurz Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/vfio/common.c | 2 ++ hw/vfio/pci.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 3e03c495d8..d08276b1e6 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -1437,6 +1437,7 @@ static void vfio_disconnect_container(VFIOGroup *grou= p) =20 VFIOGroup *vfio_get_group(int groupid, AddressSpace *as, Error **errp) { + ERRP_FUNCTION_BEGIN(); VFIOGroup *group; char path[32]; struct vfio_group_status status =3D { .argsz =3D sizeof(status) }; @@ -1526,6 +1527,7 @@ void vfio_put_group(VFIOGroup *group) int vfio_get_device(VFIOGroup *group, const char *name, VFIODevice *vbasedev, Error **errp) { + ERRP_FUNCTION_BEGIN(); struct vfio_device_info dev_info =3D { .argsz =3D sizeof(dev_info) }; int ret, fd; =20 diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index c5e6fe61cb..57208c7075 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2469,6 +2469,7 @@ int vfio_populate_vga(VFIOPCIDevice *vdev, Error **er= rp) =20 static void vfio_populate_device(VFIOPCIDevice *vdev, Error **errp) { + ERRP_FUNCTION_BEGIN(); VFIODevice *vbasedev =3D &vdev->vbasedev; struct vfio_region_info *reg_info; struct vfio_irq_info irq_info =3D { .argsz =3D sizeof(irq_info) }; @@ -2700,6 +2701,7 @@ static void vfio_unregister_req_notifier(VFIOPCIDevic= e *vdev) =20 static void vfio_realize(PCIDevice *pdev, Error **errp) { + ERRP_FUNCTION_BEGIN(); VFIOPCIDevice *vdev =3D PCI_VFIO(pdev); VFIODevice *vbasedev_iter; VFIOGroup *group; --=20 2.21.0