From nobody Sun Feb 8 20:12:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1569357181; cv=none; d=zoho.com; s=zohoarc; b=exECYVKDKYL0RVGyNwJ4f9B+wz7RwTeHLaGmv8bvbIM2l1RPUi2ntpaIXkLn4n2tFoc6SalhYdS3apY67YPtRxgpLd+R99WzbGp2X9YSl84VMoBJfvVPjK3PLhRi1g2+ZubRER3v2hEPdCa9HyE3H6CvSCU6etbOugVLCj0rpTg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569357181; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=vKJB7Dr48XQLeHmExCu5EbfbFcgColVJk4x26felkxI=; b=Jlrfz1VLdviznotHwlebT2QorAzXY3JRgMLs38a/f7TDti1px1toljZlznn6NyL5/xQIE4m7S2BtBW5UO8cE2pvQrDK6SU+Qqut5jT71bBdc125PMFQrPO0fZTcarUlZPFu7ucHbYRqJeEm7IYzo2iOVoeVAVMCM/Tpo7UIUZ0M= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1569357181040338.6528342158632; Tue, 24 Sep 2019 13:33:01 -0700 (PDT) Received: from localhost ([::1]:50788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCrUY-00006F-SV for importer@patchew.org; Tue, 24 Sep 2019 16:32:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43980) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCr8M-0000qB-J4 for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCr8K-0002zi-PR for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:02 -0400 Received: from relay.sw.ru ([185.231.240.75]:38094) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCr8K-0002sb-Hp for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:00 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from ) id 1iCr89-0001Mk-70; Tue, 24 Sep 2019 23:09:49 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH v3 13/25] SCSI: Fix error_append_hint usage Date: Tue, 24 Sep 2019 23:08:50 +0300 Message-Id: <20190924200902.4703-14-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190924200902.4703-1-vsementsov@virtuozzo.com> References: <20190924200902.4703-1-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Paolo Bonzini , vsementsov@virtuozzo.com, Greg Kurz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro. Otherwise hint will not be appended in case of errp =3D=3D &fatal_err (program will exit before error_append_hint() call). Fix such cases. This commit (together with its neighbors) was generated by git grep -l 'error_append_hint(errp' | while read f; do \ spatch --sp-file scripts/coccinelle/fix-error_append_hint-usage.cocci \ --in-place $f; done and then ./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)" (auto-msg was a file with this commit message) Still, for backporting it may be more comfortable to use only the first command and then do one huge commit. Reported-by: Greg Kurz Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/scsi/scsi-disk.c | 1 + hw/scsi/scsi-generic.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 915641a0f1..72ac308b6c 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -2597,6 +2597,7 @@ static int get_device_type(SCSIDiskState *s) =20 static void scsi_block_realize(SCSIDevice *dev, Error **errp) { + ERRP_FUNCTION_BEGIN(); SCSIDiskState *s =3D DO_UPCAST(SCSIDiskState, qdev, dev); AioContext *ctx; int sg_version; diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index e7798ebcd0..e955f4e0a5 100644 --- a/hw/scsi/scsi-generic.c +++ b/hw/scsi/scsi-generic.c @@ -653,6 +653,7 @@ static void scsi_generic_reset(DeviceState *dev) =20 static void scsi_generic_realize(SCSIDevice *s, Error **errp) { + ERRP_FUNCTION_BEGIN(); int rc; int sg_version; struct sg_scsi_id scsiid; --=20 2.21.0