From nobody Mon Feb 9 02:51:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=1; a=rsa-sha256; t=1569356382; cv=none; d=zoho.com; s=zohoarc; b=kqiP1LxGW+F+tZs/mxLi8oAMJq27p7wm+cuk76vRNuxXQFBnNc5XUZ43MdpXQDUTrk000UiI4bVAoXt/JA+iviQMXtodJjH8ob5NSopLaHAgVppr0ki6NNZBBk3LYLfIxmybdj9KWi2ANFFTarzBgOorGPba/ypqwUDjbLyNc7Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569356382; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=4t+3f+yMg6u6AWtAmNGwVMv8Sn47PBMZRRPsODQf4bY=; b=Cjng1oK6LtuB16yFDeU4ZotDgrpn3fMU/t7JhNXQ9b9PoyqQsb4UrmIifgekBTrUv7AUpZO5q16tJLdtv/JqWcGQkpYvn7BIXCyfqXVAvH79LfP6hU1mKo5XBMf6N/9z8IFhb4IamVmOIO46TawcLHUaYFjYY6c/xnGk9l7GTUQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1569356382002252.47714697676201; Tue, 24 Sep 2019 13:19:42 -0700 (PDT) Received: from localhost ([::1]:50656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCrHc-0002Xg-Ob for importer@patchew.org; Tue, 24 Sep 2019 16:19:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43970) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCr8M-0000pP-0d for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCr8K-0002zW-Km for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:01 -0400 Received: from relay.sw.ru ([185.231.240.75]:38088) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCr8K-0002sZ-BP for qemu-devel@nongnu.org; Tue, 24 Sep 2019 16:10:00 -0400 Received: from [10.94.3.0] (helo=kvm.qa.sw.ru) by relay.sw.ru with esmtp (Exim 4.92.2) (envelope-from ) id 1iCr88-0001Mk-Th; Tue, 24 Sep 2019 23:09:49 +0300 From: Vladimir Sementsov-Ogievskiy To: qemu-devel@nongnu.org Subject: [PATCH v3 12/25] PCI: Fix error_append_hint usage Date: Tue, 24 Sep 2019 23:08:49 +0300 Message-Id: <20190924200902.4703-13-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190924200902.4703-1-vsementsov@virtuozzo.com> References: <20190924200902.4703-1-vsementsov@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 185.231.240.75 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vsementsov@virtuozzo.com, Greg Kurz , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" If we want append hint to errp, we must use ERRP_FUNCTION_BEGIN macro. Otherwise hint will not be appended in case of errp =3D=3D &fatal_err (program will exit before error_append_hint() call). Fix such cases. This commit (together with its neighbors) was generated by git grep -l 'error_append_hint(errp' | while read f; do \ spatch --sp-file scripts/coccinelle/fix-error_append_hint-usage.cocci \ --in-place $f; done and then ./python/commit-per-subsystem.py MAINTAINERS "$(< auto-msg)" (auto-msg was a file with this commit message) Still, for backporting it may be more comfortable to use only the first command and then do one huge commit. Reported-by: Greg Kurz Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/pci-bridge/pcie_root_port.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-bridge/pcie_root_port.c b/hw/pci-bridge/pcie_root_port.c index 012c2cb12c..a0aacad711 100644 --- a/hw/pci-bridge/pcie_root_port.c +++ b/hw/pci-bridge/pcie_root_port.c @@ -60,6 +60,7 @@ static void rp_reset(DeviceState *qdev) =20 static void rp_realize(PCIDevice *d, Error **errp) { + ERRP_FUNCTION_BEGIN(); PCIEPort *p =3D PCIE_PORT(d); PCIESlot *s =3D PCIE_SLOT(d); PCIDeviceClass *dc =3D PCI_DEVICE_GET_CLASS(d); --=20 2.21.0