From nobody Mon Feb 9 12:25:41 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1569331076; cv=none; d=zoho.com; s=zohoarc; b=dbzSY6aH0Wl+Wl6sa3F2a+uctdYjQfGr6KO/7l62yPh+j9/wQzrsAKbqL5K0FyqhMoHjaOoQNh5ABszsxI19sLVi47N+BCs/0tjN5hRBELUL5bzUDgMwc3zdPpu4z6qXbba64v0nU0pFt3rGJMMB636u/1K8UBYb9U84v3lg/uQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569331076; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=7qwg9ehAj9BVKRSSC9IKXAPPuDVmKsNVZCiKhTy8o48=; b=Ua8TRAgIU3ZQUQN27TlNfEu3vf2HwvCAmnPSMEwNeTH4IOiPS7qMkJ//jHgjecHY0P4EHcCCQ91BNZ3fmnJE1eJWecIAqLArtbSM7wotihrZUJrf5KVdQQ6E/+qPQRXo5xqiT3l+x+XpO4B0Wb60OmLdaEGOKDNwXNNpqC6I8iw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 156933107631857.07748971702915; Tue, 24 Sep 2019 06:17:56 -0700 (PDT) Received: from localhost ([::1]:45544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCkhW-0004Sh-8L for importer@patchew.org; Tue, 24 Sep 2019 09:17:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51566) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCk6b-0006AF-4B for qemu-devel@nongnu.org; Tue, 24 Sep 2019 08:39:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCk6Z-000207-VW for qemu-devel@nongnu.org; Tue, 24 Sep 2019 08:39:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42256) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCk6X-0001ww-Ar; Tue, 24 Sep 2019 08:39:41 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A06913A17F; Tue, 24 Sep 2019 12:39:40 +0000 (UTC) Received: from blue.redhat.com (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3FB9F60C63; Tue, 24 Sep 2019 12:39:40 +0000 (UTC) From: Eric Blake To: qemu-devel@nongnu.org Subject: [PULL 4/4] tests: Use iothreads during iotest 223 Date: Tue, 24 Sep 2019 07:39:33 -0500 Message-Id: <20190924123933.10607-5-eblake@redhat.com> In-Reply-To: <20190924123933.10607-1-eblake@redhat.com> References: <20190924123933.10607-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 24 Sep 2019 12:39:40 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "open list:Block layer core" , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Doing so catches the bugs we just fixed with NBD not properly using correct contexts. Signed-off-by: Eric Blake Message-Id: <20190920220729.31801-1-eblake@redhat.com> --- tests/qemu-iotests/223 | 6 ++++-- tests/qemu-iotests/223.out | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/223 b/tests/qemu-iotests/223 index cc48e78ea7dc..2ba3d8124b4f 100755 --- a/tests/qemu-iotests/223 +++ b/tests/qemu-iotests/223 @@ -2,7 +2,7 @@ # # Test reading dirty bitmap over NBD # -# Copyright (C) 2018 Red Hat, Inc. +# Copyright (C) 2018-2019 Red Hat, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -109,7 +109,7 @@ echo echo "=3D=3D=3D End dirty bitmaps, and start serving image over NBD =3D=3D= =3D" echo -_launch_qemu 2> >(_filter_nbd) +_launch_qemu -object iothread,id=3Dio0 2> >(_filter_nbd) # Intentionally provoke some errors as well, to check error handling silent=3D @@ -117,6 +117,8 @@ _send_qemu_cmd $QEMU_HANDLE '{"execute":"qmp_capabiliti= es"}' "return" _send_qemu_cmd $QEMU_HANDLE '{"execute":"blockdev-add", "arguments":{"driver":"qcow2", "node-name":"n", "file":{"driver":"file", "filename":"'"$TEST_IMG"'"}}}' "return" +_send_qemu_cmd $QEMU_HANDLE '{"execute":"x-blockdev-set-iothread", + "arguments":{"node-name":"n", "iothread":"io0"}}' "return" _send_qemu_cmd $QEMU_HANDLE '{"execute":"block-dirty-bitmap-disable", "arguments":{"node":"n", "name":"b"}}' "return" _send_qemu_cmd $QEMU_HANDLE '{"execute":"nbd-server-add", diff --git a/tests/qemu-iotests/223.out b/tests/qemu-iotests/223.out index 5d00398c11cb..23b34fcd202e 100644 --- a/tests/qemu-iotests/223.out +++ b/tests/qemu-iotests/223.out @@ -27,6 +27,7 @@ wrote 2097152/2097152 bytes at offset 2097152 {"return": {}} {"return": {}} {"return": {}} +{"return": {}} {"error": {"class": "GenericError", "desc": "NBD server not running"}} {"return": {}} {"error": {"class": "GenericError", "desc": "NBD server already running"}} --=20 2.21.0