From nobody Mon Feb 9 08:57:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1569330809; cv=none; d=zoho.com; s=zohoarc; b=UOS7jNYGB/YR2Bmy0eoJXhcE+a3k9//3ysb/Qa5b1GyJm+xC9CRa75C6H/jKlM5KRQZizmyURsIxvFnS2Ko7qYcBbp0DFQk2voZpZHVriTDK4PGoc005a0z6vL9yfAxuVmXVnISMIk7zsERc/QLz5fDkanrcoNAOV4POA/1Oq5k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569330809; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=GnkZVcIodJ+7WdChzzv0oy2gg2YsWCHqVzxqUD5SQS4=; b=as3rgs0hSHnUjfAx2rxiXKJdG57QQzpJ63iEcSrX/Gt17Wm7qC+zGzdA6zOO6YhTBs7191vEYgwFImyq1HFHoEhMvrO15Q3rk5S037yFrYzSt4qw44uxr6ynfE9iT9OlTJaQ8m3Zqoy//RYR6JFo7BGOl1cS2xTvA0ZfNB8CJKU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1569330809340270.4369507163733; Tue, 24 Sep 2019 06:13:29 -0700 (PDT) Received: from localhost ([::1]:45498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCkd8-0000ln-0W for importer@patchew.org; Tue, 24 Sep 2019 09:13:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51552) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iCk6a-00068o-3O for qemu-devel@nongnu.org; Tue, 24 Sep 2019 08:39:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iCk6Y-0001zY-OQ for qemu-devel@nongnu.org; Tue, 24 Sep 2019 08:39:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58918) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iCk6W-0001vh-3U; Tue, 24 Sep 2019 08:39:40 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6274930B2502; Tue, 24 Sep 2019 12:39:39 +0000 (UTC) Received: from blue.redhat.com (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTP id 979BD60BFB; Tue, 24 Sep 2019 12:39:36 +0000 (UTC) From: Eric Blake To: qemu-devel@nongnu.org Subject: [PULL 2/4] nbd/server: attach client channel to the export's AioContext Date: Tue, 24 Sep 2019 07:39:31 -0500 Message-Id: <20190924123933.10607-3-eblake@redhat.com> In-Reply-To: <20190924123933.10607-1-eblake@redhat.com> References: <20190924123933.10607-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 24 Sep 2019 12:39:39 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:Network Block Dev..." , Sergio Lopez Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Sergio Lopez On creation, the export's AioContext is set to the same one as the BlockBackend, while the AioContext in the client QIOChannel is left untouched. As a result, when using data-plane, nbd_client_receive_next_request() schedules coroutines in the IOThread AioContext, while the client's QIOChannel is serviced from the main_loop, potentially triggering the assertion at qio_channel_restart_[read|write]. To fix this, as soon we have the export corresponding to the client, we call qio_channel_attach_aio_context() to attach the QIOChannel context to the export's AioContext. This matches with the logic at blk_aio_attached(). RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=3D1748253 Signed-off-by: Sergio Lopez Message-Id: <20190912110032.26395-1-slp@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Eric Blake --- nbd/server.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/nbd/server.c b/nbd/server.c index 28c3c8be854c..31d624e146cb 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -1297,6 +1297,11 @@ static coroutine_fn int nbd_negotiate(NBDClient *cli= ent, Error **errp) return ret; } + /* Attach the channel to the same AioContext as the export */ + if (client->exp && client->exp->ctx) { + qio_channel_attach_aio_context(client->ioc, client->exp->ctx); + } + assert(!client->optlen); trace_nbd_negotiate_success(); --=20 2.21.0