From nobody Mon Feb 9 12:09:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568994745; cv=none; d=zoho.com; s=zohoarc; b=E9slSmMU1Dxu0bHzdOgitVcYhwvMpvnvqss7vflNxWqL3DR6yMKe20/C1o4g04IORTeH6bJpvtRACam1TbthiHgXP8nPsuGiYposCguGA8rhmVLlhEbXsIJQWXttn154wdsb0J5CkB97buUEv7TAc83fu9sGU4F20wKJrpZlhQk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568994745; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=BjllaEb/dnh7P7wCSgs1eijsabAuM1AeOBYvLIVreEU=; b=lvgBir9qJX/wEkWg9lCvA6KawTSWbRysvT1tAnzAS2wXGYE8Dq9T7UN9AeJ3nzHwOzTRvRIQxkEClXEbY37M0O91fNgz05zpac7oxX00VGySLVykNYUndD1I2XUCh/JBLhjrpkhkd7R8kRpAtwwpE69q+cgwMs/aBZuAhVKC0EY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15689947459961023.9665742152399; Fri, 20 Sep 2019 08:52:25 -0700 (PDT) Received: from localhost ([::1]:32826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBLCo-0003CD-0W for importer@patchew.org; Fri, 20 Sep 2019 11:52:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43843) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBKpc-0000eG-Pk for qemu-devel@nongnu.org; Fri, 20 Sep 2019 11:28:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iBKpa-0004Oy-Mx for qemu-devel@nongnu.org; Fri, 20 Sep 2019 11:28:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48686) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iBKpW-0004Kx-4T; Fri, 20 Sep 2019 11:28:18 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE72C18C8919; Fri, 20 Sep 2019 15:28:15 +0000 (UTC) Received: from localhost (unknown [10.40.205.102]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89BDE60606; Fri, 20 Sep 2019 15:28:15 +0000 (UTC) From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH 04/22] iotests: Let 041 use -blockdev for quorum children Date: Fri, 20 Sep 2019 17:27:46 +0200 Message-Id: <20190920152804.12875-5-mreitz@redhat.com> In-Reply-To: <20190920152804.12875-1-mreitz@redhat.com> References: <20190920152804.12875-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.70]); Fri, 20 Sep 2019 15:28:16 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Using -drive with default options means that a virtio-blk drive will be created that has write access to the to-be quorum children. Quorum should have exclusive write access to them, so we should use -blockdev instead. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/041 | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 84bc6d6581..d91f538276 100755 --- a/tests/qemu-iotests/041 +++ b/tests/qemu-iotests/041 @@ -884,7 +884,10 @@ class TestRepairQuorum(iotests.QMPTestCase): # Assign a node name to each quorum image in order to manipula= te # them opts =3D "node-name=3Dimg%i" % self.IMAGES.index(i) - self.vm =3D self.vm.add_drive(i, opts) + opts +=3D ',driver=3D%s' % iotests.imgfmt + opts +=3D ',file.driver=3Dfile' + opts +=3D ',file.filename=3D%s' % i + self.vm =3D self.vm.add_blockdev(opts) =20 self.vm.launch() =20 --=20 2.21.0