From nobody Mon Feb 9 01:19:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568621523; cv=none; d=zoho.com; s=zohoarc; b=hGXgJPH4edBUIBkZT4KyIIvly062CGmrk8pLgsVmxWksIBeaMulUOZXtmXrgikCDBrVgcjv1Snq+ME2efapD3HSCBA46VmULegrH2ZDXqpJlU50jchGYZnIFRlVkd+1Iw8TQRClqtqW4siHxcXThOfv760u2oQ0BKixp/uQQ0wY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568621523; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=nmE6cphgGSfuRpSYHmBaH3flkReKC3mKIpc0TIUSO10=; b=VmSkq6jyJP+q1su8u64BKqwF05m+kUrgNRseBI/y0GUClqH/1GMXKGMhKpXeNXbcqB5947fB4KMcaCGrVDwSTyWu9zSjmOVC2OQGc38WOo385ZTYWQYywNiAoMZBJNIHis8pmFef2tW19MZW0ANGWAOVIttEkwkfzutM/TgmVKY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568621523385434.7103534716658; Mon, 16 Sep 2019 01:12:03 -0700 (PDT) Received: from localhost ([::1]:59810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9m78-0000K7-0K for importer@patchew.org; Mon, 16 Sep 2019 04:12:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56022) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9m36-00057r-Jm for qemu-devel@nongnu.org; Mon, 16 Sep 2019 04:07:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9m35-0002DN-JQ for qemu-devel@nongnu.org; Mon, 16 Sep 2019 04:07:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38698) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i9m35-0002Cx-CB for qemu-devel@nongnu.org; Mon, 16 Sep 2019 04:07:51 -0400 Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A4B31C055673 for ; Mon, 16 Sep 2019 08:07:50 +0000 (UTC) Received: by mail-pg1-f200.google.com with SMTP id h10so4095358pgh.11 for ; Mon, 16 Sep 2019 01:07:50 -0700 (PDT) Received: from xz-x1.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id r12sm43051515pgb.73.2019.09.16.01.07.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2019 01:07:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZFeNVkx/j6RSMxkpoM7GQeDxNvolVV9ALPcNdbnD3Qk=; b=GMNfbbZDDOyoikPeRzMscrxQwpzHQWKQZz36FBem0woL0UBebVxpcHE0GsJzr/Rh2P tJJlzL/TMWcWUlYRxT2DJznANme0ukHwknz9nvU6/Dk2chOYfWWNmlHzvwXTzbTdcLgV gtzrdCJLrDYwHyqwpoGipLFtiDprGR9fK9iu/3p6lpxDK9hQPEUvCcLhhHUPtFuthjX+ d34FbqY2VZYVv7UhUTvnPOfRPKm8ohprj7b1q5YzPSMGaBtTGa5QTCfYROZajhf5d+BT hos5zpD1xP50lErnyR6UrBDh07tPwOx1W4r3y42kHcyzDnTel2RmfX1xY8sa5EBXN+XR fL3Q== X-Gm-Message-State: APjAAAXsNL4oo+SQdFINXnOBseEBnX4bbSjxyCAVzTWDKH/L5QkKYfCU eugkbdMPnUPfm90v3vvkTXP1hAhqDrqRg0BFjy2qwbbP2xtbrBrQRMiGVR6KlGtCN5flH0RZsiq T0EOQXo+H12SZwIs= X-Received: by 2002:a17:90a:b282:: with SMTP id c2mr19253820pjr.135.1568621269826; Mon, 16 Sep 2019 01:07:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqxkFFwjEfZlp/nZTRkhUNzWW0Wdn8A/aiyl/jiPz+lt+ghFCdhyDeygM2YmhE//epS/A/d0Qg== X-Received: by 2002:a17:90a:b282:: with SMTP id c2mr19253800pjr.135.1568621269652; Mon, 16 Sep 2019 01:07:49 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Date: Mon, 16 Sep 2019 16:07:18 +0800 Message-Id: <20190916080718.3299-5-peterx@redhat.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190916080718.3299-1-peterx@redhat.com> References: <20190916080718.3299-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 4/4] intel_iommu: Remove the caching-mode check during flag change X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , "Michael S. Tsirkin" , Jason Wang , Alex Williamson , peterx@redhat.com, Eric Auger , Bandan Das , Igor Mammedov , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" That's never a good place to stop QEMU process... Since now we have both the machine done sanity check and also the hotplug handler, we can safely remove this to avoid that. Reviewed-by: Eric Auger Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index bed8ffe446..f1de8fdb75 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2936,10 +2936,6 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemor= yRegion *iommu, VTDAddressSpace *vtd_as =3D container_of(iommu, VTDAddressSpace, iommu= ); IntelIOMMUState *s =3D vtd_as->iommu_state; =20 - if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) { - vtd_panic_require_caching_mode(); - } - /* Update per-address-space notifier flags */ vtd_as->notifier_flags =3D new; =20 --=20 2.21.0