From nobody Wed Nov 12 07:08:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568621137; cv=none; d=zoho.com; s=zohoarc; b=ZmuGe24DaQOckiM6lwi/7b+BNZAyvsByLnPYXgF0dRiuKswH9SgUQePkXbP6vWWZRSJhjeU1l9d6AuEHA7Xf6jS1G8Yi5Awirp20ivWOq90Yp5ALSGUiZsXTpJTUoNPq/1imfYIBwRPWWgfinssovAfc8fzigbHcAv6SmskPISg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568621137; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Q9okMm6Rb0H1ZavHnOSQF85KyavwYDarcF3NW/AZJuc=; b=PgqJIvwAucn+CaM62Hre0tb9bHQ6X2cxPVLVJWXDtTPla0NM8UEnmhIvE1uaMe0OhlMEemK/d7/X1pdJ1ZDj39P+VRnpUc1nZo+oImkWawzsbeO/NbQBoJJiY8KTcZgSEn8Pa9cMAtqiWg4ZxFmrFzP3WFvj8GvNoyd2Rk9kxt4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568621137599853.0443914318918; Mon, 16 Sep 2019 01:05:37 -0700 (PDT) Received: from localhost ([::1]:59736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9m0u-0002eG-7v for importer@patchew.org; Mon, 16 Sep 2019 04:05:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54497) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9luj-0006B7-6n for qemu-devel@nongnu.org; Mon, 16 Sep 2019 03:59:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9lui-0006Fn-2Y for qemu-devel@nongnu.org; Mon, 16 Sep 2019 03:59:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40060) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i9luh-0006FK-TZ for qemu-devel@nongnu.org; Mon, 16 Sep 2019 03:59:12 -0400 Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 333F788306 for ; Mon, 16 Sep 2019 07:59:11 +0000 (UTC) Received: by mail-pg1-f197.google.com with SMTP id r35so9877432pgb.2 for ; Mon, 16 Sep 2019 00:59:11 -0700 (PDT) Received: from xz-x1.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id p20sm50321443pgi.81.2019.09.16.00.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2019 00:59:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Sd75Sl64YfC71rpaDKMmxyQH/rUSVoFuK0rLbD5VCyU=; b=eG1AJErg9a+J1T6zZkF+aqatc/DHc0rFRHOJr2oNZcElT5AE3GvCz8GZnBDJVHDi4K gGr3SFkflbq1bcOSR0PxtulI2q1hk+lwUFQX4VjDlOH5whQlgXmFAvjc8V8WUe7wWTLG 9SZBQePEaxPOFOOHZajz2w3oejcfHdG1ynW/W0ToMaNR1fz0s4MEegFTXRyCPe4SXIXI 1ewm+4Lcxe+jxesHkx6Ne6UEwEQgf2GzH5Vg1zD+POFc9J0HNc3CPMy/apkyYYzImBb/ 2+05rVp0/n9s01YP44p/yJoWPCkxHSaLi6PhjQHaqWDSQMrp7RB2DwSZJNHMxyBGmupf QzRQ== X-Gm-Message-State: APjAAAUW6qSYFl416gu5HYtxfTIkHiWxgFj7YWgdxaK1OAhguzN5lJTX B8V+KLWG53LOOx01y4U4C9GBDtR9LYEdJMi7uJYZZfSpf68lIrZ0y0wz4gozfuEfegRKQH8zFEy plHjGeW5cGO/i1mo= X-Received: by 2002:a17:902:54f:: with SMTP id 73mr24803368plf.329.1568620750383; Mon, 16 Sep 2019 00:59:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrJ9IHL9ttpV32BC8XJFkXF7f+RIXyc69Umca68/zrFzxV2RxYLdPDT+DoSjr3EXx199I3+w== X-Received: by 2002:a17:902:54f:: with SMTP id 73mr24803355plf.329.1568620750214; Mon, 16 Sep 2019 00:59:10 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Date: Mon, 16 Sep 2019 15:58:39 +0800 Message-Id: <20190916075839.390-5-peterx@redhat.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190916075839.390-1-peterx@redhat.com> References: <20190916075839.390-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 4/4] intel_iommu: Remove the caching-mode check during flag change X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , "Michael S. Tsirkin" , Jason Wang , Alex Williamson , peterx@redhat.com, Bandan Das , Igor Mammedov , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" That's never a good place to stop QEMU process... Since now we have both the machine done sanity check and also the hotplug handler, we can safely remove this to avoid that. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 17fc309b3d..070816c355 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2935,10 +2935,6 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemor= yRegion *iommu, VTDAddressSpace *vtd_as =3D container_of(iommu, VTDAddressSpace, iommu= ); IntelIOMMUState *s =3D vtd_as->iommu_state; =20 - if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) { - vtd_panic_require_caching_mode(); - } - /* Update per-address-space notifier flags */ vtd_as->notifier_flags =3D new; =20 --=20 2.21.0