From nobody Wed Nov 12 07:06:20 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1568555672; cv=none; d=zoho.com; s=zohoarc; b=C+9kNKiJyHpzqs4hoGEUieLjGUIuUfcEWoF+HtkgoAYEPkx9O2mu2uCjXWKqJBdFd9I0ZaEjnHm8oCV8VBUOk2xkliGuX1RcX/G9+3HEASlcXNPpV9hc0qwTGrxnSx/AdHgYFxWXYyRnjdd39uuseHLVnCkuGyPCQA63u07Jgwo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568555672; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=YAOhFzzxz8Wer64d+m0cXxodZOyQ32EAoZ5iMqeSp6A=; b=W07poDVfTftiisWfF1l3N8vVL+u3VPDY01Pp/S5DjxWwJovnPkhfThHtzvRJ5qs6a7b403d6W3uJxXa46SuRKkxpzMBa5tgED3phJMCCYBI2xm3RgpR9MwZ/dLjSzUFRIGw6cX8zBmEC8Riw9Y8eEW2HS3KabwCiOAn+HVesUdA= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568555672503198.4714189323222; Sun, 15 Sep 2019 06:54:32 -0700 (PDT) Received: from localhost ([::1]:54930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9Uz1-0006mv-5n for importer@patchew.org; Sun, 15 Sep 2019 09:54:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59380) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9Uub-0003cr-1v for qemu-devel@nongnu.org; Sun, 15 Sep 2019 09:49:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9Uua-0003iI-1p for qemu-devel@nongnu.org; Sun, 15 Sep 2019 09:49:56 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:38589) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9UuZ-0003i7-S2 for qemu-devel@nongnu.org; Sun, 15 Sep 2019 09:49:56 -0400 Received: by mail-ed1-x52f.google.com with SMTP id a23so28568248edv.5 for ; Sun, 15 Sep 2019 06:49:55 -0700 (PDT) Received: from localhost.localdomain ([185.81.138.17]) by smtp.gmail.com with ESMTPSA id ot24sm123053ejb.59.2019.09.15.06.49.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Sep 2019 06:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YAOhFzzxz8Wer64d+m0cXxodZOyQ32EAoZ5iMqeSp6A=; b=A1ru8zBW65YkdBpXOmkxIDGN0XMsbpUfPuGVw3zI1YYY9bNA5t/k36Okg+4vgnWBNQ vmh86tTzT1gVR5AtXvuuJhqWlG5FSusg3+yA2ATNpjQ2LNebskgnSUy6mq7hmiiJSvVi qVANW/HXDNhBtnJENeEoAVNzkeHfv56KX4NaQoGQNuqZfleCm62BgX9u56opNFoz8eXn orpUBTpICFOk6LU++u5dAQqF5ItWiySaEUnJCUZFyPpKlXh81IifJuDw+qYE7FZlHIuR nM6bFKGc9+7/0zfxisyUpCAdC3xxrrwEkVzFLGsfvACsa2HGXyXAav7BycLFPbtoY7tJ wneg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YAOhFzzxz8Wer64d+m0cXxodZOyQ32EAoZ5iMqeSp6A=; b=Ut8BR7qOvXL/TI4igOmlqz5Yt5NeBHyBJTrI3ZsoTMIL+tx05CiQwTeLWyV4Kapmua xoIDhZ3ulXG4k9AmP7pAkBe915/ynEixhPiOsrBBFR62S4eYV8VPiItTLFAW0cPlquR1 WdHzsSdGa2yWrFaLoBnvjLQqEZfoNCEFAgtZe9GDpFCm8XuboBZxCX2h+wse3KxRpDJh vDvCw7iNKlb431Y/YlnQKOdHdo6AMwaH1MA8ayMUgWmJ4hlLIPj3JeCsRqUJOMkSVFcP bHV4Lk/tgPP4bRLjfo1GysWHhDW+ycwlsWHUbLRPsDFjqGAJ/k8rYerwTs4PpSh+8/9l VXVg== X-Gm-Message-State: APjAAAUHI7jNHH3KLSmiVeKPdDroALg+BasIS0chbzQXNG1xzWWWrqgv c5MZFf7UKWPFgR+pvW5qpuzp0GnIpWPYaA== X-Google-Smtp-Source: APXvYqxDotemGHcvgXw0JcQwMq55Nfj9B4D2MTNCbBmLovBCmABVFGJIvwORbCXSeZPCt+BgjDzeMg== X-Received: by 2002:a50:9625:: with SMTP id y34mr20450366eda.72.1568555394667; Sun, 15 Sep 2019 06:49:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sun, 15 Sep 2019 09:49:44 -0400 Message-Id: <20190915134944.2173-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190915134944.2173-1-richard.henderson@linaro.org> References: <20190915134944.2173-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52f Subject: [Qemu-devel] [PULL 2/2] target/hppa: prevent trashing of temporary in do_depw_sar() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Sven Schnelle Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Sven Schnelle nullify_over() calls brcond which destroys all temporaries. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Sven Schnelle Message-Id: <20190913101714.29019-3-svens@stackframe.org> Signed-off-by: Richard Henderson --- target/hppa/translate.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index b12525d535..c1b2822f60 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -3404,10 +3404,6 @@ static bool do_depw_sar(DisasContext *ctx, unsigned = rt, unsigned c, TCGv_reg mask, tmp, shift, dest; unsigned msb =3D 1U << (len - 1); =20 - if (c) { - nullify_over(ctx); - } - dest =3D dest_gpr(ctx, rt); shift =3D tcg_temp_new(); tmp =3D tcg_temp_new(); @@ -3440,11 +3436,17 @@ static bool do_depw_sar(DisasContext *ctx, unsigned= rt, unsigned c, =20 static bool trans_depw_sar(DisasContext *ctx, arg_depw_sar *a) { + if (a->c) { + nullify_over(ctx); + } return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_gpr(ctx, a->r= )); } =20 static bool trans_depwi_sar(DisasContext *ctx, arg_depwi_sar *a) { + if (a->c) { + nullify_over(ctx); + } return do_depw_sar(ctx, a->t, a->c, a->nz, a->clen, load_const(ctx, a-= >i)); } =20 --=20 2.17.1