From nobody Wed Nov 12 07:16:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568475447; cv=none; d=zoho.com; s=zohoarc; b=a+TG4rhfYtYMNbCXvXaFQzY052p3dzJf/v5ndnuzwWYJJl/41bZqo8J1JVpL2681o5fJ14z5G2byembmDILKfLbsdHDhV5UehGQpN9H42K5rx+MaJdGJtj437CYdJ4sIB1Bz+TTqj/Muk/IpkZM64PeX4HcutHy3gO7uGTV2+A0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568475447; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=E0MMA5HlFx2Sut/W0l2L5aiao1rn95N06N5l1G6dXT4=; b=I0x2P2l6HfTqcPCImeaIrYeVsOjoOkhAT9yvd8GKeJe5J9XOnw+SIDXT1RbKtzD4Kf40Y+mXTK3jBMcA8pwuIdPQMPDhRFMkcU80VUYvLGTXZzitYLOPQoBrOjxVbMucuFVGIT7VB0XTV8LEmd05qr8i/sQrRvp/tI2UNYq/5pI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568475447392304.81334183195906; Sat, 14 Sep 2019 08:37:27 -0700 (PDT) Received: from localhost ([::1]:50738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9A73-0006wr-UN for importer@patchew.org; Sat, 14 Sep 2019 11:37:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54408) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9A5D-00052e-VB for qemu-devel@nongnu.org; Sat, 14 Sep 2019 11:35:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9A5B-0004zB-3a for qemu-devel@nongnu.org; Sat, 14 Sep 2019 11:35:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57078) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i9A5A-0004rz-3q for qemu-devel@nongnu.org; Sat, 14 Sep 2019 11:35:28 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2C945C050061; Sat, 14 Sep 2019 15:35:12 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-117-142.ams2.redhat.com [10.36.117.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EFDF517B49; Sat, 14 Sep 2019 15:35:11 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9C4BA11385CB; Sat, 14 Sep 2019 17:35:06 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Sat, 14 Sep 2019 17:34:53 +0200 Message-Id: <20190914153506.2151-7-armbru@redhat.com> In-Reply-To: <20190914153506.2151-1-armbru@redhat.com> References: <20190914153506.2151-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sat, 14 Sep 2019 15:35:12 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 06/19] tests/qapi-schema: Demonstrate suboptimal lexical errors X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@redhat.com, mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The error message for forgotten quotes around a name shows just the name's first character, which isn't as nice as it could be. Same for attempting to use a number. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/Makefile.include | 1 + tests/qapi-schema/bad-type-int.json | 2 +- tests/qapi-schema/funny-word.err | 1 + tests/qapi-schema/funny-word.exit | 1 + tests/qapi-schema/funny-word.json | 1 + tests/qapi-schema/funny-word.out | 0 6 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 tests/qapi-schema/funny-word.err create mode 100644 tests/qapi-schema/funny-word.exit create mode 100644 tests/qapi-schema/funny-word.json create mode 100644 tests/qapi-schema/funny-word.out diff --git a/tests/Makefile.include b/tests/Makefile.include index c108a83076..f5a4266992 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -403,6 +403,7 @@ qapi-schema +=3D flat-union-no-base.json qapi-schema +=3D flat-union-optional-discriminator.json qapi-schema +=3D flat-union-string-discriminator.json qapi-schema +=3D funny-char.json +qapi-schema +=3D funny-word.json qapi-schema +=3D ident-with-escape.json qapi-schema +=3D include-before-err.json qapi-schema +=3D include-cycle.json diff --git a/tests/qapi-schema/bad-type-int.json b/tests/qapi-schema/bad-ty= pe-int.json index 56fc6f8126..f3ad803cb6 100644 --- a/tests/qapi-schema/bad-type-int.json +++ b/tests/qapi-schema/bad-type-int.json @@ -1,3 +1,3 @@ # we reject an expression with a metatype that is not a string # FIXME: once the parser understands integer inputs, improve the error mes= sage -{ 'struct': 1, 'data': { } } +{ 'struct': 123, 'data': { } } diff --git a/tests/qapi-schema/funny-word.err b/tests/qapi-schema/funny-wor= d.err new file mode 100644 index 0000000000..0a440574bd --- /dev/null +++ b/tests/qapi-schema/funny-word.err @@ -0,0 +1 @@ +tests/qapi-schema/funny-word.json:1:3: Stray "c" diff --git a/tests/qapi-schema/funny-word.exit b/tests/qapi-schema/funny-wo= rd.exit new file mode 100644 index 0000000000..d00491fd7e --- /dev/null +++ b/tests/qapi-schema/funny-word.exit @@ -0,0 +1 @@ +1 diff --git a/tests/qapi-schema/funny-word.json b/tests/qapi-schema/funny-wo= rd.json new file mode 100644 index 0000000000..1153b9f12f --- /dev/null +++ b/tests/qapi-schema/funny-word.json @@ -0,0 +1 @@ +{ command: 'foo' } diff --git a/tests/qapi-schema/funny-word.out b/tests/qapi-schema/funny-wor= d.out new file mode 100644 index 0000000000..e69de29bb2 --=20 2.21.0