From nobody Wed Apr 16 04:35:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1568390145; cv=none; d=zoho.com; s=zohoarc; b=cvL8xDw8+h3b24GDWYfV5c/vicfO62wHcsMlZLdNLFTK+O8wrLThdUlq7TVpKzfkGwAQ0OByFYPhS1uRgBD4aNh17XxMHZppicJIt+qllMCHzzwcqTWzvP9btrXeagMMioyX0eaQCbd/V/4qvafeJGnlYugApyS/BXwhPi55bOo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568390145; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=tBSweGRJqo1QugNMOgMsQvTUwdKJFX5c4+9Ab8DGWNg=; b=O90P8bd5G2CnCd7uEt+x3MorevqjM/GWFvY+AuV+WQRULv5OSq0Dkrnoa9W/Jra2fY6gdG2pJ0u5cgcAiIwaW9CUFTwBwrsUeFabVNQ/nBvCcdPsMSCWcwxtDI+HdSaJdvGVEW2hjCwk5MQYuUNsdNRUPF2oRh3NXWY6LY1Fafk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568390145554567.3516008796464; Fri, 13 Sep 2019 08:55:45 -0700 (PDT) Received: from localhost ([::1]:45622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8nv5-0004fN-0J for importer@patchew.org; Fri, 13 Sep 2019 11:55:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57124) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8npm-0007dK-G0 for qemu-devel@nongnu.org; Fri, 13 Sep 2019 11:50:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8npl-0000u5-BU for qemu-devel@nongnu.org; Fri, 13 Sep 2019 11:50:06 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:41936) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i8npl-0000sv-5Z for qemu-devel@nongnu.org; Fri, 13 Sep 2019 11:50:05 -0400 Received: by mail-wr1-x435.google.com with SMTP id h7so31580588wrw.8 for ; Fri, 13 Sep 2019 08:50:05 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id c132sm3562207wme.27.2019.09.13.08.50.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2019 08:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=tBSweGRJqo1QugNMOgMsQvTUwdKJFX5c4+9Ab8DGWNg=; b=IqEIbkAmJduDpgu6zcdRZY2Ye0s5mHWAKQtx1Tsixu31bVJygBgUGMlP75rXi83qNY O9wFEKWvnMxGA3b0j9+8RAmhCW1mUYpSINdWZJTmNLLD3RCi8K54fl/Ujd1F5RjC7D4x VPqz1K0IdFaRYFDqIILGfg5abm6eTS30STD3OcsnfsnDAEseL7hzhHomo3lhCuqp2td4 jP3L2KOgJjaPYR/EtH/Ue00KO9U95AkLQ3bSSSLx5ZhgFOKz4C0ElthyM3vrNMa0EUp8 NwfnPPRRRN5sgNoNTY2JGP24UPRlTidYO0ZnAFvZkKjGJLw8rGbSOPbAa/8l4qnaYmMD heVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tBSweGRJqo1QugNMOgMsQvTUwdKJFX5c4+9Ab8DGWNg=; b=oa4ZONbqqK5HtSVStqtPVKyNmTFVXMst0qvJBbqORh3By6yqhWRxPtwTQsyxKG9pXr h2W1k9+EJMAUQWulxTO6piWXjCLeW8aOymuW+ISRm4RfGMNfH6SMrgeqwTgIJznNfBW9 tC5NqX40JbwVs2ZAMprb7Mk1+LWHLYuMZ2Ye+4YBPW/fjssTbbaFh27CdGoV4CYQHIYq QvIrF2pb8DjHooZxufzgDypLtkrXKCtTak5BsSCpALoVfNgm5DrPTrwh9+2hvHnlEpQ5 xDvO7Aq5D83aR/2cwx0yH7fuLc0uhHioe4E9hxygFjtTVxskcODVbHAUWoWhIfYQCwmR D4Nw== X-Gm-Message-State: APjAAAXpgB8IAvOIqB9StkCsu6F+76UdYjZgBjNl7oatz9Cqcc42WLp5 xzQ1fM8BPpwZXbXoV0HtqsxWH4W/v/VfsA== X-Google-Smtp-Source: APXvYqyuE5pwz4zSc7LzKTuFJAK5xayFVdJ7iBfGGEDLqjFq6LAM9vuZO3jA1PApRamnvIckIboSug== X-Received: by 2002:adf:e947:: with SMTP id m7mr1409792wrn.178.1568389804001; Fri, 13 Sep 2019 08:50:04 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 13 Sep 2019 16:49:48 +0100 Message-Id: <20190913154952.27724-9-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190913154952.27724-1-peter.maydell@linaro.org> References: <20190913154952.27724-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::435 Subject: [Qemu-devel] [PULL 08/12] aspeed/smc: Calculate checksum on normal DMA X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Christian Svensson This patch adds the missing checksum calculation on normal DMA transfer. According to the datasheet this is how the SMC should behave. Verified on AST1250 that the hardware matches the behaviour. Signed-off-by: Christian Svensson Reviewed-by: Joel Stanley Signed-off-by: C=C3=A9dric Le Goater Message-id: 20190904070506.1052-9-clg@kaod.org Signed-off-by: Peter Maydell --- hw/ssi/aspeed_smc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 5c3436db5e8..9ffc7e01179 100644 --- a/hw/ssi/aspeed_smc.c +++ b/hw/ssi/aspeed_smc.c @@ -989,6 +989,7 @@ static void aspeed_smc_dma_rw(AspeedSMCState *s) s->regs[R_DMA_FLASH_ADDR] +=3D 4; s->regs[R_DMA_DRAM_ADDR] +=3D 4; s->regs[R_DMA_LEN] -=3D 4; + s->regs[R_DMA_CHECKSUM] +=3D data; } } =20 --=20 2.20.1