From nobody Wed Nov 12 05:28:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568388671; cv=none; d=zoho.com; s=zohoarc; b=FkBqirl7PZ1ri/Z0vQgNe9tKBK3Bz7LOoU57waw8diCde6oWaK9GvHYj1pZfdeKI91CUPkx+/FeO480bc/kD1ttXnA/Kd6McLzf6xFu+1LuQw1sy790tjHl8KS76bl/vLeTLfUK6ENU+5K0kMIC+hTvx9vso2ZBOOGWHkB3jiS4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568388671; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=p9Z6fOhvtIUum/I1HVCNPVeMRR2aY0NOF4v/W0r7m2Y=; b=e0up33hrx6mr/bQV5Wq1zx4EttqAQDth+FiuqbO3l82pYGIN0A/Jg+XzhtY2FSrXIrzP3DAM67Go5BQqjyLo8TiIcR/cOBhcAzWI8ueUHMvfs4Yf4xrBDS2MF8jJxPawICt13kULF2JJ4LG/DlPAcIq9JqMqckA7ZbwkBatjXRQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568388671983533.1829573349087; Fri, 13 Sep 2019 08:31:11 -0700 (PDT) Received: from localhost ([::1]:45321 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8nXP-0003zx-8Q for importer@patchew.org; Fri, 13 Sep 2019 11:31:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53172) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8nSN-0006my-C6 for qemu-devel@nongnu.org; Fri, 13 Sep 2019 11:25:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8nSM-0003T3-Ai for qemu-devel@nongnu.org; Fri, 13 Sep 2019 11:25:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45312) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i8nSK-0003QD-DI; Fri, 13 Sep 2019 11:25:52 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A67F3898102; Fri, 13 Sep 2019 15:25:51 +0000 (UTC) Received: from dritchie.redhat.com (unknown [10.33.36.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 16D021001959; Fri, 13 Sep 2019 15:25:49 +0000 (UTC) From: Sergio Lopez To: qemu-block@nongnu.org Date: Fri, 13 Sep 2019 17:25:07 +0200 Message-Id: <20190913152507.56197-2-slp@redhat.com> In-Reply-To: <20190913152507.56197-1-slp@redhat.com> References: <20190913152507.56197-1-slp@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.67]); Fri, 13 Sep 2019 15:25:51 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v2 1/2] blockdev: release the AioContext at drive_backup_prepare X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, Sergio Lopez , mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" do_drive_backup() already acquires the AioContext, so release it before the call. Signed-off-by: Sergio Lopez --- blockdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index fbef6845c8..3927fdab80 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1783,20 +1783,16 @@ static void drive_backup_prepare(BlkActionState *co= mmon, Error **errp) =20 aio_context =3D bdrv_get_aio_context(bs); aio_context_acquire(aio_context); - /* Paired with .clean() */ bdrv_drained_begin(bs); + aio_context_release(aio_context); =20 state->bs =3D bs; =20 state->job =3D do_drive_backup(backup, common->block_job_txn, &local_e= rr); if (local_err) { error_propagate(errp, local_err); - goto out; } - -out: - aio_context_release(aio_context); } =20 static void drive_backup_commit(BlkActionState *common) --=20 2.21.0