From nobody Wed Nov 12 05:28:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568297895; cv=none; d=zoho.com; s=zohoarc; b=B1PZSCg+wINeHGuRK+zHXl7mSMqd4ygEjqv3HektNBUHliJLNItBiEGJbP4c2vU1jDD1aBiwNeKCai+3cnQFoJxZn4v4q5JxMXdJGDFVQAz7J/dSi6Pdhtv0K95a3rsJdQasz9PflhVR73CYRi3CCNmPHH0Pn6Xpq8VyFOPRmPM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568297895; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=/nbWXQN5eIBbX227j07woOwMFQAuxFtmRnb8Cn3onRo=; b=KGrZnzyu6S/GCkA+SlEip7G+0VB6WhWFtI0NBCbw1mC/69fVJaSYFfY2NDkTFbMoA1Oqm+zzehtKyxTI8Ty8L7C2JHhQ34zsp36WGWmz+rE4GkKzrnuiRCqngEPLjUB7Na7YQujII3QWerL4eBeU/GgDAZSeTAslxDH3hYhOQtg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568297895901283.67585586514997; Thu, 12 Sep 2019 07:18:15 -0700 (PDT) Received: from localhost ([::1]:34984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8PvF-0002vX-Jf for importer@patchew.org; Thu, 12 Sep 2019 10:18:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40641) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8PUw-0007IL-Me for qemu-devel@nongnu.org; Thu, 12 Sep 2019 09:50:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8PUv-0003GU-KY for qemu-devel@nongnu.org; Thu, 12 Sep 2019 09:50:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37186) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i8PUv-0003Fu-Fn for qemu-devel@nongnu.org; Thu, 12 Sep 2019 09:50:57 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB473C056808; Thu, 12 Sep 2019 13:50:56 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7984B5D704; Thu, 12 Sep 2019 13:50:55 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, ivanren@tencent.com, peterx@redhat.com, richardw.yang@linux.intel.com, yury-kotov@yandex-team.ru, quintela@redhat.com Date: Thu, 12 Sep 2019 14:50:04 +0100 Message-Id: <20190912135006.14820-11-dgilbert@redhat.com> In-Reply-To: <20190912135006.14820-1-dgilbert@redhat.com> References: <20190912135006.14820-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 12 Sep 2019 13:50:56 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 10/12] migration/qemu-file: remove check on writev_buffer in qemu_put_compression_data X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Wei Yang The check of writev_buffer is in qemu_fflush, which means it is not harmful if it is NULL. And removing it will make the code consistent since all other add_to_iovec() is called without the check. Signed-off-by: Wei Yang Reviewed-by: Dr. David Alan Gilbert Message-Id: <20190911132839.23336-2-richard.weiyang@gmail.com> Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 075faf03c3..66627088d4 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file.c @@ -760,9 +760,7 @@ ssize_t qemu_put_compression_data(QEMUFile *f, z_stream= *stream, } =20 qemu_put_be32(f, blen); - if (f->ops->writev_buffer) { - add_to_iovec(f, f->buf + f->buf_index, blen, false); - } + add_to_iovec(f, f->buf + f->buf_index, blen, false); f->buf_index +=3D blen; if (f->buf_index =3D=3D IO_BUF_SIZE) { qemu_fflush(f); --=20 2.21.0