From nobody Wed Nov 12 05:28:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568298430; cv=none; d=zoho.com; s=zohoarc; b=olACDpghqO/Z1T1eXV46/+PUGSgdgWrckrkEhqOOb6CZhneDjXPWYZz7G8PAXKRoHmxwLjIx+0ba4R5r0Zf/C4yhZdHLEPD9hbqQGg4HvWKGRa9zYjO5sILkWOP1qNXxohWQCRHkR4PDtoulNYJHSMsdciagPhjdU/SPxo5gACY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568298430; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=C3vI+rOMqXNOtnAFHTzmxaIz+LDRRosJuLkzwPG4yKk=; b=TqtYHV/16Zp1S9HqBuy3neIRfYzS97FZ0xkpkWPMvIBcbievI6K5Bh9hyUJLaROiPgmfsrSDgtRxugXC8DCo0FhcVq9X/u6/36DKxszywlmWXSvpinqVaSVn5mH2ndM6ZwKoQs9yXqbUqiu4ZUDjc4HL86ZkpVi1VuDrcpuQ83A= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568298430527177.25845725566694; Thu, 12 Sep 2019 07:27:10 -0700 (PDT) Received: from localhost ([::1]:35124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8Q3w-0005wo-VT for importer@patchew.org; Thu, 12 Sep 2019 10:27:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40623) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8PUv-0007G7-4k for qemu-devel@nongnu.org; Thu, 12 Sep 2019 09:50:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8PUu-0003F7-2b for qemu-devel@nongnu.org; Thu, 12 Sep 2019 09:50:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46272) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i8PUt-0003Eh-TH for qemu-devel@nongnu.org; Thu, 12 Sep 2019 09:50:56 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3039C10C0933; Thu, 12 Sep 2019 13:50:55 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id D0FB25D704; Thu, 12 Sep 2019 13:50:53 +0000 (UTC) From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, ivanren@tencent.com, peterx@redhat.com, richardw.yang@linux.intel.com, yury-kotov@yandex-team.ru, quintela@redhat.com Date: Thu, 12 Sep 2019 14:50:03 +0100 Message-Id: <20190912135006.14820-10-dgilbert@redhat.com> In-Reply-To: <20190912135006.14820-1-dgilbert@redhat.com> References: <20190912135006.14820-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Thu, 12 Sep 2019 13:50:55 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 09/12] migration: Fix postcopy bw for recovery X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Peter Xu We've got max-postcopy-bandwidth parameter but it's not applied correctly after a postcopy recovery so the recovered migration stream will still eat the whole net bandwidth. Fix that up. Reported-by: Xiaohui Li Signed-off-by: Peter Xu Message-Id: <20190906130103.20961-1-peterx@redhat.com> Reviewed-by: Juan Quintela Signed-off-by: Dr. David Alan Gilbert --- migration/migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 2391a8d418..e45270c23b 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -3336,7 +3336,8 @@ void migrate_fd_connect(MigrationState *s, Error *err= or_in) =20 if (resume) { /* This is a resumed migration */ - rate_limit =3D INT64_MAX; + rate_limit =3D s->parameters.max_postcopy_bandwidth / + XFER_LIMIT_RATIO; } else { /* This is a fresh new migration */ rate_limit =3D s->parameters.max_bandwidth / XFER_LIMIT_RATIO; --=20 2.21.0