From nobody Fri Dec 19 06:16:03 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568296599; cv=none; d=zoho.com; s=zohoarc; b=CGsb2OF7t1ancng0Ufga6x//3DxU944pwW6bOQywkZApQ7CI5pjDepkhE6qcEJYPsU7c0VoNlFi6sd/ZFf/s2nVEv8FPwGK9MzWffHKRRA4+TtLr3tmzL/I7fUSd2JMEcrOi9F3zJgc0nM6a3K68ZFfegSerbJvKBg+WhtGpz0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568296599; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=p2vMJSHGL3MaoElnRC2LjEOIGvWekoiBpIXk3CUPoIA=; b=GVpz9qDL49M6BTDbWqumS0+bB/pqd1EiE+0ctlorogtNTzDZONsEqMAMWYf4+N4n9nZ5BZCWqn3gs7A3ixXqp6f8yK6Pcf31zYpiaM5Iowdfs4xAO4Sp46kKv33DowoayAJEn2SpM4G2tNiuYTeK8/7BP3zhwDqnBF4wccTpOkk= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568296599962661.3614006461486; Thu, 12 Sep 2019 06:56:39 -0700 (PDT) Received: from localhost ([::1]:34754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8PaN-0005VD-Gg for importer@patchew.org; Thu, 12 Sep 2019 09:56:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39075) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i8PQd-0002e3-1e for qemu-devel@nongnu.org; Thu, 12 Sep 2019 09:46:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i8PQb-0001KH-Qy for qemu-devel@nongnu.org; Thu, 12 Sep 2019 09:46:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34680) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i8PQZ-0001IG-6R; Thu, 12 Sep 2019 09:46:27 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 43450C0546F2; Thu, 12 Sep 2019 13:46:26 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-116-179.ams2.redhat.com [10.36.116.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3EAEF600C8; Thu, 12 Sep 2019 13:46:23 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Date: Thu, 12 Sep 2019 15:45:47 +0200 Message-Id: <20190912134604.22019-6-kwolf@redhat.com> In-Reply-To: <20190912134604.22019-1-kwolf@redhat.com> References: <20190912134604.22019-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 12 Sep 2019 13:46:26 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 05/22] pr-manager: Fix invalid g_free() crash bug X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Markus Armbruster pr_manager_worker() passes its @opaque argument to g_free(). Wrong; it points to pr_manager_worker()'s automatic @data. Broken when commit 2f3a7ab39be converted @data from heap- to stack-allocated. Fix by deleting the g_free(). Fixes: 2f3a7ab39bec4ba8022dc4d42ea641165b004e3e Cc: qemu-stable@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- scsi/pr-manager.c | 1 - 1 file changed, 1 deletion(-) diff --git a/scsi/pr-manager.c b/scsi/pr-manager.c index ee43663576..0c866e8698 100644 --- a/scsi/pr-manager.c +++ b/scsi/pr-manager.c @@ -39,7 +39,6 @@ static int pr_manager_worker(void *opaque) int fd =3D data->fd; int r; =20 - g_free(data); trace_pr_manager_run(fd, hdr->cmdp[0], hdr->cmdp[1]); =20 /* The reference was taken in pr_manager_execute. */ --=20 2.20.1