From nobody Sat Apr 27 04:06:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568162632; cv=none; d=zoho.com; s=zohoarc; b=Wrc+dooXwBYNm5WlxNq5lD+9PF7eG4qJm5tiFdrR1CeP7ajQ3QLxnQSWKgpR4NTOfTDL66Km8LWIuQWpJGqoUwdq99LYXeNuy9eEqzJbyNlm7BFwQye5yluswn1NxSbvSVLaKBq8cbUm98vnuqe0lKm+zqwAYx47umWMcj0W36o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568162632; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=9FWzGWGYOUifVmtvgnMUpIcQyZpmd3Txs3/KItaLsHA=; b=dOnHKrrCofLxlOQCCvpcU5L6BS3e6x78pkYqdWr5PoanPKLy46KPw8oGheZ5AoIx66JI/MEgRqNiUwvlfpGL4IY09Znaf8VMIPP1wC2g6NG4yrT45a+TgXiZrbEnDkaDi1ujkrptS4Q/ELMwnDQOnfSK2gQ7QxCdypbCAkMpycA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568162632854851.0097357087691; Tue, 10 Sep 2019 17:43:52 -0700 (PDT) Received: from localhost ([::1]:45668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7qjf-0000J5-Dg for importer@patchew.org; Tue, 10 Sep 2019 20:43:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46327) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7qi9-0007XW-9G for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7qi7-00080R-7b for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35958) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7qi7-00080C-33 for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:15 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4953030A7B83 for ; Wed, 11 Sep 2019 00:42:14 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-121-171.rdu2.redhat.com [10.10.121.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 827A560166; Wed, 11 Sep 2019 00:42:13 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Tue, 10 Sep 2019 20:42:01 -0400 Message-Id: <20190911004204.29286-2-crosa@redhat.com> In-Reply-To: <20190911004204.29286-1-crosa@redhat.com> References: <20190911004204.29286-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Wed, 11 Sep 2019 00:42:14 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 1/4] tests/acceptance/cpu_queries.py: cleanups X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Willian Rampazzo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Simple cleanups for debugging code that is not being used. Signed-off-by: Cleber Rosa --- tests/acceptance/cpu_queries.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries= .py index e71edec39f..a9ac3d692e 100644 --- a/tests/acceptance/cpu_queries.py +++ b/tests/acceptance/cpu_queries.py @@ -8,8 +8,6 @@ # This work is licensed under the terms of the GNU GPL, version 2 or # later. See the COPYING file in the top-level directory. =20 -import logging - from avocado_qemu import Test =20 class QueryCPUModelExpansion(Test): @@ -24,7 +22,6 @@ class QueryCPUModelExpansion(Test): =20 cpus =3D self.vm.command('query-cpu-definitions') for c in cpus: - print(repr(c)) self.assertNotIn('', c['unavailable-features'], c['name']) =20 for c in cpus: --=20 2.21.0 From nobody Sat Apr 27 04:06:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568162639; cv=none; d=zoho.com; s=zohoarc; b=Tgb4KXA65LDsH08zr8fB65sH7s4f8LKcXbboH0aODdTLsqGb77oE1h7UoujG9hlmJTLtT7GQm4VmV1iexIjvOg6UuSwcOX8q+CYPhCsyAa5gRLoIxx4Ldl3k+0piCnIae44gneMyHUWn7+NVqDC4c0g1VrVg4ZifEd5dOZ2cI6U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568162639; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=c0hQfixxxye2m6W4KOTJMMF+sDvnIBdZZO6eAflAFpA=; b=lueF2pOgLDEiYfJmlSd14we56vaWEaEtEf2mF8murW39DxideDgIyuaBzz8xg8o7OfcdJyrPvodTjJbISu08ohsU7uqlawK3nZjNsbjziOeDL4TS2WTvW/V8yXJ05SyV6GKvhqHuSKhQhE21qnx+8d6+GHHvCkqadUw12QcE6/k= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568162639163720.0915583033815; Tue, 10 Sep 2019 17:43:59 -0700 (PDT) Received: from localhost ([::1]:45672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7qjj-0000OD-HX for importer@patchew.org; Tue, 10 Sep 2019 20:43:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46332) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7qi9-0007XY-DE for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7qi7-00080f-VF for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40668) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7qi7-00080V-Qc for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:15 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30C9B30607E5 for ; Wed, 11 Sep 2019 00:42:15 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-121-171.rdu2.redhat.com [10.10.121.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6B5F360166; Wed, 11 Sep 2019 00:42:14 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Tue, 10 Sep 2019 20:42:02 -0400 Message-Id: <20190911004204.29286-3-crosa@redhat.com> In-Reply-To: <20190911004204.29286-1-crosa@redhat.com> References: <20190911004204.29286-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Wed, 11 Sep 2019 00:42:15 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/4] tests/acceptance/cpu_queries.py: tag test as x86_64 specific X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Willian Rampazzo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This is an usability improvement, and prevents the test from being automatically run with some not supported targets (say on an ppc64le or aarch64 host). Actually, the x86_64 tagging is a little white lie, because in theory, at least parts of the test, such as the query-cpu-model-expansion query, should also work on s390x. But, that is actually failing, so a future development round will attempt to make tests run on all possible supported targets. Signed-off-by: Cleber Rosa --- tests/acceptance/cpu_queries.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries= .py index a9ac3d692e..1028588920 100644 --- a/tests/acceptance/cpu_queries.py +++ b/tests/acceptance/cpu_queries.py @@ -13,6 +13,8 @@ from avocado_qemu import Test class QueryCPUModelExpansion(Test): """ Run query-cpu-model-expansion for each CPU model, and validate results + + :avocado: tags=3Darch:x86_64 """ =20 def test(self): --=20 2.21.0 From nobody Sat Apr 27 04:06:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568162762; cv=none; d=zoho.com; s=zohoarc; b=hkS990qyRQeQF+jivgLSM1QMmR5+BwtSymXOPg3b59egzveKbtE34Mjw0vuIZ+12iq2jjOxrws8UFIkhHaDY/tbhv4iJ/n31jiX4YVbpwm3c2E/27eNZlqte5sT6uFqPlkF4grWhK0+qxtTuUC2jsLnIIKilRUYh4WS7Pf88jLg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568162762; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=steYvMCFmhbKhkI3yvK2FNnfakMR/sfG5hLyELFXLc4=; b=IPQ9ATlr1AC1MqO1m4Qbc1E/iWZHAoJEr58WuAdZIJYtGBJZLtJVxBvLGT9xLvnBSZWVMIw7EIfxeBUcW7N7SqV2H6A2QBkXc/UDHFOq0BJlc2Dtpj5HE6NKwuDKIlbO0UVGTYKj/DQDr2VJzKG5LkrpktvIOghIMIZm7PV8+Mg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568162762804743.9744512106836; Tue, 10 Sep 2019 17:46:02 -0700 (PDT) Received: from localhost ([::1]:45690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7qlg-0002ct-IZ for importer@patchew.org; Tue, 10 Sep 2019 20:45:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46343) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7qi9-0007XZ-Lp for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7qi8-00080u-SJ for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50234) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7qi8-00080l-Mz for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:16 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1939B197BCEF for ; Wed, 11 Sep 2019 00:42:16 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-121-171.rdu2.redhat.com [10.10.121.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54653601A5; Wed, 11 Sep 2019 00:42:15 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Tue, 10 Sep 2019 20:42:03 -0400 Message-Id: <20190911004204.29286-4-crosa@redhat.com> In-Reply-To: <20190911004204.29286-1-crosa@redhat.com> References: <20190911004204.29286-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.70]); Wed, 11 Sep 2019 00:42:16 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 3/4] tests/acceptance/cpu_queries.py: add machine tag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Willian Rampazzo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This is for informational / filtering purposes only, that is, allows one to run all tests with machine model "none". Signed-off-by: Cleber Rosa --- tests/acceptance/cpu_queries.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries= .py index 1028588920..9cd6f553ff 100644 --- a/tests/acceptance/cpu_queries.py +++ b/tests/acceptance/cpu_queries.py @@ -15,6 +15,7 @@ class QueryCPUModelExpansion(Test): Run query-cpu-model-expansion for each CPU model, and validate results =20 :avocado: tags=3Darch:x86_64 + :avocado: tags=3Dmachine:none """ =20 def test(self): --=20 2.21.0 From nobody Sat Apr 27 04:06:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568162871; cv=none; d=zoho.com; s=zohoarc; b=YXJF/p2EujXwKiC/ka0tKGSiURq8PXXTKhzPOaJXx+ysyfiQwEMvXYLXuygotcik9Je4Lj+UfvoUzThbTmLhOduBpre8w5l7zoBcCDkNba1autGhHQvAPAS2zLQfe1LvORFUP1CZuWheh4qinUyvNlJAOsBq8jPhs7t9wwhY4JU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568162871; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=wf6CbuGeDancohNaWCyYWoDs6drQfwGGOJR9KygbDXg=; b=ceUcuuaqYaLsoRtVh9xYpn0f7MjUruPmSPdvAObfN0bNslaBzVukyUrprnbAbBJzgOXZj1SGM424Ok+5ZB1q0M3KLaw3Fp+t6p7WFbzXDlubFHLwCAzTyEGyiHY3bwWDvnuX3+gA4VOa1X4+vAgYAf2CxX/W+8q1hPuraE6kypQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568162871878601.3929789232408; Tue, 10 Sep 2019 17:47:51 -0700 (PDT) Received: from localhost ([::1]:45696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7qnW-0003cM-Nu for importer@patchew.org; Tue, 10 Sep 2019 20:47:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46364) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7qiA-0007Xx-SQ for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7qi9-00081F-PP for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41722) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7qi9-00080y-Ki for qemu-devel@nongnu.org; Tue, 10 Sep 2019 20:42:17 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 017453174640 for ; Wed, 11 Sep 2019 00:42:17 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-121-171.rdu2.redhat.com [10.10.121.171]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3CA3760166; Wed, 11 Sep 2019 00:42:16 +0000 (UTC) From: Cleber Rosa To: qemu-devel@nongnu.org Date: Tue, 10 Sep 2019 20:42:04 -0400 Message-Id: <20190911004204.29286-5-crosa@redhat.com> In-Reply-To: <20190911004204.29286-1-crosa@redhat.com> References: <20190911004204.29286-1-crosa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 11 Sep 2019 00:42:17 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 4/4] tests/acceptance/cpu_queries.py: minor optmizations X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Willian Rampazzo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This avoids the second loop over the cpus, and reuses some of the variables. Signed-off-by: Cleber Rosa --- tests/acceptance/cpu_queries.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/tests/acceptance/cpu_queries.py b/tests/acceptance/cpu_queries= .py index 9cd6f553ff..54aa310fb8 100644 --- a/tests/acceptance/cpu_queries.py +++ b/tests/acceptance/cpu_queries.py @@ -25,9 +25,8 @@ class QueryCPUModelExpansion(Test): =20 cpus =3D self.vm.command('query-cpu-definitions') for c in cpus: - self.assertNotIn('', c['unavailable-features'], c['name']) - - for c in cpus: - model =3D {'name': c['name']} - e =3D self.vm.command('query-cpu-model-expansion', model=3Dmod= el, type=3D'full') - self.assertEquals(e['model']['name'], c['name']) + model_name =3D c['name'] + self.assertNotIn('', c['unavailable-features'], model_name) + e =3D self.vm.command('query-cpu-model-expansion', + model=3D{'name': model_name}, type=3D'full= ') + self.assertEquals(e['model']['name'], model_name) --=20 2.21.0