From nobody Wed May 1 22:53:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568107848; cv=none; d=zoho.com; s=zohoarc; b=MRpq18lm1omWSpvAnEm1CDlBto+Xv4sLlQ7PHTZcs9s2T5DN7W9hE5JUl+64Zf3U3xBsOOwUYkhTTKHIdVHs8Xk9Vab4mW22vjAbfWNE+em+RpJ81dlndif/3hBtgV5+2hY2i78D5r6qmDCSKn7KcbEzwX+dRgmsMq7Z7LBnLPc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568107848; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=FGjnTYJ2Af8DIz7kltihghxm2A4OXqfQtdK40cfwRfg=; b=KMsTao7Emm8pnInx9HvuP8y371j1wsZ1h841eq5cAnkpS+7jFQ+WANl8MAa/1J71mfDcnH90Da2/Wuxiy6tbApS6LGu+juePcWrBGkehr+SI8ILeOHwGwYyXu3ANf8+ArX2tD37pGoAfuXuFDXmSuf1lCZNfbymmakPg1O4QUfI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568107848625654.7809796186144; Tue, 10 Sep 2019 02:30:48 -0700 (PDT) Received: from localhost ([::1]:36608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7cU3-0007wc-DV for importer@patchew.org; Tue, 10 Sep 2019 05:30:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40700) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7c8R-0004fb-3x for qemu-devel@nongnu.org; Tue, 10 Sep 2019 05:08:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7c8P-00022e-Vh for qemu-devel@nongnu.org; Tue, 10 Sep 2019 05:08:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38224) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7c8P-00021n-Q4 for qemu-devel@nongnu.org; Tue, 10 Sep 2019 05:08:25 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60979300183D; Tue, 10 Sep 2019 09:08:24 +0000 (UTC) Received: from steredhat.redhat.com (ovpn-117-150.ams2.redhat.com [10.36.117.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id B1934100194E; Tue, 10 Sep 2019 09:08:22 +0000 (UTC) From: Stefano Garzarella To: qemu-devel@nongnu.org Date: Tue, 10 Sep 2019 11:08:21 +0200 Message-Id: <20190910090821.28327-1-sgarzare@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 10 Sep 2019 09:08:24 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] elf-ops.h: fix int overflow in load_elf() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" This patch fixes a possible integer overflow when we calculate the total size of ELF segments loaded. Reported-by: Coverity (CID 1405299) Signed-off-by: Stefano Garzarella Reviewed-by: Alex Benn=C3=A9e --- Now we are limited to INT_MAX, should load_elf() returns ssize_t to support bigger ELFs? --- include/hw/elf_ops.h | 6 ++++++ hw/core/loader.c | 1 + 2 files changed, 7 insertions(+) diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h index 1496d7e753..46dd3bf413 100644 --- a/include/hw/elf_ops.h +++ b/include/hw/elf_ops.h @@ -485,6 +485,12 @@ static int glue(load_elf, SZ)(const char *name, int fd, } } =20 + if (mem_size > INT_MAX - total_size) { + error_report("ELF total segments size is too big to load " + "max is %d)", INT_MAX); + goto fail; + } + /* address_offset is hack for kernel images that are linked at the wrong physical address. */ if (translate_fn) { diff --git a/hw/core/loader.c b/hw/core/loader.c index 32f7cc7c33..feda52fa88 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -44,6 +44,7 @@ =20 #include "qemu/osdep.h" #include "qemu-common.h" +#include "qemu/error-report.h" #include "qapi/error.h" #include "hw/hw.h" #include "disas/disas.h" --=20 2.21.0