[Qemu-devel] [PATCH] win32: fix README file in NSIS installer

Paolo Bonzini posted 1 patch 4 years, 6 months ago
Test docker-quick@centos7 passed
Test docker-clang@ubuntu passed
Test FreeBSD passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190909130840.25117-1-pbonzini@redhat.com
Maintainers: Stefan Weil <sw@weilnetz.de>
qemu.nsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] win32: fix README file in NSIS installer
Posted by Paolo Bonzini 4 years, 6 months ago
Adjust after the rST conversion and consequent renaming.

Fixes: 336a7451e8803c21a2da6e7d1eca8cfb8e8b219a
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 qemu.nsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu.nsi b/qemu.nsi
index d0df0f4e3a..da18438071 100644
--- a/qemu.nsi
+++ b/qemu.nsi
@@ -119,7 +119,7 @@ Section "${PRODUCT} (required)"
     File "${SRCDIR}\Changelog"
     File "${SRCDIR}\COPYING"
     File "${SRCDIR}\COPYING.LIB"
-    File "${SRCDIR}\README"
+    File "${SRCDIR}\README.rst"
     File "${SRCDIR}\VERSION"
 
     File "${BINDIR}\*.bmp"
-- 
2.21.0


Re: [Qemu-devel] [PATCH] win32: fix README file in NSIS installer
Posted by Philippe Mathieu-Daudé 4 years, 6 months ago
On 9/9/19 3:08 PM, Paolo Bonzini wrote:
> Adjust after the rST conversion and consequent renaming.
> 
> Fixes: 336a7451e8803c21a2da6e7d1eca8cfb8e8b219a
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  qemu.nsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu.nsi b/qemu.nsi
> index d0df0f4e3a..da18438071 100644
> --- a/qemu.nsi
> +++ b/qemu.nsi
> @@ -119,7 +119,7 @@ Section "${PRODUCT} (required)"
>      File "${SRCDIR}\Changelog"
>      File "${SRCDIR}\COPYING"
>      File "${SRCDIR}\COPYING.LIB"
> -    File "${SRCDIR}\README"
> +    File "${SRCDIR}\README.rst"
>      File "${SRCDIR}\VERSION"
>  
>      File "${BINDIR}\*.bmp"
> 

Also:

-- >8 --
@@ -211,7 +211,7 @@ Section "Uninstall"
     Delete "$INSTDIR\Changelog"
     Delete "$INSTDIR\COPYING"
     Delete "$INSTDIR\COPYING.LIB"
-    Delete "$INSTDIR\README"
+    Delete "$INSTDIR\README.rst"
     Delete "$INSTDIR\VERSION"
     Delete "$INSTDIR\*.bmp"
     Delete "$INSTDIR\*.bin"
---

With the snippet amended:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [Qemu-devel] [PATCH] win32: fix README file in NSIS installer
Posted by Daniel P. Berrangé 4 years, 6 months ago
On Mon, Sep 09, 2019 at 03:17:00PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/9/19 3:08 PM, Paolo Bonzini wrote:
> > Adjust after the rST conversion and consequent renaming.
> > 
> > Fixes: 336a7451e8803c21a2da6e7d1eca8cfb8e8b219a
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> >  qemu.nsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/qemu.nsi b/qemu.nsi
> > index d0df0f4e3a..da18438071 100644
> > --- a/qemu.nsi
> > +++ b/qemu.nsi
> > @@ -119,7 +119,7 @@ Section "${PRODUCT} (required)"
> >      File "${SRCDIR}\Changelog"
> >      File "${SRCDIR}\COPYING"
> >      File "${SRCDIR}\COPYING.LIB"
> > -    File "${SRCDIR}\README"
> > +    File "${SRCDIR}\README.rst"
> >      File "${SRCDIR}\VERSION"
> >  
> >      File "${BINDIR}\*.bmp"
> > 
> 
> Also:
> 
> -- >8 --
> @@ -211,7 +211,7 @@ Section "Uninstall"
>      Delete "$INSTDIR\Changelog"
>      Delete "$INSTDIR\COPYING"
>      Delete "$INSTDIR\COPYING.LIB"
> -    Delete "$INSTDIR\README"
> +    Delete "$INSTDIR\README.rst"
>      Delete "$INSTDIR\VERSION"
>      Delete "$INSTDIR\*.bmp"
>      Delete "$INSTDIR\*.bin"
> ---
> 
> With the snippet amended:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|