[Qemu-devel] [PULL 0/8] qtests and misc patches

Thomas Huth posted 8 patches 4 years, 6 months ago
Test docker-clang@ubuntu failed
Test FreeBSD passed
Test checkpatch passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190905083049.11645-1-thuth@redhat.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Richard Henderson <rth@twiddle.net>, Laurent Vivier <lvivier@redhat.com>, Juan Quintela <quintela@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Thomas Huth <thuth@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Alistair Francis <alistair@alistair23.me>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>, Jason Wang <jasowang@redhat.com>, Corey Minyard <minyard@acm.org>, David Gibson <david@gibson.dropbear.id.au>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Stefan Berger <stefanb@linux.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, John Snow <jsnow@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Amit Shah <amit@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>
There is a newer version of this series
MAINTAINERS                   |   2 +-
docs/qemu-block-drivers.texi  |  72 +++++-----
docs/qemu-cpu-models.texi     |  10 +-
qemu-doc.texi                 |  81 +++++------
qemu-options.hx               | 128 ++++++++---------
tests/ahci-test.c             |   1 -
tests/bios-tables-test.c      |   1 -
tests/cpu-plug-test.c         |   2 +-
tests/display-vga-test.c      |   2 +-
tests/e1000e-test.c           |   2 +-
tests/fdc-test.c              |   2 +-
tests/i440fx-test.c           |   2 +-
tests/i82801b11-test.c        |   2 +-
tests/intel-hda-test.c        |   2 +-
tests/ioh3420-test.c          |   2 +-
tests/ipmi-kcs-test.c         |   3 +-
tests/ivshmem-test.c          |   3 -
tests/libqos/e1000e.c         |  16 ++-
tests/libqos/virtio-mmio.c    |  14 +-
tests/libqos/virtio-pci.c     |  14 +-
tests/libqos/virtio.c         |  20 +--
tests/libqos/virtio.h         |   6 +-
tests/libqtest-single.h       | 315 ++++++++++++++++++++++++++++++++++++++++++
tests/libqtest.c              |  13 --
tests/libqtest.h              | 289 --------------------------------------
tests/m25p80-test.c           |   2 +-
tests/migration-test.c        |   6 +-
tests/qos-test.c              |   2 +-
tests/rtas-test.c             |   1 -
tests/rtc-test.c              |   2 +-
tests/rtl8139-test.c          |   2 +-
tests/test-arm-mptimer.c      |   2 +-
tests/test-netfilter.c        |   2 +-
tests/test-x86-cpuid-compat.c |   2 +-
tests/tmp105-test.c           |   2 +-
tests/tpm-crb-test.c          |   2 +-
tests/tpm-tests.c             |   2 +-
tests/tpm-tis-test.c          |   2 +-
tests/usb-hcd-ohci-test.c     |   2 +-
tests/usb-hcd-uhci-test.c     |   2 +-
tests/usb-hcd-xhci-test.c     |   2 +-
tests/vhost-user-test.c       |   2 +-
tests/virtio-blk-test.c       |   5 +-
tests/virtio-ccw-test.c       |   2 +-
tests/virtio-net-test.c       |   2 +-
tests/virtio-scsi-test.c      |   2 +-
tests/virtio-serial-test.c    |   2 +-
tests/vm/Makefile.include     |   1 +
48 files changed, 546 insertions(+), 509 deletions(-)
create mode 100644 tests/libqtest-single.h
[Qemu-devel] [PULL 0/8] qtests and misc patches
Posted by Thomas Huth 4 years, 6 months ago
 Hi Peter,

the following changes since commit a8b5ad8e1faef0d1bb3e550530328e8ec76fe87c:

  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2019-09-04 17:22:34 +0100)

are available in the Git repository at:

  https://gitlab.com/huth/qemu.git tags/pull-request-2019-09-05

for you to fetch changes up to 7bb21c0ac301e423b483dd7fc171b0d7b56de2cf:

  qemu-doc: Do not hard-code the name of the QEMU binary (2019-09-05 09:45:09 +0200)

----------------------------------------------------------------
- Make the core libqtest library independent from global_qtest
- Clean up docs from hard-coded qemu-system-* names
----------------------------------------------------------------

Thomas Huth (8):
      tests/migration: Do not use functions anymore that rely on global_qtest
      tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest
      tests/libqos: Replace clock_step with qtest_clock_step in virtio code
      tests: Remove unnecessary global_qtest references
      tests/libqtest: Move global_test wrapper function into a separate header
      tests/libqtest: Use libqtest-single.h in tests that require global_qtest
      tests/vm: Take the J=x setting into account for the vm-boot-ssh targets, too
      qemu-doc: Do not hard-code the name of the QEMU binary

 MAINTAINERS                   |   2 +-
 docs/qemu-block-drivers.texi  |  72 +++++-----
 docs/qemu-cpu-models.texi     |  10 +-
 qemu-doc.texi                 |  81 +++++------
 qemu-options.hx               | 128 ++++++++---------
 tests/ahci-test.c             |   1 -
 tests/bios-tables-test.c      |   1 -
 tests/cpu-plug-test.c         |   2 +-
 tests/display-vga-test.c      |   2 +-
 tests/e1000e-test.c           |   2 +-
 tests/fdc-test.c              |   2 +-
 tests/i440fx-test.c           |   2 +-
 tests/i82801b11-test.c        |   2 +-
 tests/intel-hda-test.c        |   2 +-
 tests/ioh3420-test.c          |   2 +-
 tests/ipmi-kcs-test.c         |   3 +-
 tests/ivshmem-test.c          |   3 -
 tests/libqos/e1000e.c         |  16 ++-
 tests/libqos/virtio-mmio.c    |  14 +-
 tests/libqos/virtio-pci.c     |  14 +-
 tests/libqos/virtio.c         |  20 +--
 tests/libqos/virtio.h         |   6 +-
 tests/libqtest-single.h       | 315 ++++++++++++++++++++++++++++++++++++++++++
 tests/libqtest.c              |  13 --
 tests/libqtest.h              | 289 --------------------------------------
 tests/m25p80-test.c           |   2 +-
 tests/migration-test.c        |   6 +-
 tests/qos-test.c              |   2 +-
 tests/rtas-test.c             |   1 -
 tests/rtc-test.c              |   2 +-
 tests/rtl8139-test.c          |   2 +-
 tests/test-arm-mptimer.c      |   2 +-
 tests/test-netfilter.c        |   2 +-
 tests/test-x86-cpuid-compat.c |   2 +-
 tests/tmp105-test.c           |   2 +-
 tests/tpm-crb-test.c          |   2 +-
 tests/tpm-tests.c             |   2 +-
 tests/tpm-tis-test.c          |   2 +-
 tests/usb-hcd-ohci-test.c     |   2 +-
 tests/usb-hcd-uhci-test.c     |   2 +-
 tests/usb-hcd-xhci-test.c     |   2 +-
 tests/vhost-user-test.c       |   2 +-
 tests/virtio-blk-test.c       |   5 +-
 tests/virtio-ccw-test.c       |   2 +-
 tests/virtio-net-test.c       |   2 +-
 tests/virtio-scsi-test.c      |   2 +-
 tests/virtio-serial-test.c    |   2 +-
 tests/vm/Makefile.include     |   1 +
 48 files changed, 546 insertions(+), 509 deletions(-)
 create mode 100644 tests/libqtest-single.h

Re: [Qemu-devel] [PULL 0/8] qtests and misc patches
Posted by Peter Maydell 4 years, 6 months ago
On Thu, 5 Sep 2019 at 09:30, Thomas Huth <thuth@redhat.com> wrote:
>
>  Hi Peter,
>
> the following changes since commit a8b5ad8e1faef0d1bb3e550530328e8ec76fe87c:
>
>   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2019-09-04 17:22:34 +0100)
>
> are available in the Git repository at:
>
>   https://gitlab.com/huth/qemu.git tags/pull-request-2019-09-05
>
> for you to fetch changes up to 7bb21c0ac301e423b483dd7fc171b0d7b56de2cf:
>
>   qemu-doc: Do not hard-code the name of the QEMU binary (2019-09-05 09:45:09 +0200)
>
> ----------------------------------------------------------------
> - Make the core libqtest library independent from global_qtest
> - Clean up docs from hard-coded qemu-system-* names
> ----------------------------------------------------------------
>
> Thomas Huth (8):
>       tests/migration: Do not use functions anymore that rely on global_qtest
>       tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest
>       tests/libqos: Replace clock_step with qtest_clock_step in virtio code
>       tests: Remove unnecessary global_qtest references
>       tests/libqtest: Move global_test wrapper function into a separate header
>       tests/libqtest: Use libqtest-single.h in tests that require global_qtest
>       tests/vm: Take the J=x setting into account for the vm-boot-ssh targets, too
>       qemu-doc: Do not hard-code the name of the QEMU binary

Hi; I'm afraid this fails to build:

/home/pm/qemu/tests/virtio-9p-test.c: In function ‘v9fs_req_init’:
/home/pm/qemu/tests/virtio-9p-test.c:162:16: error: ‘global_qtest’
undeclared (first use in this function); did you mean ‘g_file_test’?
     req->qts = global_qtest;
                ^~~~~~~~~~~~
                g_file_test
/home/pm/qemu/tests/virtio-9p-test.c:162:16: note: each undeclared
identifier is reported only once for each function it appears in
/home/pm/qemu/rules.mak:69: recipe for target 'tests/virtio-9p-test.o' failed


thanks
-- PMM

Re: [Qemu-devel] [PULL 0/8] qtests and misc patches
Posted by Thomas Huth 4 years, 6 months ago
On 05/09/2019 12.14, Peter Maydell wrote:
> On Thu, 5 Sep 2019 at 09:30, Thomas Huth <thuth@redhat.com> wrote:
>>
>>  Hi Peter,
>>
>> the following changes since commit a8b5ad8e1faef0d1bb3e550530328e8ec76fe87c:
>>
>>   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2019-09-04 17:22:34 +0100)
>>
>> are available in the Git repository at:
>>
>>   https://gitlab.com/huth/qemu.git tags/pull-request-2019-09-05
>>
>> for you to fetch changes up to 7bb21c0ac301e423b483dd7fc171b0d7b56de2cf:
>>
>>   qemu-doc: Do not hard-code the name of the QEMU binary (2019-09-05 09:45:09 +0200)
>>
>> ----------------------------------------------------------------
>> - Make the core libqtest library independent from global_qtest
>> - Clean up docs from hard-coded qemu-system-* names
>> ----------------------------------------------------------------
>>
>> Thomas Huth (8):
>>       tests/migration: Do not use functions anymore that rely on global_qtest
>>       tests/libqos/e1000e: Make e1000e libqos functions independent from global_qtest
>>       tests/libqos: Replace clock_step with qtest_clock_step in virtio code
>>       tests: Remove unnecessary global_qtest references
>>       tests/libqtest: Move global_test wrapper function into a separate header
>>       tests/libqtest: Use libqtest-single.h in tests that require global_qtest
>>       tests/vm: Take the J=x setting into account for the vm-boot-ssh targets, too
>>       qemu-doc: Do not hard-code the name of the QEMU binary
> 
> Hi; I'm afraid this fails to build:
> 
> /home/pm/qemu/tests/virtio-9p-test.c: In function ‘v9fs_req_init’:
> /home/pm/qemu/tests/virtio-9p-test.c:162:16: error: ‘global_qtest’
> undeclared (first use in this function); did you mean ‘g_file_test’?
>      req->qts = global_qtest;
>                 ^~~~~~~~~~~~
>                 g_file_test
> /home/pm/qemu/tests/virtio-9p-test.c:162:16: note: each undeclared
> identifier is reported only once for each function it appears in
> /home/pm/qemu/rules.mak:69: recipe for target 'tests/virtio-9p-test.o' failed

Oh, that's unexpected since my gitlab-ci pipeline worked fine:

 https://gitlab.com/huth/qemu/pipelines/80403573

Looks like both, my local system and the gitlab-ci are missing
libcap-devel and/or libattr-devel, so that the 9P stuff does not get
built :-(

Time for some fix-up patches ...

 Thomas